agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: pg_plan_advice: Fix defects in JOIN_ORDER advice feedback.
2+ messages / 1 participants
[nested] [flat]
* pgsql: pg_plan_advice: Fix defects in JOIN_ORDER advice feedback.
@ 2026-09-17 15:41 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Robert Haas @ 2026-09-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_plan_advice: Fix defects in JOIN_ORDER advice feedback.
This commit fixes several related problems. All of these problems
escaped testing for the same reason: they do not occur when only
generated advice is supplied, and therefore test_plan_advice was
incapable of detecting these shortcomings.
First, prior to this commit, the advice feedback code never regarded
an unordered sublist of a JOIN_ORDER specification as matching an
unrolled join. As a result, when JOIN_ORDER() advice contained
unordered sublists, the advice feedback tended to be "matched, failed"
even when the advice worked exactly as intended. Only the case where
an unordered sublist was implemented by a plan shape not subject to
unrolling, such as a partitionwise join, worked properly.
Second, prior to this commit, a join order sublist in the initial
position wasn't properly handled. Note that this overlaps with the
problem described in the previous paragraph; JOIN_ORDER({a b} c) was
broken both because of the unordered sublist and because of the
sublist being in the initial position. However, there's more to this
case: JOIN_ORDER((a b) c) means the same as JOIN_ORDER(a b c), but the
advice feedback code didn't know that, and would generate "matched,
failed" for the former case even when everything was working.
Finally, prior to this commit, advice feedback didn't correctly handle
single-element sublists. Those are pretty nonsensical, since by
definition a join involves at least 2 tables, so we could just ban
that case. Instead, at least for now, I've chosen to make advice
feedback handle such cases in the same way that advice enforcement
already does: the extra grouping levels are simply disregarded, so
that JOIN_ORDER({a} ((b))) is enforced in the same way as, and also
gets the same advice feedback as, JOIN_ORDER(a b).
Reported-by: Noah Misch <noah@leadboat.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CA+TgmoYmXy-jiP5qDhqNEiYFEBzQsArO6O2d9E8szNZqi1bePQ@mail.gmail.com
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e1d8f81d4961ca6c4228eb9a3ab5d36168008e42
Modified Files
--------------
contrib/pg_plan_advice/expected/join_order.out | 205 ++++++++++++++-
contrib/pg_plan_advice/expected/partitionwise.out | 58 +++++
contrib/pg_plan_advice/pgpa_walker.c | 296 +++++++++++++++++-----
contrib/pg_plan_advice/sql/join_order.sql | 51 ++++
contrib/pg_plan_advice/sql/partitionwise.sql | 8 +
5 files changed, 554 insertions(+), 64 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pg_plan_advice: Fix defects in JOIN_ORDER advice feedback.
@ 2026-09-17 15:41 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Robert Haas @ 2026-09-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_plan_advice: Fix defects in JOIN_ORDER advice feedback.
This commit fixes several related problems. All of these problems
escaped testing for the same reason: they do not occur when only
generated advice is supplied, and therefore test_plan_advice was
incapable of detecting these shortcomings.
First, prior to this commit, the advice feedback code never regarded
an unordered sublist of a JOIN_ORDER specification as matching an
unrolled join. As a result, when JOIN_ORDER() advice contained
unordered sublists, the advice feedback tended to be "matched, failed"
even when the advice worked exactly as intended. Only the case where
an unordered sublist was implemented by a plan shape not subject to
unrolling, such as a partitionwise join, worked properly.
Second, prior to this commit, a join order sublist in the initial
position wasn't properly handled. Note that this overlaps with the
problem described in the previous paragraph; JOIN_ORDER({a b} c) was
broken both because of the unordered sublist and because of the
sublist being in the initial position. However, there's more to this
case: JOIN_ORDER((a b) c) means the same as JOIN_ORDER(a b c), but the
advice feedback code didn't know that, and would generate "matched,
failed" for the former case even when everything was working.
Finally, prior to this commit, advice feedback didn't correctly handle
single-element sublists. Those are pretty nonsensical, since by
definition a join involves at least 2 tables, so we could just ban
that case. Instead, at least for now, I've chosen to make advice
feedback handle such cases in the same way that advice enforcement
already does: the extra grouping levels are simply disregarded, so
that JOIN_ORDER({a} ((b))) is enforced in the same way as, and also
gets the same advice feedback as, JOIN_ORDER(a b).
Reported-by: Noah Misch <noah@leadboat.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CA+TgmoYmXy-jiP5qDhqNEiYFEBzQsArO6O2d9E8szNZqi1bePQ@mail.gmail.com
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0f433a6b3576cc9d381c653ba9799960ac2e64c3
Modified Files
--------------
contrib/pg_plan_advice/expected/join_order.out | 205 ++++++++++++++-
contrib/pg_plan_advice/expected/partitionwise.out | 58 +++++
contrib/pg_plan_advice/pgpa_walker.c | 296 +++++++++++++++++-----
contrib/pg_plan_advice/sql/join_order.sql | 51 ++++
contrib/pg_plan_advice/sql/partitionwise.sql | 8 +
5 files changed, 554 insertions(+), 64 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-17 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 15:41 pgsql: pg_plan_advice: Fix defects in JOIN_ORDER advice feedback. Robert Haas <rhaas@postgresql.org>
2026-09-17 15:41 pgsql: pg_plan_advice: Fix defects in JOIN_ORDER advice feedback. Robert Haas <rhaas@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox