agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Fix join removal when Vars reference the removed join via its al
5+ messages / 1 participants
[nested] [flat]
* pgsql: Fix join removal when Vars reference the removed join via its al
@ 2026-09-19 13:50 Richard Guo <rguo@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Richard Guo @ 2026-09-19 13:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix join removal when Vars reference the removed join via its alias
When a join has an alias, the parser marks every Var referenced
through that alias with the join's RT index as its syntactic referent
(varnosyn), even though varno points at the underlying base relation.
Since commit 2ebf25e7d, join removal strips the removed relids from
the query tree using ChangeVarNodes() with INVALID_VAR, which asserts
that the relid doesn't appear in any field identifying a single
relation. A varnosyn that names the removed join violates that, so a
query like
SELECT j.x FROM (t1 s(x) LEFT JOIN t2 ON s.x = t2.a) j;
with t2.a unique fails an assertion. In non-assert builds, varnosyn
is silently set to INVALID_VAR.
Such syntactic references are still valid after the removal: the join
is only taken out of the jointree, and its RTE remains in the
rangetable through to the finished plan. So, when deleting a relid,
leave varnosyn unchanged, as join removal did before 2ebf25e7d.
Back-patch to v16, as with commit 2ebf25e7d.
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMbWs484SQSdzWTgZYKvwtuC6J4m7acw0LfBjp3aWPvav7gC_w@mail.gmail.com
Backpatch-through: 16
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a8bb1a77795bab6e1304efa5c5dabee797b6887e
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 11 ++++++-----
src/test/regress/expected/join.out | 12 ++++++++++++
src/test/regress/sql/join.sql | 4 ++++
3 files changed, 22 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix join removal when Vars reference the removed join via its al
@ 2026-09-19 13:50 Richard Guo <rguo@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Richard Guo @ 2026-09-19 13:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix join removal when Vars reference the removed join via its alias
When a join has an alias, the parser marks every Var referenced
through that alias with the join's RT index as its syntactic referent
(varnosyn), even though varno points at the underlying base relation.
Since commit 2ebf25e7d, join removal strips the removed relids from
the query tree using ChangeVarNodes() with INVALID_VAR, which asserts
that the relid doesn't appear in any field identifying a single
relation. A varnosyn that names the removed join violates that, so a
query like
SELECT j.x FROM (t1 s(x) LEFT JOIN t2 ON s.x = t2.a) j;
with t2.a unique fails an assertion. In non-assert builds, varnosyn
is silently set to INVALID_VAR.
Such syntactic references are still valid after the removal: the join
is only taken out of the jointree, and its RTE remains in the
rangetable through to the finished plan. So, when deleting a relid,
leave varnosyn unchanged, as join removal did before 2ebf25e7d.
Back-patch to v16, as with commit 2ebf25e7d.
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMbWs484SQSdzWTgZYKvwtuC6J4m7acw0LfBjp3aWPvav7gC_w@mail.gmail.com
Backpatch-through: 16
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c04649d1d36f5f7a9dd6b4bffb4fcadd4e2513d7
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 11 ++++++-----
src/test/regress/expected/join.out | 12 ++++++++++++
src/test/regress/sql/join.sql | 4 ++++
3 files changed, 22 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix join removal when Vars reference the removed join via its al
@ 2026-09-19 13:50 Richard Guo <rguo@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Richard Guo @ 2026-09-19 13:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix join removal when Vars reference the removed join via its alias
When a join has an alias, the parser marks every Var referenced
through that alias with the join's RT index as its syntactic referent
(varnosyn), even though varno points at the underlying base relation.
Since commit 2ebf25e7d, join removal strips the removed relids from
the query tree using ChangeVarNodes() with INVALID_VAR, which asserts
that the relid doesn't appear in any field identifying a single
relation. A varnosyn that names the removed join violates that, so a
query like
SELECT j.x FROM (t1 s(x) LEFT JOIN t2 ON s.x = t2.a) j;
with t2.a unique fails an assertion. In non-assert builds, varnosyn
is silently set to INVALID_VAR.
Such syntactic references are still valid after the removal: the join
is only taken out of the jointree, and its RTE remains in the
rangetable through to the finished plan. So, when deleting a relid,
leave varnosyn unchanged, as join removal did before 2ebf25e7d.
Back-patch to v16, as with commit 2ebf25e7d.
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMbWs484SQSdzWTgZYKvwtuC6J4m7acw0LfBjp3aWPvav7gC_w@mail.gmail.com
Backpatch-through: 16
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/051db7737c18b1c5d25cdc4ad508608c4b53fafc
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 11 ++++++-----
src/test/regress/expected/join.out | 12 ++++++++++++
src/test/regress/sql/join.sql | 4 ++++
3 files changed, 22 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix join removal when Vars reference the removed join via its al
@ 2026-09-19 13:50 Richard Guo <rguo@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Richard Guo @ 2026-09-19 13:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix join removal when Vars reference the removed join via its alias
When a join has an alias, the parser marks every Var referenced
through that alias with the join's RT index as its syntactic referent
(varnosyn), even though varno points at the underlying base relation.
Since commit 2ebf25e7d, join removal strips the removed relids from
the query tree using ChangeVarNodes() with INVALID_VAR, which asserts
that the relid doesn't appear in any field identifying a single
relation. A varnosyn that names the removed join violates that, so a
query like
SELECT j.x FROM (t1 s(x) LEFT JOIN t2 ON s.x = t2.a) j;
with t2.a unique fails an assertion. In non-assert builds, varnosyn
is silently set to INVALID_VAR.
Such syntactic references are still valid after the removal: the join
is only taken out of the jointree, and its RTE remains in the
rangetable through to the finished plan. So, when deleting a relid,
leave varnosyn unchanged, as join removal did before 2ebf25e7d.
Back-patch to v16, as with commit 2ebf25e7d.
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMbWs484SQSdzWTgZYKvwtuC6J4m7acw0LfBjp3aWPvav7gC_w@mail.gmail.com
Backpatch-through: 16
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bd003dca09221998f801da15400e340800cbb0b6
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 11 ++++++-----
src/test/regress/expected/join.out | 12 ++++++++++++
src/test/regress/sql/join.sql | 4 ++++
3 files changed, 22 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix join removal when Vars reference the removed join via its al
@ 2026-09-19 13:50 Richard Guo <rguo@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Richard Guo @ 2026-09-19 13:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix join removal when Vars reference the removed join via its alias
When a join has an alias, the parser marks every Var referenced
through that alias with the join's RT index as its syntactic referent
(varnosyn), even though varno points at the underlying base relation.
Since commit 2ebf25e7d, join removal strips the removed relids from
the query tree using ChangeVarNodes() with INVALID_VAR, which asserts
that the relid doesn't appear in any field identifying a single
relation. A varnosyn that names the removed join violates that, so a
query like
SELECT j.x FROM (t1 s(x) LEFT JOIN t2 ON s.x = t2.a) j;
with t2.a unique fails an assertion. In non-assert builds, varnosyn
is silently set to INVALID_VAR.
Such syntactic references are still valid after the removal: the join
is only taken out of the jointree, and its RTE remains in the
rangetable through to the finished plan. So, when deleting a relid,
leave varnosyn unchanged, as join removal did before 2ebf25e7d.
Back-patch to v16, as with commit 2ebf25e7d.
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMbWs484SQSdzWTgZYKvwtuC6J4m7acw0LfBjp3aWPvav7gC_w@mail.gmail.com
Backpatch-through: 16
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9df23331f09b7ffa51fe6f09597a54a7936dfe82
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 11 ++++++-----
src/test/regress/expected/join.out | 12 ++++++++++++
src/test/regress/sql/join.sql | 4 ++++
3 files changed, 22 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-09-19 13:50 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 13:50 pgsql: Fix join removal when Vars reference the removed join via its al Richard Guo <rguo@postgresql.org>
2026-09-19 13:50 pgsql: Fix join removal when Vars reference the removed join via its al Richard Guo <rguo@postgresql.org>
2026-09-19 13:50 pgsql: Fix join removal when Vars reference the removed join via its al Richard Guo <rguo@postgresql.org>
2026-09-19 13:50 pgsql: Fix join removal when Vars reference the removed join via its al Richard Guo <rguo@postgresql.org>
2026-09-19 13:50 pgsql: Fix join removal when Vars reference the removed join via its al Richard Guo <rguo@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox