agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Forbid pg_get_multixact_stats() during recovery 2+ messages / 1 participants [nested] [flat]
* pgsql: Forbid pg_get_multixact_stats() during recovery @ 2026-09-24 00:36 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2026-09-24 00:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Forbid pg_get_multixact_stats() during recovery MultiXactState->oldestOffset is not maintained during recovery, so calling pg_get_multixact_stats() in this context would report misleading information. We could try to work this out by adding this field to the control file, for example, but such a change would be too invasive at this stage of the v19 development cycle. The information of pg_get_multixact_stats() is usually useful to control the need of some VACUUM or some freezing, operations that cannot happen on a standby, so the argument to make the function work while recovery is in progress gets thinner with this point in the balance. The function is updated to return an ERROR when called under RecoveryInProgress(). Per discussion with Heikki Linnakangas and Naga Appani. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/CA+QeY+DcnsZRL4GZD8JyJu5HD-d6p8_9M5kT4jgF3gq3Rh8n4w@mail.gmail.com Discussion: https://postgr.es/m/20260827231757.78.noahmisch@microsoft.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4545cee303c257e58195e3d033c05bf38e2cd4d6 Modified Files -------------- src/backend/utils/adt/multixactfuncs.c | 8 ++++++++ 1 file changed, 8 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Forbid pg_get_multixact_stats() during recovery @ 2026-09-24 00:36 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2026-09-24 00:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Forbid pg_get_multixact_stats() during recovery MultiXactState->oldestOffset is not maintained during recovery, so calling pg_get_multixact_stats() in this context would report misleading information. We could try to work this out by adding this field to the control file, for example, but such a change would be too invasive at this stage of the v19 development cycle. The information of pg_get_multixact_stats() is usually useful to control the need of some VACUUM or some freezing, operations that cannot happen on a standby, so the argument to make the function work while recovery is in progress gets thinner with this point in the balance. The function is updated to return an ERROR when called under RecoveryInProgress(). Per discussion with Heikki Linnakangas and Naga Appani. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/CA+QeY+DcnsZRL4GZD8JyJu5HD-d6p8_9M5kT4jgF3gq3Rh8n4w@mail.gmail.com Discussion: https://postgr.es/m/20260827231757.78.noahmisch@microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8fbbb338bed77c6fa8dc6fa309cbcca93c1c2d72 Modified Files -------------- src/backend/utils/adt/multixactfuncs.c | 8 ++++++++ 1 file changed, 8 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-24 00:36 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-24 00:36 pgsql: Forbid pg_get_multixact_stats() during recovery Michael Paquier <michael@paquier.xyz> 2026-09-24 00:36 pgsql: Forbid pg_get_multixact_stats() during recovery Michael Paquier <michael@paquier.xyz>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox