Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_7874ADDB-CD8B-478F-B815-AB4F225FBDEA";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: extension_control_path and "directory"
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: 
 <CAFY6G8cmNw6H=Xz8Q45eKVy9aSKLy+GASGiq55nsnyxVo_pcwg@mail.gmail.com>
Date: Tue, 29 Apr 2025 10:08:26 -0400
Cc: Christoph Berg <myon@debian.org>,
 Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Message-Id: <E36A12DF-B8F7-4D48-AAD2-90A8A1220BA5@justatheory.com>
References: <E1tumbY-003Dl3-2o@gemulon.postgresql.org>
 <aAi1VACxhjMhjFnb@msg.df7cb.de>
 <CAFY6G8dDjimxaSQV68ExWMmrAi8xNhiOT3RZOD8oQZmdGCG5Jg@mail.gmail.com>
 <aAjwPjsIElh17Nby@msg.df7cb.de>
 <3C304C9E-976C-4FB9-A883-707E0B90756A@justatheory.com>
 <CAFY6G8c=W8CMFwcx2fA0RSFtvw=5BDGKOjGSV=nEUiZ6use2Bw@mail.gmail.com>
 <aAoQkqwktHQI5KLO@msg.df7cb.de>
 <CAFY6G8d-4Nb34dqb_92kGrXfo4tO012m-9YzznKmb7f5JhJpEA@mail.gmail.com>
 <546E7C54-D2F4-4DBB-9A06-EBBF90265A2C@justatheory.com>
 <CAFY6G8fjaVpkZHFk3CQR=ShiysZ3Y_ti568-vuKYOrMepLB_sQ@mail.gmail.com>
 <672C8C5E-519A-4B39-9421-E6C31917B271@justatheory.com>
 <CAFY6G8dwnxqBDcQbVYfjJJ6RYMTxc04gip64Nx7X2fk4ggA+rQ@mail.gmail.com>
 <FD339F84-2BCE-4994-B298-388EEF179892@justatheory.com>
 <CAFY6G8cmNw6H=Xz8Q45eKVy9aSKLy+GASGiq55nsnyxVo_pcwg@mail.gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/E36A12DF-B8F7-4D48-AAD2-90A8A1220BA5%40justatheory.com>
Precedence: bulk


--Apple-Mail=_7874ADDB-CD8B-478F-B815-AB4F225FBDEA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 29, 2025, at 09:49, Matheus Alcantara <matheusssilv97@gmail.com> =
wrote:

> Yes, it is a single path from the search path, in your case it will be
> "/Users/david/Downloads/share/postgresql" and "$system". We split =
these
> paths based on the system path separator and get the next "piece" =
here:
>=20
>            char       *piece =3D first_path_var_separator(ecp);
>=20
> The first_path_var_separator() changes the "ecp" parameter on every =
call,
> it returns the next path on "ecp" and changes it to have the remaining
> paths to iterate over it.

Right. My point is a minor one, but I thin you can use an if/ else =
there:

```c
if (strcmp(piece, "$system") =3D=3D 0) {
	/* Substitute the path macro if needed */
	mangled =3D substitute_path_macro(piece, "$system", system_dir);
} else {
	/*
	* Append "extension" suffix in case is a custom extension
	* control path.
	*/
	mangled =3D psprintf("%s/extension", mangled);
}
```

Best,

David


--Apple-Mail=_7874ADDB-CD8B-478F-B815-AB4F225FBDEA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgQ3VoACgkQkt9idPjI
gfHw2Q/+PiH8ZwX6fMPzca0ydnWW+TcZ4TiozEBi+I1BNnbBZwnNrYFMDQkNOUnb
uEs6gTIpEI3XdZqbhN/cqspPAo2y+lBeYI+XVwW1dLABump8yRMq2WpB5Mb1YUW+
hCFXkBoFUbEe1Y6F44UGdeanmt435FMCQtYSOFJ29BSIjTQSWUBe/ZBZORdHq27S
tZB+4rYmpj0sGQOaLd6OgPicIT7OhnvC1WHwLaL+8+gCQQ5Mh+KHGEUif2miXVf5
b3EfhKeZV3fCkCZxvU5zuqeYWneDNUXaiz0zJ9FocWl13ps/G+bDRi+2u1m28Cp+
Il+213AzP9yWWFsYAvYpPAdXdcu5vbzgqKkO4T4uxsoZ5KygVroswTNUAAIljOrh
kUoQ0jk4nKCQ1clM1UnK0tUpZ00YwzvWBdj9ql296/2EYEOcT7f5gVU6gawl1iI6
Tdb/YOWFVHpNURysaHICuwZfR9kmnNo5k7g28BOQa1ycEOVeYBpfd0ZkLevKUlWG
AYZ0ZOkBRevr/uzcGHnfyIgDuEFNbLTGAUJwV3Vr1ZnjAeTPaJAlSbdjWhDSmhUP
tFOk26UDAmIW9xoozpxMZplfc+DazE6b5kYdKw5kJN/SQL913TV1oXr53zRA0e8q
a2sMjttGF0Am5j5+bWtMDu0x3RrCV9gHp59zFZrMJB3iuLAhcko=
=nEXa
-----END PGP SIGNATURE-----

--Apple-Mail=_7874ADDB-CD8B-478F-B815-AB4F225FBDEA--