Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dshzL-0003w4-Ti for pgsql-committers@arkaria.postgresql.org; Fri, 15 Sep 2017 04:12:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dshzK-0005Hi-FQ for pgsql-committers@arkaria.postgresql.org; Fri, 15 Sep 2017 04:12:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dshz5-0004rg-Al for pgsql-committers@postgresql.org; Fri, 15 Sep 2017 04:12:07 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dshz2-0001W5-Ew for pgsql-committers@postgresql.org; Fri, 15 Sep 2017 04:12:06 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EB79320CB3; Fri, 15 Sep 2017 00:12:02 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 15 Sep 2017 00:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ttm92la3JH52Zyv6ze5dmEbetGQjTchq2fwimY2gQzo=; b=p+2GJgiI Y7r+TorAkNX7ulJdI4nLeOX1+hx1plUOEVmvoPbjxlm85ruDqkTFpsj9b0OO4Eu7 7fduj5MWC9lv2K34ZQBmCYc8zwH7OfyOz0xpeF23vimpGHc9aXK0KIzQOpMVkA4z +wp7jIZ1BV/EQzsZhm0w6ZP3ZNeqlHez6La23socMT0mv856f24xgSWTx+pJXV9A WAVVbm+OHf8vh6vO/++QvyzpdHIlMd7s9BMjfcHrKXsVhECiwgZA8k7LXDCOAGDV AKEKVuCTi+oRmqNLEBUMdoFZYMUHyMCGN9T3AMq/t2vwiV1HzB6FF7wWrdsbYQ0M vP7JoYQQyWpx3g== X-ME-Sender: X-Sasl-enc: WMuXkpcUofP6SBiLe7VJM5ewe4m+kkn3HU28DVK8EgV/ 1505448722 Received: from [IPv6:2607:fb90:2287:804f:c79f:e5ce:c21:1960] (unknown [172.56.16.92]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A4B17E8F0; Fri, 15 Sep 2017 00:12:02 -0400 (EDT) Date: Thu, 14 Sep 2017 21:11:58 -0700 User-Agent: K-9 Mail for Android In-Reply-To: References: <13971.1505445491@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke To: Thomas Munro ,Tom Lane CC: pgsql-committers From: Andres Freund Message-ID: List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On September 14, 2017 8:38:09 PM PDT, Thomas Munro wrote: >On Fri, Sep 15, 2017 at 3:18 PM, Tom Lane wrote: >> Andres Freund writes: >>> Add support for coordinating record typmods among parallel workers. >> >> Buildfarm not happy ... > >My compiler, C++ and more recent C standards are OK with identical >redefinition of a typedef like that, but not the older standards or >those particular compilers. D'oh. (I should figure out how to make >my automatic patch tester this fussy). I think we should probably >just do this: > >diff --git a/src/include/access/session.h >b/src/include/access/session.h >index 8376dc53127..910a9815d78 100644 >--- a/src/include/access/session.h >+++ b/src/include/access/session.h >@@ -13,9 +13,7 @@ > #define SESSION_H > > #include "lib/dshash.h" >- >-/* Defined in typcache.c */ >-typedef struct SharedRecordTypmodRegistry SharedRecordTypmodRegistry; >+#include "utils/typcache.h" > > /* >* A struct encapsulating some elements of a user's session. For now >this Sorry for missing that during review - unfortunately I don't have a compute= r with me now - so I won't get around to this till tomorrow... Andres --=20 Sent from my Android device with K-9 Mail. Please excuse my brevity. --=20 Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers