Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: pgsql: Clean up role created in new subscription test.
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <202311081232.rn3aho5ay6yx@alvherre.pgsql>
Date: Wed, 8 Nov 2023 14:06:09 +0100
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FC40D564-3286-4AE7-A15A-926810300110@yesql.se>
References: <202311081232.rn3aho5ay6yx@alvherre.pgsql>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Archived-At: 
 <https://www.postgresql.org/message-id/FC40D564-3286-4AE7-A15A-926810300110%40yesql.se>
Precedence: bulk

> On 8 Nov 2023, at 13:32, Alvaro Herrera <alvherre@alvh.no-ip.org> =
wrote:
>=20
> On 2023-Nov-08, Daniel Gustafsson wrote:
>=20
>> Since test_setup.sql is part of the regress schedule and not =
pg_regress we
>> would have to implement this for each test run (regress, contribs =
etc), which
>> is what Peter didn't like about the original suggestion.
>=20
> Oh, somehow that aspect of his reply failed to register with me.  I
> agree with your approach of using libpq in pg_regress then.
>=20
> I suppose you're just thinking of using PQexec() or whatever, run one
> query with sufficient ORDER BY, save the result, and at the end of the
> test run just run the same query and compare that they are =
cell-by-cell
> identical?  This sounds a lot simpler than the patch you posted.

Correct, that's my plan.  The rationale for the earlier patch was to =
avoid
adding a dependency on libpq, but with that already discussed and done =
we can
leverage the fact that we can run such queries easy.

--
Daniel Gustafsson