Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_EC4B9A6B-3605-4D2D-ACC1-864D5C216261";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: extension_control_path and "directory"
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: 
 <CAFY6G8dwnxqBDcQbVYfjJJ6RYMTxc04gip64Nx7X2fk4ggA+rQ@mail.gmail.com>
Date: Mon, 28 Apr 2025 16:49:23 -0400
Cc: Christoph Berg <myon@debian.org>,
 Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Message-Id: <FD339F84-2BCE-4994-B298-388EEF179892@justatheory.com>
References: <E1tumbY-003Dl3-2o@gemulon.postgresql.org>
 <aAi1VACxhjMhjFnb@msg.df7cb.de>
 <CAFY6G8dDjimxaSQV68ExWMmrAi8xNhiOT3RZOD8oQZmdGCG5Jg@mail.gmail.com>
 <aAjwPjsIElh17Nby@msg.df7cb.de>
 <3C304C9E-976C-4FB9-A883-707E0B90756A@justatheory.com>
 <CAFY6G8c=W8CMFwcx2fA0RSFtvw=5BDGKOjGSV=nEUiZ6use2Bw@mail.gmail.com>
 <aAoQkqwktHQI5KLO@msg.df7cb.de>
 <CAFY6G8d-4Nb34dqb_92kGrXfo4tO012m-9YzznKmb7f5JhJpEA@mail.gmail.com>
 <546E7C54-D2F4-4DBB-9A06-EBBF90265A2C@justatheory.com>
 <CAFY6G8fjaVpkZHFk3CQR=ShiysZ3Y_ti568-vuKYOrMepLB_sQ@mail.gmail.com>
 <672C8C5E-519A-4B39-9421-E6C31917B271@justatheory.com>
 <CAFY6G8dwnxqBDcQbVYfjJJ6RYMTxc04gip64Nx7X2fk4ggA+rQ@mail.gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/FD339F84-2BCE-4994-B298-388EEF179892%40justatheory.com>
Precedence: bulk


--Apple-Mail=_EC4B9A6B-3605-4D2D-ACC1-864D5C216261
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Apr 25, 2025, at 17:18, Matheus Alcantara <matheusssilv97@gmail.com> =
wrote:

> Ok, I was testing using extension_control_path =3D =
'$system:/my/custom/path'
> (starting with the macro) and it was working as expected, testing with
> the macro at the end does not work.

Great example of why it=E2=80=99s useful to do as much testing as =
possible! That=E2=80=99s an entirely reasonable place to start testing =
:-)

> The problem was on find_extension_control_filename() that was =
appending
> the /extension at the end of the entire extension_control_path GUC =
value
> instead of just the custom paths.

Oh yeah, lol, that wouldn=E2=80=99t work.

> To append the /extension at each path on extension_control_path would
> require some changes on find_in_path() that
> find_extension_control_filename() calls, which I think that it would
> make the function more complicated. I've them created a similar
> find_in_paths() function that works in the same way but it receives a
> List of paths instead of the string of paths separated by ":". We can
> get this List of paths using get_extension_control_directories() that
> also handle the macro substitution like find_in_path().
>=20
> Attached v4 with these fixes. I hope that now you should be able to =
omit
> the /extension from the GUC value.

Yes! It now works with this configuration:

```ini
extension_control_path =3D =
'/Users/david/Downloads/share/postgresql:$system'
dynamic_library_path =3D =
'/Users/david/Downloads/lib/postgresql:$libdir=E2=80=99
```

Which is nicely more consistent. Kind of want that first one to be =
called =E2=80=9Cshare_path=E2=80=9D now, though, since it=E2=80=99s not =
just extensions. Although I guess it=E2=80=99s only extension control =
file searching that uses it (for now).

If I understand this bit correctly:

```c
            /* Substitute the path macro if needed */
mangled =3D substitute_path_macro(piece, "$system", system_dir);

/*
* Append "extension" suffix in case is a custom extension control
* path.
*/
if (strcmp(piece, "$system") !=3D 0)
mangled =3D psprintf("%s/extension", mangled);
```

The value of `piece` is a single path from the search path, right? If =
so, I think it=E2=80=99s either `$system` or something else; I don=E2=80=99=
t it would ever be that `$system` is a substring of a single path. Is =
that right?

Other than that, I think this patch is good to go. Thanks!

Best,

David

`=

--Apple-Mail=_EC4B9A6B-3605-4D2D-ACC1-864D5C216261
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgP6dMACgkQkt9idPjI
gfHaBw/9EIUm9k+nX6Is2KWGo45KS4dbmGBpzlxKX6Ocz26meFLhziSaMa9l3wjX
5rYcb19zbSfhJ7GQKyMmYtId3VK4+DnxnUrbbtKFz7l85khL+XGJDiy1qqEGcgy0
m5bQdHKiO7JHOTsVL1LaX4ZTZ03IV2fUDuCxk0ShaFP3ie0artGTOsCS+hwU6Grn
R9Q5jUHgs8BJJLJvr4C/u6RScQv8k4jFqEJlxWlasu1/6yzaebdRA6ZiujeQXcIj
Z6ui9DKEi/HE4BnRZL4SrRLJI3vyZX1pIoKaDPM+r2/326PluuaM00KqWBnlsyeA
8aTqD/YJtG6aRSDZeD3nOqxZX+w2qj3bKvUh+0/8wb3QMFBzAisVCOZKkX7ipn0D
QHKDo99sqguvmzgtyOAmMvqLcgToisAsJCm5oSfJgkQHxbH3haE0WSlALU7rRX7E
VnSRRAiGbPNdfx4SSxSwmJOayx337gNhw41gWEKkdbBYlQ9lpQCbwJuH8z1XY6zZ
olMVedhRtDd879yxD0AylRecI2cPNvjhdHhuG4adNEZrrKAwh2D9AMH6/lVlrKLi
gmX6nsCBFlYnZGzWT34kEiw5aJsu26h5lYvu+WJlb9ytY7hnRz7DAYQUniUhRgqZ
eZMI0SB43bvffIRs5XFEJqUxr8MJbcSemJfD69b3C90OMDB7pdo=
=PdPH
-----END PGP SIGNATURE-----

--Apple-Mail=_EC4B9A6B-3605-4D2D-ACC1-864D5C216261--