Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okdsF-0006am-38 for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Oct 2022 04:06:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1okdsD-0000Bz-M5 for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Oct 2022 04:06:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okdsC-0000Bp-6q for pgsql-hackers@lists.postgresql.org; Tue, 18 Oct 2022 04:06:37 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okds4-0002dT-HA for pgsql-hackers@lists.postgresql.org; Tue, 18 Oct 2022 04:06:35 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 0D168320096F; Tue, 18 Oct 2022 00:06:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 18 Oct 2022 00:06:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1666065983; x=1666152383; bh=UIw4IQbgX/ cNhNxlV06OvOTT8AgvSI1fqbuPCTWm37M=; b=MHI6Dyr4E4Ohdf6GKGnrqWeZeu DtqAAPjKyUG+gAr/FKBJCsw0SXQDMGRpHuLXGbyMqpb1yTCwmR/hCwxfMdGo2E1p IJQxlF2dej6hZdm1+gnIbRO+PuxNLUsy95ynleLiWcHynpb9qrzeKze5KP6SEA/t YnkKdJGCculWJF/UBr0A+fytCOkBTu9EcstSgpuGHAPYjvkmqi6K9hW91c8SU2xA mgaDislKGtDJr6K4zxQY2aHz33aFg/scvX0Xv0g1li8ejOVC5R5gY0l4Bbd2T4ho gsKQcFw3uh+8okxGarelE9+PcT8Qp+FWfKIlVyjQtk9p+/su+8iIN9Hn3FUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666065983; x=1666152383; bh=UIw4IQbgX/cNhNxlV06OvOTT8Agv SI1fqbuPCTWm37M=; b=lAh6MlO+YK4f/Xz0kzaDjYsBSczJ6NNv2J87L17r9mSL BuvKLkvqQ57yttdosv28yocUnOghky9z/RUpDRmhFA5QlRsI5DYKnpltdUjk7Q46 Kw04u0ZXhTsUgAdJ41JbU2Lprfwr7aI5AObKQzxqa1y+A1nQYCAHKiTUYC9Ku95O lTc9uWo/CassSR4CS3saKIc6lgAlqioLZTAHCPOpCSVKobKNc9EyWOivPIA7RA1r fMV9IyDRGOWo7/lbs69LfadiIMwJw8k4W/iXmWSssYfDBTE3XvlRKIp1/zebfuz6 c1w7iHuhy/fPwESzWkxSwrgG7Y2gqxxftVcjF1F8cg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeltddgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Oct 2022 00:06:19 -0400 (EDT) Date: Tue, 18 Oct 2022 13:06:15 +0900 From: Michael Paquier To: Thomas Munro Cc: Justin Pryzby , Andres Freund , pgsql-hackers@lists.postgresql.org Subject: Re: pg_upgrade test failure Message-ID: References: <20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de> <20220920013122.GA31833@telsasoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2gyOlNtVsDEyPon0" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --2gyOlNtVsDEyPon0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 18, 2022 at 09:47:37AM +1300, Thomas Munro wrote: > * Server 2019, as used on CI, still uses the traditional NT semantics > (unlink is asynchronous, when all handles closes) > * the fix I proposed has the right effect (I will follow up with tests > to demonstrate) Wow, nice investigation. And cirrus does not offer a newer option either.. Do you think that Windows server 2022 (successor of 2019) is able to use POSIX semantics for unlink()? It looks that we are a few years away from being able to do that assuming that cirrus offers a newer version than server 2019, but I guess that the code could mention this possibility in a comment, at least.. -- Michael --2gyOlNtVsDEyPon0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNOJjcACgkQnvQgOdby QH0SWxAAohAdAfsU+VWngq0UXDwNCnSbEERDX4G1mJMC6KFtDpsCC1SDdfYtxS5R rPHzC+GIwvIV9a/LNWBUGpluA/jCOwJ+RqhHHrn5jyR0N0kgXgdnIwElA6fFTQ97 g0mpmOxjcrdMRSJgbIiGf4gsqXe3rS8t4tHOirgDOVN+1Adv0o7XGgrWOX2j9nnk lr1FCQVNSFmovULankFGc2C62UkaRWywePtqnDyvBopZfjYqbr1mckJQq97Ibs7x 6+jDFb01OmD1SH1U+fk9UeFbE8yesrtlveQbMdZy3m8WPEm0aoamUKaTGwhmQWVo jb5zC0XO3P0S/l/I//JCtjtviZa1EuDkr7hvZ5YT+zAU2oQg6sd2rAcDcils6qRn hEwZnFqzctqxQZ14XgLkJXyYAESfzyKBp+QZG6IxNNPvBx2l5zE1+dSLVwH7WSzv ppZv+5L2N6k7X3wAlV4S86oZ8tMXOR62c6uVe9Dn7iBoVzcd53Q4FFvADWE2UfgH X5jOVqeEpDowAEZZ0H9xCG8PD3H9ksvmiuy+Ng6HLrlailaGT5vSRKoYyDtfuklx 8qWqNSaSCZrM/ISp5MJKv/HoRGf/A66nhViCguMAFkecCRi6kCWWSMeq1o5j/Zh1 WQNttofMgZc/oapdhHzYAeO7nkJdR+gLLkp8623ndfGpUgTB8NE= =jSd8 -----END PGP SIGNATURE----- --2gyOlNtVsDEyPon0--