Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKoeE-0003hk-NR for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 22:53:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKoeD-0002jV-8L for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 22:53:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKoeC-0002hz-Fg for pgsql-hackers@lists.postgresql.org; Wed, 25 Jan 2023 22:53:40 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKoe7-0006yY-0e for pgsql-hackers@postgresql.org; Wed, 25 Jan 2023 22:53:39 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 77DD65C04EC; Wed, 25 Jan 2023 17:53:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 25 Jan 2023 17:53:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1674687213; x=1674773613; bh=dA+dH9Us32 6a6/3NnGT/6ft720gerDC2u6nXCpPvFfA=; b=BZShu+t4dsGzl6/pZnyDPacr3Z FzPRD5UkPwJwUb9kk/SvNvEd1uL9lnIiwB8tPQXHB6sI3/7bqSluA5Rz0Gvy6U42 8HyZA/ndS986vtZTI5LAz4RhPooSYnoxQbBfs7MBiFY8GWBdkZ31EP/inBPcDxW9 KyGWBCVUlEFfWh0nwb9Ho8TgNjAsZycSdTQSzk63IY8/TSqx5YIZAwtu05GpC6fR tIlseD5vyhtnCCm+pKxC8OzcE6bdS0VY9SNT06VWDhV9Xq+16VcN5S64C+esVn6f c6RgekwQAwhybi7zHYz2NglO5tmd2/sF9XTZJLtTVKg4Wlv5WfVC1KrXwuvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674687213; x=1674773613; bh=dA+dH9Us326a6/3NnGT/6ft720ge rDC2u6nXCpPvFfA=; b=UjghkbfZRnrrmo2MIbHCkTUiNotAoJPJ2SQYvFR4wQbE cMSsJCIAVVm+c4+pdscQfpaAScKNUS3qmDRaSksVifWlMC1k1e2zz5P1uXttpGjD +Dgb2+Y2t8KH7+To8ODh6ocxZZ3vZbkdIfNPMK1uZAXVsvktrNgxEc1NkvuP+l55 OJp5QUlLrX9tTm/u1msCB1M4cNAwF9juz/f/1pO2pxfFAD3EGZK08JblLImKAG5k lf+OBZx6oFZ3+55QCVWDicPQnyU9eM5RvVtfz6NRAnyEpRaN1tIgI+4d8tq2xD/v VmNOngazYoCpe2vhb1f2rjao5Cg1AAPoNrYhL9Cr0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvfedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Jan 2023 17:53:31 -0500 (EST) Date: Thu, 26 Jan 2023 07:53:25 +0900 From: Michael Paquier To: Nathan Bossart Cc: Andres Freund , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module Message-ID: References: <20230125181750.GC1098626@nathanxps13> <20230125215801.zhqe7t67uhdxai5g@awork3.anarazel.de> <20230125224118.GB1164580@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gBJvJ1GE75925611" Content-Disposition: inline In-Reply-To: <20230125224118.GB1164580@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --gBJvJ1GE75925611 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 25, 2023 at 02:41:18PM -0800, Nathan Bossart wrote: > This is my preference. If Michael and Robert are okay with it, I think > this is what we should do. Else, I'll create separate basic_archive and > basic_restore modules. Grouping both things into the same module has the advantage to ease the configuration, at least in the example, where the archive directory GUC can be used for both paths. Regarding the renaming, I pushed for that. There's little love for it as far as I can see, so will revert accordingly. Keeping basic_archive as name for the module while it includes recovery is fine by me. -- Michael --gBJvJ1GE75925611 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPRsuUACgkQnvQgOdby QH1+nxAAlXYPGQBYWcXcgdPTCcs23Xr2ILf2rkXiW0tf6m+6cIAQvQVGkmm00Rvt HWL80ycvkwVVrDBoi8w9+eN28XDuGcZ0gLf3o5bWAppRQPX7IFordoJF9GIQZeid UuF7G41MtaEIAHVFVAheYx7g8M6z0dCWOHKmPDhzR4fYJ5+mEHuBl3NMkP6tKwj0 XbtnWZypJLmncfEusxG+gTso1WyftW7ePECebg88tG2r525bY+y1qDciKdtcNZ9i vT/gtpknc/+YcOBblpNcqGsjL2SUsdvVBERkF7eQ+1pOiC8FifymgMUCEr7QFmvl 1+59ksFBrBZtc6mkknkcqOe979htTO9/9uXp9FdZiEGd9LXi6G3MlI3Hwz4eYZKQ Ym0iu0trz2usRvI97PRd+27/taLk0VcqTbrYOXLnTrtcGcZTlIknv+QVb92jTkSV OEARYxRpLcFCXxlLatH3aU9e5kcH1cO1g47OkW6rbWXgjCCUNOecV6OaYy4dD9lB x9VYVu6yV00SlG8YB0vIPiYsdgJ22vfg4BeQNn+dyAEzhixAZHuwl4g25BRuGpRe jLuwATtOMjWM5FzjJR5VZh7s9/X8okexHAbUBvVPj0EyGbMqNhrUg83f8nXlIchJ J6M84pEDYOZXINxlR1lpbStt+PquxIFH1xSIS1INyQECZbMhgjk= =YVYD -----END PGP SIGNATURE----- --gBJvJ1GE75925611--