Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLF4D-0008Mz-Gz for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 03:06:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pLF4B-0004GO-8s for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 03:06:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLF4B-0004GE-22 for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 03:06:15 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLF43-0001wt-VA for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 03:06:14 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id DB7AE5C00CF; Thu, 26 Jan 2023 22:06:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 Jan 2023 22:06:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1674788766; x=1674875166; bh=9gTqwwvIpm /wHPb9A1fi+wMO4ilF5Vsde06jfogalH4=; b=Qgm/igCkqfreiRt3cw2wumbWRV rZI1zWz0nuKGHt6zGQmDMnaUWSpoP/vWAUuNpuk5hH+ixzOIU2yYD5/TI0VIFBoj TY4H8b55v1lh42ZD75vlXNt82hUtEV4XUB6r+hgsxjAprVBfEFWn5XKdJu1cA/6n MVCtj61XsisWVYysnv/ezalgiC5+r8PPf/dqF/OdllEIlvaQky7gQHVUAJ1KBKiw XQ7WuBe/Be3IXnMhqujCFMyv5SSiytpV2Qpo0PVqSHgqWYd8IOAlM1p14bfd8V4u cR7Tw8BfonOzudu+KVNVGsvnvSWcnhTFr6gJpjwHamoIJPGopA5PrhrCOeFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674788766; x=1674875166; bh=9gTqwwvIpm/wHPb9A1fi+wMO4ilF 5Vsde06jfogalH4=; b=j9f2vLZmoI+vP0oFsJ2CNYBNVtPdsn1yjPUWwBedCUak F9U+/YHmbeFYFt7Yl0d09b9nBfxex7FTFiMzOeqP6846OCUvp7tek2Hq/OmQtbdU hRC9lZWcx0XHptO7uJZkqxN2roXT5UN7v2I2kXAZDGcLkdfQKpp2Ini3pN/6mAzL lwipIcX/4GYg1VrmkFcHKyzy7vq1jepByCxp1kkbnu+Ng6NtEKaoPIuEIAJ78ah3 g4mSw6xTtR75KgRqVb9DSVfdsrOH2sKuNN//vsusUcCR+K2JLUIXVrDb+gis99HT LlKjWq+MJTCZpdNSjbCtdS9HpoU2rR+LeYkv8if52A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvhedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Jan 2023 22:06:04 -0500 (EST) Date: Fri, 27 Jan 2023 12:06:02 +0900 From: Michael Paquier To: Tom Lane Cc: Justin Pryzby , Andrew Dunstan , Robert Haas , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. Message-ID: References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> <3248936.1674785303@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BpkAxxVdkz1ZJZNc" Content-Disposition: inline In-Reply-To: <3248936.1674785303@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --BpkAxxVdkz1ZJZNc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 26, 2023 at 09:08:23PM -0500, Tom Lane wrote: > Yeah ... if we put it into an existing script, somebody will blindly > add more tests after it someday. I suggest calling it "test_cleanup" > to pair with "test_setup". >=20 > Is it worth checking for leftover regress_xxx tablespaces as well as > roles? Guess so. If this is to be applied to everything that fails under the naming restrictions, there could be a point in doing the same for databases, subscriptions and replication origins. Now the argument has less weight for these object types, surely, compared to roles and tbspaces. -- Michael --BpkAxxVdkz1ZJZNc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPTP5oACgkQnvQgOdby QH3ZBA/+I7vw8uQZFR6E7pO4ojDHQDCGfBkFGc1MwcKPU6LbezS/AkaRWvcOp8xt WUxda4m0A36cGjnmFRPsnNOcTzPfdPvOQurN3YcQUTODT4gZjiMNoKXlyU7WZCAR xdri8AfBsHX4trAeBude5kv0OVRazfk/7IFQ2AIuDK7Wcp/5I6eR433FwtfUzHLu g3B6nRcjGhLVYypVW4ZQeD1ynwJRwgVWlYaYNadOnvMSaE33E5/MCQacRjPbihwB QfDbcnMgZchzmWLhjucxpgLDFF94QZ9iOuWjdFGd0izOKmxK+71HNRO3twP1P5Ei dyL9VFns5kkfSmto1OI5cJl4rI9+LHo9VH86dK0gaV7HO4vlLUvKXw2PRb2sD4hm pFJDZsoOVlDrUTcYR7we3VOHeAM5bU0PHxkQO25Hd18N+fNOR+9HV0HyTCzKoBUk ICL5iW+NkhldI0j8hd8UIiwiarQSm4cCkumqQhStfjk3gsxtMANodYqe1ijjkYA3 /vmgBleU4neftNtErs2+ewDz+b5VjtgGrmynLjZwi7ncnVj9HvHTMUYNWVP8fPnT 0KTEhxVi3Je8ud4g8lygd1UYm8IEcj/Jr5QOfEwNjG6s8aGRY8PVvZaxtLLk8Huh DERVPOiKtEUXIO4M6abhpizbX7puZQgvl1B6Y/bORVyOx6Kb9NE= =ptyV -----END PGP SIGNATURE----- --BpkAxxVdkz1ZJZNc--