Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLCY2-0000WT-05 for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 00:24:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pLCY0-0004dp-SW for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 00:24:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLCXz-0004dg-7i for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 00:24:52 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLCXv-0007IN-Dh for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 00:24:50 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 29C565C0206; Thu, 26 Jan 2023 19:24:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 Jan 2023 19:24:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1674779085; x=1674865485; bh=tFDhV8ioAE YQgVpX/CrOfdF5aLecjwHa5ZouTY5jDU0=; b=ZQszEJri5wrt2Jr7xh9k5upLg9 nmZRSdCiDfsbKw/zuHCclWNsTphqn+EI4lgcX2EczzWieCDFL9PrT9kK94WwfEra e1vj7DQ9oRF/rH66QJeJbYzhqUqVfYwQ0RMiXpBOWv75Xmx2Q4ceLjSfT9FLq5p9 n6yD2y2+MM7ChWOzTRsTivOuOwxQbrAWxxv/jPUrCH0KxoSLVLO8Yr02XJfCJB81 rF1KRlZUB8N2jgMyebJYMjfB6Ul+zzaHsXIhlt8Sv9ikfiLfUV2V5nPzxTPsz+PN nZ7PKn0fZYdd2Xxyolvd6cK12qSF3OcAUq8q15MNG2PxAohjAPo6bNKHMDxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674779085; x=1674865485; bh=tFDhV8ioAEYQgVpX/CrOfdF5aLec jwHa5ZouTY5jDU0=; b=Qvd2EcgGU+p2CISY8s3I1xHd1EqqtKSdu5bbVh8Bgtes 9qMpzmWkZatqWPezjpM7Ye7bdtKqxhMSXk4Sq5dH1SRi7wC6PYi9xkpUvwnyppBE DEfIvpL6MOLxOLHOVvIxfQ3c/IwwrOaKEu6DN1xGw4C8unjQs1k60pr4rOS17gJB HoLeLfUaYlsGHJ7+1GPsmJfq+dEYGE8AQPDkRNeCZku3YnN30wxmBMNQgbRSvy+F UjTt5PD2+vygNOIqw5abOqmksKbZTTKoat2yz2sNlaZ6rijbvjPJncukg1n5xcby d9Js61SFAJICFGWbGX+Jnxrdx9BQaeE/u/FWnlooug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvhedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Jan 2023 19:24:42 -0500 (EST) Date: Fri, 27 Jan 2023 09:24:37 +0900 From: Michael Paquier To: Justin Pryzby Cc: Andrew Dunstan , Robert Haas , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. Message-ID: References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eyA7VovbNzGPTMET" Content-Disposition: inline In-Reply-To: <20230126183106.GS22427@telsasoft.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --eyA7VovbNzGPTMET Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 26, 2023 at 12:31:06PM -0600, Justin Pryzby wrote: > On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote: >> Would it be worth adding a check right at the end of the schedule that >> makes sure there are no such roles left? >=20 > Yes, because the alternative is to have cirrus run "installcheck" > twice.. Agreed about doing something like that, with a new SQL script perhaps? We can rely on -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS here, and I'd like to think that nobody creates such role names or they would see failures with the new query. I can also be a sign that such instances should be cleaned up to allow more repeatability with some tests, actually..=20 -- Michael --eyA7VovbNzGPTMET Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPTGcUACgkQnvQgOdby QH315w//fiu4uyANS6bvCwQJwXQHrv5RCf8eC6LptYMXGza4dTxguxyad3xcO+lf 6b8dgcIriC/IV1I8rGWXZXuFucG28KubyEQ3/OtItnQ1uHX06l+G8Bv23oJHLoAd tmrRo0dfc1IUjfWqA9cwNRCr1wtVXcON9GxDrLwSZFFiK+X48+Z9hJbJy5QFKhh0 /vDXJk3XvSY0S1RGe/lucTQLXFkRPPyPoDmi85dMjS2YQCFziPC4sf40um++arSr /c2BHJCgqSE8KykLm2SE/uLbwcWa2u3ZKByA/E5NYIv/puZM3YacmNsqMQCkOb9t YEfNf0VVVx6IK/gCPJQZAorNgwZix6aRXQM1SEveoC3tL883Pobgnxr8gu9zk8Rv y8EGVSmsTFpu2W00Pn5BAWZLYotJ9zEgJwQZH8ENutTi5GA0A4eq9DDNBQny1POg GiTay+/xwF7alu3uxx56F8xJdJ1isHQu95WgRIabEh1fftFC1zY6DL2XRo0PP/e8 RiAyLTgP13x7L5nnBh+5rCFI1Fxjxj6r+vMN/i4pRnaSkhGEEx5MZb7xp7nN3UVR YLABK0ZDBFl7PQLetwPeQis7ryqnhxiaLshOBGR9OKxBHsDcg/K74Kk1J/A6cBGK 8vUUbQbr8ExDqe/+VXMP5dGqqpGC55w1QaccOmCfdtTegy3Maqc= =wSho -----END PGP SIGNATURE----- --eyA7VovbNzGPTMET--