Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5Lyb-0002WX-Bo for pgsql-committers@arkaria.postgresql.org; Fri, 29 Jan 2021 05:05:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l5Lya-0003Tm-2P for pgsql-committers@arkaria.postgresql.org; Fri, 29 Jan 2021 05:05:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5LyY-0003RR-M1 for pgsql-committers@lists.postgresql.org; Fri, 29 Jan 2021 05:05:43 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5LyW-0001YF-06 for pgsql-committers@lists.postgresql.org; Fri, 29 Jan 2021 05:05:41 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D468C5C0193; Fri, 29 Jan 2021 00:05:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 29 Jan 2021 00:05:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=iHsBBj4QWlNeiwIjhvWa4qi3NJo xZYD1RQu1bSXQX1Y=; b=EdOLtUVYCxr1RV/UPXKK1uBkKGuTBmwUhCWZHo7QNrd Klsft8faRZVGFBHogCDTkhdT7zK7AoCggddO+GPGFnCewdph6uUslQfqH7+ZJazj 4utuJPNl0j2vYfsdcLo/89ji/MCctu824M7hX28AWzrEqoRACpUXPu1J2ER7uzLM sDV7OUOsvV+PFcmH/Y2s43L5SE63OV8YhMPn/okeV/eDZbZgsqtDphy0svHtkVEt n7TdQyyZUXGBEG11THLhPBvcNBV738MWbOnKcYq61dZEeXldMR8uCJ+8Qk7N5pqj 80h/GMZjp/aXftVqXzBNPZ3oo6t0hMWPygW61b10jPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=iHsBBj 4QWlNeiwIjhvWa4qi3NJoxZYD1RQu1bSXQX1Y=; b=kGGrqZYLJsx9U0WsyIqPS7 8KjWROPtU1d0ItiCPyhql/5J5q8YcQ2yy5zwNVqlmWGYbJPRTo9i+b5tKShzSHXG E8nQfm40sl7Svbg234hU9N9BIbd3qpyq7vGNrz7Fa11fKcVu8PDj7DPdh7lhhnVj auqd6FI0+8NyZC2mwc0mz2OXxI00M4HbsuvRl0UCvLF7zodSljXWRTx+g98TQV/n pm8rwliqbhvoPhhkUIyB1E7u538uAEn2dA01KrBL6wHDOAqy5u7veZsTJEfV3srn uDSM0RvGkGSH5hOnxDhFyrRMx1qQJSfhfDutExwrtKKcTdkYWtXvXZIuhcRhvvzg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedugdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecukfhppeduuddurddutddvrddukedtrd dukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id DFB7F108005F; Fri, 29 Jan 2021 00:05:36 -0500 (EST) Date: Fri, 29 Jan 2021 14:05:33 +0900 From: Michael Paquier To: Alvaro Herrera Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Refactor code in tablecmds.c to check and process tablespace mov Message-ID: References: <20210128135629.GA30534@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n5RFCyspTcuAlDwd" Content-Disposition: inline In-Reply-To: <20210128135629.GA30534@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --n5RFCyspTcuAlDwd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 28, 2021 at 10:56:29AM -0300, Alvaro Herrera wrote: > Yep, seems OK to me, assuming that, as you say, you'll update the > comments again when they are used to handle the concurrent cases. That's the idea. I need first to look in depth at what's proposed on the other thread for REINDEX, but I see no reason why the case of REINDEX CONCURRENTLY would not be able to use this stuff. Applied this part for now. Thanks. -- Michael --n5RFCyspTcuAlDwd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmATl50ACgkQnvQgOdby QH1tEA/+Pd7PN9+4juYYtp8wL4pZdXa2WU3RQ1FBMPXqN1su9CDKibjZRYc8w1B6 JHPbouE+068u4kAicLXz8HM2sh/IAFDECFq8Aylx7BUOUy2uQ3bmMY7pByRHrGUr 3FaJ1EN80aLrtuQp6t/69kjsx4Cpd/KEHS1Oafo7QZ06pqDNK3+xIGQYpwuU6p5P 23Ztb6XQT+E19K4MEBfEX+zWMwi0uVqjPBtutPyl17v29R6+4VKhvpnREff2MmTC YckAlKoxt+GOv+HUM0oRl3aFsEEQiCR8O2SoUH+3lVGqbhAgwASkVftQIHWk2d3Z 3l+aEEL4cXZtKAvkUGjjNGOAsnt0dsygbtPWS5xphWxVAbd0ms3BYLWe42sklT/1 nNVnfYTc2Zl5jD1abNSpu9tdL6bLBgLU3paAOaEzUAEuLAc9J3nrok2zIaeJJC14 gslDsxkgq6RMC9dagp+gWdEsoZfAiQkDsD2jqJ8G4pVBAqfyD7i41Azdvw5OZCjy XBEgjkOJmQQIotuNl6zoy4CNFcqxoMq6R4dMGNZQie0DdCST2dmP1sBL4NeCPFmB Ill8qvWbQYF1ruFFhnlGRXQs8cPBU1/4OTMpeQjGlSmzwPA5Rz7c4b6KpbryYLzR bMmTYqp3L7xgREiQSHR8qKK+Y58rpJ6IBgLtTyUyrBO7k32DaOA= =PQ7b -----END PGP SIGNATURE----- --n5RFCyspTcuAlDwd--