Date: Tue, 6 Apr 2021 10:37:53 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Message-ID: <YGu7ceWAiSNQDgH5@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
 <513200.1617634642@sss.pgh.pa.us>
 <YGuSe6Q484Eshj2n@paquier.xyz>
 <932059.1617663467@sss.pgh.pa.us>
 <933130.1617665023@sss.pgh.pa.us>
 <YGunFpb3U9zi5DV4@paquier.xyz>
 <935457.1617668131@sss.pgh.pa.us>
 <CA+hUKGLvexxLBAB_Mb=Eqr6iERW-z74pMVAgKinJ_HK0ZK4O7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fPbVjdOLJso/d5s5"
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGLvexxLBAB_Mb=Eqr6iERW-z74pMVAgKinJ_HK0ZK4O7g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YGu7ceWAiSNQDgH5%40paquier.xyz>
Precedence: bulk


--fPbVjdOLJso/d5s5
Content-Type: multipart/mixed; boundary="hiYu08hTUyoENP10"
Content-Disposition: inline


--hiYu08hTUyoENP10
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 06, 2021 at 12:30:48PM +1200, Thomas Munro wrote:
> Commit f44b9b62 springs to mind.

Right.  The kerberos suite does not do that though, so wouldn't it be
better to use the same trick with -c?  For example, the attached for
~13 does so.
--
Michael

--hiYu08hTUyoENP10
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="kerberos-auth-fail.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/kerberos/t/001_auth.pl b/src/test/kerberos/t/001_auth=
=2Epl
index d476a7800e..8d49847948 100644
--- a/src/test/kerberos/t/001_auth.pl
+++ b/src/test/kerberos/t/001_auth.pl
@@ -177,13 +177,15 @@ sub test_access
 	# need to connect over TCP/IP for Kerberos
 	my ($res, $stdoutres, $stderrres) =3D $node->psql(
 		'postgres',
-		"$query",
+		undef,
 		extra_params =3D> [
 			'-XAtd',
 			$node->connstr('postgres')
 			  . " host=3D$host hostaddr=3D$hostaddr $gssencmode",
 			'-U',
-			$role
+			$role,
+			'-c',
+			$query
 		]);
=20
 	# If we get a query result back, it should be true.

--hiYu08hTUyoENP10--

--fPbVjdOLJso/d5s5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBru3EACgkQnvQgOdby
QH1+FQ//byhvEk4iiOeNSvCTjj8NH0rwiR6G4mQnqpF71e9zB8cu/rLRK9epWGkM
pXo1c3lPKbaz7eNvKPeqhmLs0zNNUwbqU+i50ySW0q+wus4Fe65AzDC6NeNWGSpi
4xfrzfXhP93OEm3eDCe1rNxHgTOOrXR8O8bUl7nRRvz7Iog7+UG4gIv3+KKTSg+G
w3yidlmVtNChXIrum1M4hlT1b8DOlpc+OBfzJJiab5mIEQMU2bL37FFd5PVft6+O
UwfqlRhD8NnDdS+U0f9mC83R1MyfFgBhALk0E+q28M1obx4NNTUxvH2oyzbO4Ez3
951yh7oq5dnk+a36sgHJuPd/cjEEclJZpVZVLa7Sp6jGM8uCBhxLwLy1BF23018M
XCRJbohJ+tDlnRCLRulftAJREXgUEB1ZMXAR/ANQC7/NYExYCGQ0oOTicR38FK5q
YKuCO5nYSN1D7Kc7Ork8qIT0XY6+aEP9LicLfRsvmF86OR22THe5IXgrEK36D+W7
rC9e6H/5DgBovrv0hRvn/qzMhLojjmyzWfyxQKJ1XmXFbKBgsAxS1jKjDMQJt99Y
/SXAgmZPI4uPnmFqX6CCPf/1rF/zVuAMVwvqkGRdg/aIZCI5KpLDh5GXLUZ6h8Z+
OG2sQQPo4NMm6dRvV6d4AODHzNQG+0ZAyt+0JwzoR9rtstEkbN8=
=o3ED
-----END PGP SIGNATURE-----

--fPbVjdOLJso/d5s5--