Date: Tue, 6 Apr 2021 07:43:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Message-ID: <YGuSe6Q484Eshj2n@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
 <513200.1617634642@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qIyzHZoISTn0st8w"
Content-Disposition: inline
In-Reply-To: <513200.1617634642@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YGuSe6Q484Eshj2n%40paquier.xyz>
Precedence: bulk


--qIyzHZoISTn0st8w
Content-Type: multipart/mixed; boundary="W/CW4SUb98eFJ9ML"
Content-Disposition: inline


--W/CW4SUb98eFJ9ML
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 05, 2021 at 10:57:22AM -0400, Tom Lane wrote:
> Some of the buildfarm seems not to like this.  gaur failed here:

Thanks.  I did not notice these.

> I didn't look at the code, but I bet this is similar to the race
> conditions we've seen before where a server process may exit before
> the perl test script finishes stuffing a command down the pipe.

Hmm.  Those failures refer to the 5th and 8th tests of
001_password.pl where connect_ok() is used.  The only logical
differences compared to the previous code are:
- The addition of on_error_stop in connect_ok() to ignore any errors
- The fact that this now defines a SQL query (was undef previously).
- $Test::Builder::Level
So, the problem is with on_error_stop.  That's not necessary anyway,
but I am a bit surprised that this would be an issue.  I'll apply that
to see if it fixes the issue.  If it does not, a revert would be
better at this stage.
--
Michael

--W/CW4SUb98eFJ9ML
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="fix-auth-failure.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index bbde34c929..95e107373b 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -1901,8 +1901,7 @@ sub connect_ok
 		'postgres',
 		$sql,
 		extra_params  =3D> ['-w'],
-		connstr       =3D> "$connstr",
-		on_error_stop =3D> 0);
+		connstr       =3D> "$connstr");
=20
 	is($ret, 0, $test_name);
=20

--W/CW4SUb98eFJ9ML--

--qIyzHZoISTn0st8w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBrknsACgkQnvQgOdby
QH0d+g/+IXWiRM7+IziAar6Rrxc3pn+BuxC0o+bUJr9N6w4ZAiHNu4ROl4yaka4c
YE0ofSKx6DAGnuxIgq0JvUWO2Z2beuNl8Sf1Bwlb6daqkl0JC8ZPloIBTkghD1BJ
J8YVUycsieP03Pk6oMQmTLOLJ9UXRmeKPxKikizBAUVqY5uWg2uEsXr2e0kr5UiO
YL4BhO8WiRb85YSpsDBZGlv9iwjoww/Gyq4ME14npwlGz0jo6VGJQiMZGKU0ctrI
zvyzT/2xW/z6yAFNF/99PVd2iokwpMxcn7qsXqA5o9IznUhyiULlQd9lniTl7jbz
xNyooIDMnV0GWznR1+YKCpmSxYKpZmrcIH3b4QvlxlX142iORoRi3vpdM9EV5/De
d6j2EInXkMcnuOqbkJxzbhSgUrTiHjCkY8TgAtR8b2x3lQ3EoY2ORF58DPKgJQPJ
MlCML3XieOrAUyy/u1ZpXEx9LHSwfYoBNb5QajrlpBDy+CG8/MsaBCeLvCwsdecQ
9t4zisvy6IMziHIobZJ0US1dHLlt0hf4GWz/rpLfetcS6itQiB/Wq6W8fHX0NUad
/cD3j7fiWfjhpBoTm3rjRBFehGDZ7NAR0vcab0ve/0HvpzxUgvsaxZBFxnKgNq7E
oWc1T9u9Bf12gaHBkYeKEmv+cly72W9B3vgsB/9VQQTHYakr45o=
=cS9a
-----END PGP SIGNATURE-----

--qIyzHZoISTn0st8w--