Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYOe-00006c-GE for pgsql-committers@arkaria.postgresql.org; Mon, 05 Apr 2021 23:12:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lTYOd-0003SX-6D for pgsql-committers@arkaria.postgresql.org; Mon, 05 Apr 2021 23:12:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYOd-0003SQ-0x for pgsql-committers@lists.postgresql.org; Mon, 05 Apr 2021 23:12:39 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYOa-0000c7-Cf for pgsql-committers@lists.postgresql.org; Mon, 05 Apr 2021 23:12:37 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9958C5C00E1; Mon, 5 Apr 2021 19:12:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 05 Apr 2021 19:12:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=/XsZVRLYGfkdR6gFyUmfHPY+HhC VI7IyHYn3Cc5V0gc=; b=W3DP7qjr7u6JDuG0gqYtvx0Oj1TDwUPW7vI9apqtc+U uRzlLaxZ+DTwbqeVc4+ELcM4miQGbnft83pciclF970xl+vV47hAn3nZKQJf2c0o ALBjbF2nX/UOK/iJ/1f5mUJLJgml9L7pd5P1czS0A+8Zqi8GNosQmoVE/egIjRms VDIC5D+Y1ztajpH1Wuf5gco6waMufmkjZVs1PwlSHxlXxF1EwRb0iJX2wnPb4nrR Rwbsyvy/M0nM5pTbuTINrw78ToBn4P3O1Aq1cBCcmmQ6muR1bVmKnhMn/O0pcRr9 EIRp85EjJm8ClVtdrKhgipoa/yTrfrdC6hwS4a1eB8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/XsZVR LYGfkdR6gFyUmfHPY+HhCVI7IyHYn3Cc5V0gc=; b=FEXPm8ql1EuHQiNiuVFfLM mRk+dbK7Zu+YJeghmbX+psgNBO8c/d+3tsSTkcZ101MpjKUzpWdyJvG3fzfXOwBD jZfg+ut20c08xvQe1jkpb1+iTdg8B6mMorWOQZahV7cI0oH+Pd9to6pwb4C9XpSV iDpA9Gg2PkMaDvKm8xfaZ5TExFXPqZQRNltmM8Sv+xzxsQJNE+AfC/umI9wVhOML UOTrb3XI2/xc493HN863cBD6K3meH36UGOdYCvYFyPGZLFzAa4u2XKq/up4Y37sR vbRdhkbAor4Fz8I7mGgxrRD6+Cye84CInG8ZxgRnDOG/5NgbvP/Aqf+z7phc6fgQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejfedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhu ihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrh hnpedvgeduuefhtdeuleettdevjeehheeiveeuieegleetgeeljeelieeuieehgeevhfen ucfkphepudduuddruddtvddrudektddrudekheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id F0C071080064; Mon, 5 Apr 2021 19:12:33 -0400 (EDT) Date: Tue, 6 Apr 2021 08:12:31 +0900 From: Michael Paquier To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Refactor all TAP test suites doing connection checks Message-ID: References: <513200.1617634642@sss.pgh.pa.us> <932059.1617663467@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7MKq4slgdDrvlYTe" Content-Disposition: inline In-Reply-To: <932059.1617663467@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --7MKq4slgdDrvlYTe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 05, 2021 at 06:57:47PM -0400, Tom Lane wrote: > No, I bet it is with "now defines a SQL query". That means there's > something to be stuffed down the pipe. >=20 > I find I can reproduce this pretty reliably on slower machines > here, if you want me to dig into it more carefully. Now that I think about it, another thing that has changed in this code is the fact that it calls PostgresNode::psql with a result array rather than just the error result, still I don't see how this would have an impact? If you are right, it would be easy to bypass this error with a change in the connect routines to be able to pass down undefined queries rather than filling in a default one. But that does not feel like the root of it. -- Michael --7MKq4slgdDrvlYTe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBrmV8ACgkQnvQgOdby QH1AoA/+NJJFINVXhF++EiPaCbm93I7W7apCVr75+eSCSxdfoYEhMo5mHksb1Zu+ mj6+bM7xspoYVr7F206RyxncfrMnbiogMfcp1PolMw/G7Pha7V7uC/vLTNPK/nLU DciwN+BQ3m09As2pafQ959kVhlTdDrisUe0zrxTYzKBRALMAm8VOJHvxZ4lHbO6a cFYjyeK5ZFVdgz/5S5wWm+9m0AD7XInFt0JlKGCP8KVc4lbvL6xV9MufhEZeCRmI Z5Y/8Lf3QZtHX7EN1u6Mvk8N3/gQ/1gU4Y3L9W9xbC/Bi2JkqfRWYgshMYneneWC 54/JusBrWjVSqeTfeTGOP+i+gH0zzABuaAiS5bl8FE+I9prJx2dzDC21EppWGw5i BAr54PaJIjHYYIc0a2rne7EBCWCIvARFneyERbVqif5YHpPGSC/vFBah3D9L0zW9 yGa9mGPXtq8fNtpuJWt0VcZQ3bnC+qNzSxTW6kLiOrkULvtVjp4rPD31ynFNlnLN 7YvN8cP1e+HjIRjJv85IwApuV4sXi40EiKMDRfQeeV2N9Rs8gp5tZyHuGkThKHtA ax21n5ocaQoX59ZzHCUxEaob4yh9LU8CqqgGWLA3CHRPiZApSQ852uVaeRGhuKx5 hnfalW5NEYqSx81Jip6lTq+oRuYD2UDphI89N47e3euNwyXfKSA= =FyOg -----END PGP SIGNATURE----- --7MKq4slgdDrvlYTe--