Date: Tue, 6 Apr 2021 09:27:26 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Message-ID: <YGuq7obSb5BviTHz@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
 <513200.1617634642@sss.pgh.pa.us>
 <YGuSe6Q484Eshj2n@paquier.xyz>
 <932059.1617663467@sss.pgh.pa.us>
 <933130.1617665023@sss.pgh.pa.us>
 <YGunFpb3U9zi5DV4@paquier.xyz>
 <935457.1617668131@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8A7M5uvMXbvzLg9I"
Content-Disposition: inline
In-Reply-To: <935457.1617668131@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YGuq7obSb5BviTHz%40paquier.xyz>
Precedence: bulk


--8A7M5uvMXbvzLg9I
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 05, 2021 at 08:15:31PM -0400, Tom Lane wrote:
> Dunno.  Certainly most animals that enable TAP at all should be
> running the "authentication" test, but those others all need to
> be manually enabled, I believe.  My own animals run the SSL test
> but not LDAP or kerberos.

The SSL tests have always sent down a query even for scenarios where
the connection would fail, but they have used command_fails_like()
rather than PostgresNode::psql.  The puzzle does not seem complete.

> I'm fairly sure that we've previously fixed this exact same issue
> in some tests that expected a connection failure ...

Yeah.  Looking at the git history, that would be c757a3da.
test_access() in the kerberos tests sends a SELECT true even for
expected failures, so it seems to me that it would fail with the same
symptoms on those machines.  That looks worth fixing and
backpatching.

And I need more caffeine this morning..  I missed your point that a
connection failure should pass down an undefined query string per
that.  Well, the fix is simple then now that there is a single code
path for all those connection attempts.
--
Michael

--8A7M5uvMXbvzLg9I
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBrqu4ACgkQnvQgOdby
QH10IBAAiz9Hbw/t9FiTW2xIu+evigoo7yaM+9kpkWrbs8JXJNlsU8o6zG4NvPLW
GCtI/TUg7gbqI9M3hAyMFQzgYqQXTu/f7usE9nTzEPoQ8BShqYPqJob7nA1SySGa
IpJYg8KNq9qW6A6ZUQK6YFs8EDbixRrmC6ExEPvh9rl+VF0tBttR4mJi1rY+qme8
Kk/FhKfr8JwaZGSrca4lwfIXB+1mzNydID/ThYIAfG3Lk9mbkvROzJWfi5KGcISV
/twG1knGZhcosLarMBodF6lhfiLosFhsNKJ0Mq8S6ITcQ4R2oHDWIeFldoYy5ejZ
PI5nmxkZtqIqqp4DJtymAIWqLwFNpjjT0p0f4Z1YWk0X0159k18lE6NmtLUFoBEd
l9f55VgI3zDofOn2JjrSZ3v+De6NdHK6ChbDws4V7FNFgXwiHpuGx0fDg3i8kzbh
dFFwjRNBlDAUHp2nLf3QGzO+LSyEdhJjFYT7yP0nQXrsve4VBjaK+2b1jEe0Ybmm
DehMsVQEydM8jnQoXZeCTLaln8SYosJ5SJCpXooHoctJFjCkNuS9927TE6Ss0Tuu
+/Qlrr0SR8ZVb1GnkEuBi9LCWCB6oMhsOAnYs/rf7Fp4Kn7hufHdGEr8CetK+5s7
7bIuOrKfUuzflqItKXtOmpAr0Qc3AbVqUjVmTvmN/dDuKkRQz1Q=
=MTaM
-----END PGP SIGNATURE-----

--8A7M5uvMXbvzLg9I--