Date: Fri, 17 Sep 2021 08:08:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org,
	Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Message-ID: <YUPOfPqqbvuZeouS@paquier.xyz>
References: <E1mQglq-0007xB-Jw@gemulon.postgresql.org>
 <1252480.1631829409@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="cQDyix91im/u1FVT"
Content-Disposition: inline
In-Reply-To: <1252480.1631829409@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YUPOfPqqbvuZeouS%40paquier.xyz>
Precedence: bulk


--cQDyix91im/u1FVT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 16, 2021 at 05:56:49PM -0400, Tom Lane wrote:
> Test case for this seems to have newline-related issues on Windows.

Thanks.  I missed it.

> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dfairywren&dt=3D=
2021-09-16%2018%3A36%3A14
>=20
> #   Failed test 'data_checksums=3Don is reported on an offline cluster st=
dout /(?^:^on$)/'
> #   at t/002_actions.pl line 184.
> #                   'on
> # '
> #     doesn't match '(?^:^on$)'

The regex should match AFAIK, and that worked in my own WIN32,
non-Msys, environment.

I see the business in PostgresNode::command_like_safe to work around
such a case like that in pg_ctl (efd7f8e), very similar to what I am
doing here so an extra chomp() should address this issue.  Shouldn't
we try in the long-term to make the command_checks_* routines use
temporary files rather than the raw outputs if these are not reliable,
by the way?  Adding Andrew in CC about that.

I am not completely sure what's going on here yet, so I'll just switch
the test to be skipped when Msys is involved for now.  That should be
enough to bring back those machines to green.
--
Michael

--cQDyix91im/u1FVT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFDznwACgkQnvQgOdby
QH0jkg/5AUZJO6p4xduQVfR4bJOfASX5WDfu/X9W4jJPzOfnyhpBsQbe0Wr8Hyts
KxXNxVX5HU9wSksXt7NxAM0Grv8EogyCysgfQdX4/7r6u5F/og4+Z45lFgmNdFCJ
GYZZYWQIpGN/Wer/jIg0u0KEuzOsVhE4i6DqamIKfpkBTlUvCndpItZ5+wPsZa2b
QyZOOrjNji77REMuspSiMh2XZi7+vyzcBz+e89VQB+Y1+va6+lQ+SPYnBS8kf+R+
9gzW0YgU0SawZXakCiUQFyHdAkhQNIWQ/2DpEZDtu+YSa0UtaSRD5qH/ub8bCIym
3DaZBJi4TwjLpZy6kX7ZKAXlW3P9cTQHv0oNmJXa3XoJyDoFdenGVo8WsQi+bb2H
V58vqzBY0GKKkdRkhg/Ng44WWpkk48S+84YMPtvM+Z1L8X0YxizL1NnXqm6Nio7g
4+xvFRJwWHTFTilu+xVXCNdCIkTBT+Krg1EbAz4BX8BFuAAWMYC10MDyGvXYXCVP
e/iISEy6IMfpusJzyjJdg4/khuN0XeB9KGWBUjGGdyJrPVfpjWn7OPYDpzBV1O9f
BuNNsndL8Y2WNblpdpxiTyce4LJLwphBFPMIbCBvhOfeDu8B4lUtv4vgtGlafOLV
j5PUKnnKNJLjTPN4aurgtU/PJgCNfUkWVUT4kiDx2mc5zWUNGD8=
=1pmS
-----END PGP SIGNATURE-----

--cQDyix91im/u1FVT--