Date: Tue, 21 Sep 2021 12:47:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Message-ID: <YUlVzPkVgEPjtmIB@paquier.xyz>
References: <E1mQglq-0007xB-Jw@gemulon.postgresql.org>
 <20210921032040.lyl4lcax37aedx2x@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="kFP8zuAt3KbB04Hp"
Content-Disposition: inline
In-Reply-To: <20210921032040.lyl4lcax37aedx2x@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YUlVzPkVgEPjtmIB%40paquier.xyz>
Precedence: bulk


--kFP8zuAt3KbB04Hp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 20, 2021 at 08:20:40PM -0700, Andres Freund wrote:
> So the problem is that -C data_checksums requires permissions to be dropped,
> but the way it's invoked here that's not guaranteed... And I don't think we
> should remove that requirement, given that we're actually doing stuff to the
> lock file...

Hmm.  One way I can think of to keep the test would be something like
that to avoid problems with pg_ctl redirecting the server's stderr to
stdout (hence the tweak for log_min_messages):
pg_ctl start -s -o '-C data_checksums -c log_min_messages=fatal'

This would print the parameter, while getting to stderr mostly a
"could not start server".  Would that work for you?
--
Michael

--kFP8zuAt3KbB04Hp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFJVcwACgkQnvQgOdby
QH3WDhAAjx6ovx/jSYmu/zD6tG1fqwXUeI3BwbXX/mFbzoQZaBBamLswaMz5yALu
p9WWjubmFOkkeunHxU4cB9T1bz7VnhvLOjY18CIM7Xs1zdbEdy3dz3XP3WIw1I72
K3ckYO7npc95A7S1eCmowuknxTTiykSV9zXyI8WlNkdX7HOdxdcfopuzDSSlBkY2
atVswazs0wV83RHp8bHaDQ81LoF8QAzZA3SHWtOOvZ2NvIiIW/w6w5iwmu4p+IOw
AKazI6qD0x/HlPXxp7ObXIocRDTmCQLY3qyDmvavmqScBIYZPzzE4hCxly1mpNgB
QoPNxI622JQ/xAQs6ugynZd97Ed7GvTyGLDGChjth2znZeybjFthHxTyre/foids
DC6nlrgoPYlUCrAZUq8J1sV3j7SWowy4AiRe+1K5J1JaRrUMxgNYNaG5nZ5Na5gH
Xc9C/KK0mR1Mxr16L5wEstEvej58ZOGMGbf5v9PNBXMI15NCZP+mIE8X5Y6DuZGj
nUzLKkCzL1J7fXeWXUewhq7hKSAmpbM1qwrbmirFfHQbBUet5bT2XM2BGNWjm37u
Eu29pUOAkTGX6SitwJTe/Tst03iMXK9uDGUaYROjLAki04kf+z9q0k1AxTFpaEru
9ldx7YyacvDrIOEfL60vTlUru20p9SIL5Epb04EF4WE1MytT0jc=
=QB9s
-----END PGP SIGNATURE-----

--kFP8zuAt3KbB04Hp--