Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVjL6-00039U-QQ for pgsql-committers@arkaria.postgresql.org; Wed, 29 Sep 2021 23:50:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mVjL5-0003Av-9u for pgsql-committers@arkaria.postgresql.org; Wed, 29 Sep 2021 23:50:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVjL3-0003AM-Vj for pgsql-committers@lists.postgresql.org; Wed, 29 Sep 2021 23:50:15 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVjL0-0007r7-EC for pgsql-committers@lists.postgresql.org; Wed, 29 Sep 2021 23:50:13 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 088E95C0172; Wed, 29 Sep 2021 19:50:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 29 Sep 2021 19:50:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=C3mXfKg5TYh4TCI6OysexU2QYE6 OM3fQBv7PUxqGgNw=; b=YH24Pzge0wnJXIsdEnB6YgSN8krK7aD/rqiTe35QrLL H+uD7Ao9oj3vy7e4rKk0LbAeUBlBN+HNElxkaRwWnO3OuqCXjxYRcRXv6n8cUzv3 HZJEuNXZYVbY7Ee0SFG/vEawgB2qFH9/zPfueTq2sqWyPQI3fjzY0zQ3eT5UzC7S 1wAi4/8D74xxXbB8p8Yj6hydvXxanZtOWx7k59pZet9uZf6pNRYQSk7a0BrzhgB2 08g+QMapdAULS3I5ac5CX+Vx4k1M9rJcZugVNdtswRtKYUis0/qM/KyvpvFMQdbg xmYSo2tG3NAbGgM7cCjpZOTQjH9JSco5xSThzVgECAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=C3mXfK g5TYh4TCI6OysexU2QYE6OM3fQBv7PUxqGgNw=; b=KEP5KLztuu7H3tty4vyQ/t bwdXmYgYBUm+FKCTRvJwkD8AdOERPBY5Ig0lKvTTLZs5TDTP4tGsmrtGpdSiygYp ntE24ucIGMnysAOs8+mGNtCRv/Th3jm9VQvAvzjY3biVrtH94zdL/RxBxIE2MUIs nb63uV9CPimoU0L788v81tJ1jZIM0G4K0gdxL2eVf/WtFhADkZKEZ/P0VyKZPv7Z 6g1jyylKLkPRcsMdiPG9Hmmh0v7uZsrTRdBuU8l5OLtd9hXVgZdWTPE6ImKzF8PC e4lP6AGiGhYcRjztTze8EfejkXujNIb/o0oW8o35tZCrJuRyen6Zy00AB3Fp5Xnw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekfedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeffudeffeelgffhkedukeekvedv udfgieetkeekudelfeevhffhffdtudffieeutdenucffohhmrghinhepphhoshhtghhrvg hsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 19:50:06 -0400 (EDT) Date: Thu, 30 Sep 2021 08:50:03 +0900 From: Michael Paquier To: Alvaro Herrera Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix WAL replay in presence of an incomplete record Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VLIfrQ94su3WWbiJ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --VLIfrQ94su3WWbiJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Alvaro, On Wed, Sep 29, 2021 at 02:40:29PM +0000, Alvaro Herrera wrote: > Fix WAL replay in presence of an incomplete record > [...] > src/test/recovery/t/026_overwrite_contrecord.pl | 207 ++++++++++++++++++++++++ > src/test/recovery/t/idiosyncratic_copy | 20 +++ The builfarm is saying that this test fails on Windows: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2021-09-29%2020%3A00%3A01 Sep 29 17:27:23 t/026_overwrite_contrecord..........FAILED--Further testing stopped: command "pg_basebackup -D... [...] pg_basebackup: error: connection to server at "127.0.0.1", port 55644 failed: FATAL: no pg_hba.conf entry for replication connection from host "127.0.0.1", user "pgrunner", no encryption +# Second test: a standby that receives WAL via archive/restore commands. +$node = PostgresNode->new('primary2'); +$node->init( + has_archiving => 1, + extra => ['--wal-segsize=1']); The error is here, where you need to set has_streaming => 1 to set up primary2 correctly on Windows (see 992d353). Thanks, -- Michael --VLIfrQ94su3WWbiJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFU+6sACgkQnvQgOdby QH08KA/6AjoBkgJjbGd12gsGSNpLDTWrTTZ9AmRxXTwryk1OrgE4Nr4hlkI7b9dP 3YsFawbOKriSyvd5I9bNGUlawGI6MFbGf3OzkRTY19v5Ocvsr1ZW81X6AECNFAFJ eX618xwNzgYqynSe6iE1ZiHypzdzgSgXjsUAtRztO1LxXdQViPDxsM+uHw/ws529 iHbz0zmpvwSBv42WzFDBJJSDPIUsiAatvdowoPn72SOVaw/kHIiqMojwVLxQNsIr hzEk3PijvSJF5xorv38fLQvgOD17hXP76655DwZrLt882vW0VO8AIPZPXA9aeGmU vU/+18bLvadHsMex42zbLLopcqzFl36gq63qNxnRYqs12OhoygOWxYZJrzHbPHtn 7vAKFxuLxZKeBEFtbSIvzn4SEsyOX5fmV3Sd7LA4zicEGlJUYTpq4P5HT/BpdIUY KgFLIBOZc1rwBmzDCeWq4NYTm9Imo5FCvWcgkNgWbRKgzUSgUtJafjR1FxMHLQKE spst63EWa4qfYiboz6UK6abrx7XKHHqpoyk4T9yH8BzoCg91Wj0fCU/8yP7nl68e 8b+ncGOJOlkaMiWVW4TPdHVKwW9Od6FGsKbNPuw58HqV1qrpcx6zgb2GSliNVjVA /DuF+T31yjtnxlcC3QssZUHfC3W0mtsYhGY55r0nyZsRxZiAm9E= =3sed -----END PGP SIGNATURE----- --VLIfrQ94su3WWbiJ--