Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1marmA-000397-UU for pgsql-committers@arkaria.postgresql.org; Thu, 14 Oct 2021 03:51:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1marm9-0000nk-P1 for pgsql-committers@arkaria.postgresql.org; Thu, 14 Oct 2021 03:51:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1marm8-0000nb-Fw for pgsql-committers@lists.postgresql.org; Thu, 14 Oct 2021 03:51:25 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1marm3-0007Hx-BQ for pgsql-committers@lists.postgresql.org; Thu, 14 Oct 2021 03:51:23 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B242E3200B7A; Wed, 13 Oct 2021 23:51:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 Oct 2021 23:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=03wgUWjpSV4yQ3ustYijvitcuXC HsEw8F5ziENrn4So=; b=YhxCjew0vYo5IZFE5SfkkisHr5HgPHDZmmbMZkSG/sC 7XhDVaAj2q+OCbAup5FyHL7QIpJofGD0wpyv1vq50qkbyh3JZhF179KwyTWKApuN oLJzpYUU1SM8OwydeyAHwG7PKEIUWq54FQ198ewYFiFElbSBSiTZKEyLHozsOk7S sxWNK1HiMOAk7zVMVnGRV/AxKRlqcXCjDfj4eMeDrw4lLepVnq1Q7ZqJpuDnLZeO TSd2WIKK/GEYB3jq00e7O/fgVcRP0srJTeuxb8zeKNy/GBIzSN2aAMgkf5z+nQI+ Su1CC7wMUuI2oMP2V8uk+Cui/nWWVLG3kFayMkyqEpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=03wgUW jpSV4yQ3ustYijvitcuXCHsEw8F5ziENrn4So=; b=asWelctViKZEvqBHueqQ48 bE3ggW5lxXFtFcwsMXowrxcZt8kUHg2KLspwR/pzk3lxPP6Ou/k93/KUBkZHFoAb 0/IjcOLjKw5I8qh8lWZLuuirgljlUarQrZaYIcxmS7IkJwPPfp7Um9TXPnKaZ1cl /qtdISKI0d8QQ7EJhLNAr0N9p9rhLsJzUiokjza4qYe6YV6LDRxQK8kJ57i2xedk b3o3SPqpMeGHLYZ9lR+cNYLVHjE+0g8/9Un1Q4yfYKrLM64nu0ZymsuGmqc0zIYQ mLTeRxjkCUQOOqUa63BagyD5Y5ROrooGnwKb01qt3RLyMdKHfKYDSyKME3D0moFg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdduuddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 23:51:15 -0400 (EDT) Date: Thu, 14 Oct 2021 12:51:11 +0900 From: Michael Paquier To: Peter Geoghegan Cc: pgsql-committers , Peter Eisentraut Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OYDvIaR6s+Su/wwW" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --OYDvIaR6s+Su/wwW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 13, 2021 at 08:14:20PM -0700, Peter Geoghegan wrote: > On Mon, Oct 11, 2021 at 7:17 PM Michael Paquier wro= te: > > Add more $Test::Builder::Level in the TAP tests >=20 > I saw an issue just now that I suspect is linked with this commit. I > ran my parallel "make check-world" recipe, and saw this failure: This commit has not touched 001_basic.pl, nor does it touch any of the modules we have in src/test/perl/, so that's unrelated. In the worst case, what you would get after this commit is a better report by incrementing the level stack. The problem is that this test script assumes that it is fine to not use -X/--no-psqlrc in the commands of psql run, making this test prone to fail depending on the local setup. Please note that we pass down -X through PostgresNode::psql, to keep the tests isolated from the external world, so this could be fixed either by using -X but I think that it would be better to switch to psql() with a comparison done to the outputs of stdout, stderr and the error code returned. The failure can be reproduced easily once one adds some junk in their local psqlrc. Adding Peter E in CC, as the author of c0280bc & co. > # Failed test 'handling of unexpected PQresultStatus: matches' > # at t/001_basic.pl line 43. > # 'psql:/home/pg/.psqlrc:56: ERROR: syntax error > # psql:/home/pg/.psqlrc:57: ERROR: syntax error > # LOG: received replication command: START_REPLICATION 0/0 > # unexpected PQresultStatus: 8 > # ' You may also want to fix your local .psqlrc, while on it. -- Michael --OYDvIaR6s+Su/wwW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFnqS8ACgkQnvQgOdby QH3qFQ//b8j9nG0lfKs8GNpKXnU+ql+0P++wtrxIC3NQvjyVyo40EKxJxZTCnDfB 6Txc2S1mEoeAVrSA3tiSFx+Z9FK+kdDEx78Y8OHhtiJ3ePNj0JLDqi1Lxsw2IrOs /zZKbXqvSOK+nAU4VQhcbl5r8XnOLM8/wHuKY90OJ7jcoLfWM06Rc9Nlv1wrGQxU VSZ8pW2UMYUE6FGAz/vy9bmJY3K6AB1TnLmN4WQQJZ+CZ0l8CIBSuPyLm0sixwO4 adsq0phDR3tWVy4SlhjdpVUOgbglXxMJVeEqh1zqbvkjdy0z1Hbx8x7OrKUsHk+K H29yvHJ92dD+90mk6zhgnGzPBcXpQc2TfaNQ/XgimHKnfR/+Xu0tUCf+e1tHOEa8 1VSl3P7lMV6xI6HeIf52NJWnPmGMtWnRNljbIWArasMemw6sDN5P7Vs3ieyW1Zbs SElGNLeD7S29tRKxLEfvPqoNvndE3Na8fmoHJQZdSXRVnR5dVCLlkFxXMN/Hghnx x5dppT93ziFVwyajwjD4H5kTOEgdyjqmO2BafJCbNic1jbLpxLXTS0dM2FqT+uYl yCyV3zIR47eUjg2vKE59N+fXIOC2ODultymJ8VW2jfz8Yvr+QZhaqSlO/3Pf0Isp C1G1ioHb/SDfM+P9hHZRFe5dx5+XlPbtLs3jA/EFXVotECtafhE= =gNNl -----END PGP SIGNATURE----- --OYDvIaR6s+Su/wwW--