Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1marv5-0003UD-Tz for pgsql-committers@arkaria.postgresql.org; Thu, 14 Oct 2021 04:00:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1marv4-0003qT-Cm for pgsql-committers@arkaria.postgresql.org; Thu, 14 Oct 2021 04:00:38 +0000 Received: from makus.postgresql.org ([72.32.157.229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1marv4-0003n9-6L for pgsql-committers@lists.postgresql.org; Thu, 14 Oct 2021 04:00:38 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1marv2-0007Mp-6A for pgsql-committers@lists.postgresql.org; Thu, 14 Oct 2021 04:00:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id ECDE83201C32; Thu, 14 Oct 2021 00:00:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 14 Oct 2021 00:00:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+yo5PPle9D4Ozmj65nrt4LDJ7fJ PeYdMnWk2FSKg2JA=; b=ZFLNT5I/cTaE6mXZNd+Alb1g9nK+U4wISz/6EC2hxg1 r1eGP0VmWa1hesZXJwNZgQD29fLaeINvMz9MIXKLFZpDnHBAlXm0r55LMCUsNbDc ocCZMlCFRvuu2OBRr0b+jC6xsn5ppNvSUKKPPmuzyBezNAeMnUEcKbZV4YMQqaw6 FVmZrnXqDd22ltkgKI7ldFndMVxuqdzxUdSXI9QmHsG5GYbCMI9FlEhGXzinKWzR GYWkIKkUe41HYdneaSbOrndNGZCPRbCM4seMqLgHS1ctgY13c/yfjAbE5pgxg2N6 zDP3RreOdymsGcRAp15lrSIZ6RRZzpe8iYhqSk4cpZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+yo5PP le9D4Ozmj65nrt4LDJ7fJPeYdMnWk2FSKg2JA=; b=jdCkGjL19XCbuCpFqeiZmO AfYXE1fl75DVloupMT5PhJEra2Gc4QZWBrhz/th+NMi0ncfPmnhcDnRi3bmCjy0Q NcNIp2RT0Az0qkhm3ck+CO9QQjCAwCjYZ09GI9kkUXGX3yDXqmJqRxKU1jAf/p8x dEuF9Q93bUYMVkAQDawBgedVcRIfO+FebJu4xtL2YDYT8HMYLCDZbAYmzkFqbUvg ch2y3rjD1U2LwrlFsRTRmT1gg1HHQom08ghWJONd3qAjK5Ag8XNRViRlyZJslTwK nzy3E7hiydHvGccDt6Mz7DZKM96VXGfqkRJfnRV9AWgIpZYak47Setu+G4ONkhzA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdduuddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Oct 2021 00:00:33 -0400 (EDT) Date: Thu, 14 Oct 2021 13:00:30 +0900 From: Michael Paquier To: Peter Geoghegan Cc: pgsql-committers , Peter Eisentraut Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dLkJdrZoAA5kQ9nR" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --dLkJdrZoAA5kQ9nR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 13, 2021 at 08:54:16PM -0700, Peter Geoghegan wrote: > On Wed, Oct 13, 2021 at 8:51 PM Michael Paquier wro= te: >>> # Failed test 'handling of unexpected PQresultStatus: matches' >>> # at t/001_basic.pl line 43. >>> # 'psql:/home/pg/.psqlrc:56: ERROR: syntax error >>> # psql:/home/pg/.psqlrc:57: ERROR: syntax error >>> # LOG: received replication command: START_REPLICATION 0/0 >>> # unexpected PQresultStatus: 8 >>> # ' >> >> You may also want to fix your local .psqlrc, while on it. >=20 > Why, though? It doesn't do this in any other context. Even for single psql commands in your environment? That would be surprising that this does not show the same error about lines 56/57 in /home/pg/.psqlrc, but I guess that's up to you for this part.. It does not change the fact that the test needs to be fixed. TAP tests should be designed to not be influenced by the external world. -- Michael --dLkJdrZoAA5kQ9nR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFnq14ACgkQnvQgOdby QH2O1xAAk652kG6+8tsPTjY9ejtu+NAFeIUVCS/hP/z+3XFzIn1s709GXLRnIaxL Js8gi33XpBMveo79woWNGTos8j0ftaUHSx6bQ2f3k01vVbCISlZ/Edok0yz/dxwX V34kBQvDitwhUwa8yZ7ucAt/dLyVoIBisXt1Joirw4AGhHpzLpMNl2ThPZfDkbDw rRMtxL2bJHsFadqEeyNzJdeDINLscOR0A0pGOmaG6TXpmiz5hTHaCx/C74RAOWjR T+oKfN9W4lTVvt8aOlb6ncNz3DGUt7/ZPUjl8PU7MkPtK5LqDDmAZ2zc+WEen1hr mOW8IDzPennaGFf3dBWn765EzSB3x9FKV/6/Cnq8LFYzTzbYR7Wx1YMvLl9f7erT ky5kh9Aqg9BFczATmPj/LH7vhP1uuWwvCTODrgwegSYyOI97TrawLCNiOIN7XTQz kJcPy3kqutvztHyGywVoYVIZhmRbYQT5vWdp60h3pN5BhR9PqfGy3b2lL5Np0i/X /K32I0iqJ9zwCNFHF6Ms3kokrWN7hWYRaTvcgiPdC6BTSU2kPdIq9oKANMDyIaxk O40FryYeg9aQzEK83YqYwjBvcpRYhVb4ZvpHC46czHQQPIPXxAPfKSLHz109oD6a erznVCfu5YhpSGdJq4YH7E3yI9yY6JeMXgrm3kUuV/OAohsGiSY= =pcL1 -----END PGP SIGNATURE----- --dLkJdrZoAA5kQ9nR--