Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfaM0-0003tr-LW for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 04:15:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfaLz-0001CA-FK for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 04:15:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfaLz-0001C1-8U for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 04:15:55 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfaLw-0006dz-UW for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 04:15:54 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A927D3201591; Wed, 27 Oct 2021 00:15:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 27 Oct 2021 00:15:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=IJ1ZjfW3dWBUCguWgMIebbs8S+f +svdL02iHt9BCrIQ=; b=MWaCJAgCZpmgTqGxv8weVBTFJbv3pXllv7TIuyOYxAd bwrFUv0F1IvzkqcuGplerS3gPWQiDW2cHq/5WNLwbnIdVUSeAw8Aw8QH5qWlXUj4 fMlRgoi7qNb9DWe5go3cobvnVXY6xrHbVnH5MyoYAPQVJKw8FWPoXGwJOX/tnxF6 FRMDXIqIc2MgLXm+688cqqKRvFpAo2gxZSXWOgoXEHAK2s/+2IuUhMEtq5+Qz7WI Y7nqLt0S3R8/vMiHa1uzGw1424DoJiF3AEY2XpOd1Ak/OxG9rHQB3dDm/aJGOpVw kLjf4VyS5C+ZdyXQpmNW2kQ23RpasJ7oKj5C1k+2Kog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=IJ1Zjf W3dWBUCguWgMIebbs8S+f+svdL02iHt9BCrIQ=; b=Hy+Lkm1Tdon71oVGtdK3jd lfOex62mc9emPWWJHST6QpgqU5Kyql771scnluBWSRsgrmZ3V7Dbksf7z8LKGZ2f 7lUeFHOauF7CGJUBoZdAvWZI12F1mX6nZyvIzH4JASk2vj2IfVVxQSYgutFhmpOY /eHGETZ4vpW80x4VsSXuz8luabiEv0WPnpEir5ZyVb8LXCDk/868uuSEiHYoNh0N I0eGss+k7Y2sxGo5OLPcD8CCh3jmeJW7D1HzgYLUkz48glgIQZaxgYYaPUF0RZiy hIxtrDV39dB5v/7e02Z5+AZFR3M32K3VBI4y9hTwlfeE9jGVxVXJf6jD06EUfQbw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefledgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 00:15:48 -0400 (EDT) Date: Wed, 27 Oct 2021 13:15:46 +0900 From: Michael Paquier To: Jeff Davis Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+xP3MEDBghBh+yO4" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --+xP3MEDBghBh+yO4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 26, 2021 at 08:41:11PM +0000, Jeff Davis wrote: > Allow GRANT on pg_log_backend_memory_contexts(). >=20 > Remove superuser check, allowing any user granted permissions on > pg_log_backend_memory_contexts() to log the memory contexts of any > backend. >=20 > Note that this could allow a privileged non-superuser to log the > memory contexts of a superuser backend, but as discussed, that does > not seem to be a problem. but will not be sent to the client regardless of . - Only superusers can request to log the memory contexts. I don't think that the documentation part of this commit is correct. This sentence should have been changed to something like the following: "This function is restricted to superusers by default, but other users can be granted EXECUTE to run the function." Thanks, -- Michael --+xP3MEDBghBh+yO4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmF40nIACgkQnvQgOdby QH0u/RAAhr8IcnIMGVZHmPpkrT1m/uy7E5l3Cxl2yk6ogx1rkc5127oraj54Xqap ha44wUNQv/aBA0ihXpWPzjKhSYnT7OOXbcbg9wlbTttl2qMgI9KQ5KFov0brMe4B Ic/jLrvQEPTWdZKJYTWvl2c9UNmBTKSMzqDVp9V2bFgjzEZBH33hs/qM9oMwgi04 pPg4x2p58qYiU2XrCcyEsDbM7TDdTlxMVPivPFEB5M+OGFcRS+sP/bhsdkxJi/m9 5+KYH7gv9eM7k0b8Jh7osqubYR11ZLDh4rdtYEw/frL1VD4Pr4gMuVJn5ACCoe8c Vnng5pY0ZnXjUBctWkZq1ZtBTOh9KifAz6AjGbHgtVc7gG3vdQ34IvCJPIO9BjWM ApYoRnVqTXduhse4bkamkwUU69lvW7FhPWTDGXzA7j5kDhoHZYa/YBO666qd3ecT MQn+iHYZnZ/d623oK6DQn3vRy8HjR6pB/9NjTLqRDZdmCAdNBAFcQbW+CGO9poN+ nxlY064/6SiDP54qSdQV9ExNqqL6C9LGwLeT0B8tFmG/9XKZ4YoWv0+JU1i8JUbU uvKrX0h611Tz8AqCVlxWJgtWqSbParP1Y3OKpt2HrgvGGOnImkdcp5FiE46+j32j fE2QpbHBEB69aL/zGBPcrxx5wuAUK3+SL3OqsX5HXwmWmtl1GV8= =AEj0 -----END PGP SIGNATURE----- --+xP3MEDBghBh+yO4--