Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfb66-0005z3-6H for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 05:03:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfb65-0007lv-18 for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 05:03:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfb64-0007lj-O0 for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 05:03:32 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfb62-00070g-F7 for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 05:03:32 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 5F31B3200C20; Wed, 27 Oct 2021 01:03:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 27 Oct 2021 01:03:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=BxwCK6Bs1dfMoemZtFHcM0a4QiC A4kAkr4GVy2UMPVs=; b=cprzyqXovpV+VYH5nyZbmijRWHplW12e0IPtTeYUAll Ct96Xiud5+HDi6MclV+HgFeP4WuBj6/EfOTrsFDVKK/Ubg/8AHPiKxJDQZ3vpxEl FypC0885MUcizN4pxc/2O/aogpcIU7MLAB90hr3De4eKVISFhMYHX39hsVct0JXw WCnpHcubo7HNvGhDGICS/83bzkYjPRAvVXsD/s/k3hoDXBOQ1YK1z3sRzhdIU8ou p2uMC+IjywWigvCmABMsYaTrplncLHYZgi0Xl5ElxpFG3M7LD7ZI6rq70n8x5QUI yNSoe/MBVeDHyqIs5nnLLl1iJguW8wgdw9IWVCj4Qsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=BxwCK6 Bs1dfMoemZtFHcM0a4QiCA4kAkr4GVy2UMPVs=; b=AjIvNNR54zuC+MGslM1qKD fUd6A+Ax9NKHoeu1Le/Dxl6CCbNJQCBqh3stm9h3+qzSQ+tX74zWvaLe7qIsd8oC 9QV9G8hrL43YB1APPwthdcY2ukOyPrLHAqyZqWUd+s80YmoY23/EPP6hCUOVqac8 whFsrQzpASmqGOgXkxv1wY8n+0T8wyNwmmGHtyrpNeVCfHOj9wEU5Uewx2ZNyyUe atMOXuu2ZBNLlprC1RH1GiTbMYttvERdUxOQjmW9bB6JssMGDxir5E0UE2r+lOvw mnLeVv3smT24TsBTNf//z39jz5a8brXkaQZfE8SUmF2oCF3eSqcyB5OqlNj/epcw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefledgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 01:03:26 -0400 (EDT) Date: Wed, 27 Oct 2021 14:03:22 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: Jeff Davis , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HKpQhZQBWamNuRMD" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --HKpQhZQBWamNuRMD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 27, 2021 at 10:27:18AM +0530, Bharath Rupireddy wrote: > +1 and the above statement looks good. Apart from that I have one more > suggestion that I earlier made: have the function produce the error > when no permissions were granted (just to ensure we have the error > message covered) including has_function_privilege() case. has_function_privilege() makes sure of the same thing, so I think that what Jeff has done for this part is just but fine. There is no need for more duplication in the tests. -- Michael --HKpQhZQBWamNuRMD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmF43ZoACgkQnvQgOdby QH2q+Q/+OG6bLi31nJT9+qrCWyt7IJFLLZpgA2OMaoVZp8Io24AvpYJbz5HPTHxB QJIjC+hhl6plCKygDUMQmbyxKrLANjLO/XDsSDid4SP0ZmNCuy673gu1fC5sAw54 b+gvQxaF6FnT6Ldi8RZliZBN2l+b4N9OXTNgxWSkZiW5+zogxVdHnTJ1kgDecMIo 3PzpP32av0kitkGt3sL7koLlg92yyQUyGihJJNHcp3WEYAGeN/ptzI6PUiAl09eh K0NhYzajrrc1NE2GskFmSRULSsTC5lBM+1a7YwygVHXI4+l8TxGw5t2ulwWl6Q2E dGdxdwLF2ShhTdloTu/rosFNdme0d/rBFBHgexuj9s716QUIFk69aY43xP7datKk fLB0dccqp5Ugul8ndazm2v4PVc5sN50Nat1KR3BUVTXaPyjvp5TMxSSnZm1vApaQ zd+k2CNpHptk2B5Ub47MhCcp4pwI9i9+6Hz3DFzuCWK/GAmTXFbGgnwgpkBYCpSB Jcf1B93e4l/doAUETxHtbZotoXltHoP/dtZomcIRYUqZnC4rPHSd8GuY6NB/qe4E fxnDUceMALzsrbYdgU9AxvhkaxsKTNsoERTFxtle1eHOHH1/9cUpJ+ZLsB+KYaGi v5XakUvycEi8JltlPmwKlGyz1Li0diMxi3h+duaVFsEhZrhYLOc= =GLWn -----END PGP SIGNATURE----- --HKpQhZQBWamNuRMD--