Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mit1i-0002EF-6k for pgsql-committers@arkaria.postgresql.org; Fri, 05 Nov 2021 06:48:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mit1h-0008Cr-4p for pgsql-committers@arkaria.postgresql.org; Fri, 05 Nov 2021 06:48:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mit1g-0008Ci-Uo for pgsql-committers@lists.postgresql.org; Fri, 05 Nov 2021 06:48:36 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mit1e-0005D3-MC for pgsql-committers@lists.postgresql.org; Fri, 05 Nov 2021 06:48:36 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 67DC83201CBE; Fri, 5 Nov 2021 02:48:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 05 Nov 2021 02:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=3l20RjGOw9EdKh5czRi0AF17DQ+ AYPXjRID5xnxFDhQ=; b=Q6G2aMuHda0pw4xD1YBA/4J2M81tAttPBxMGFqUmfxN v/Dt0SVwTXmp7alZyQwuhsHABUFBZUG0FPkoHPYe6pVxlDAwqvFl44y8ACM7ytZ1 42wmPjnF/TDf932C6kW7lA/11X1WxiAq1WOSGgoZRAoYt/5DYBx+lmBxMlrD1+gR sRYpQz7+GTqJqM0Q6CwhBWIVTfZNuPT9lcDbBL37n01ir6MKT8y4Yf+fjC6Gg23F m5HU7my7Q6P8kuHQpEue6TQ2kHxfJy2dfVvIihpczr1jRZWXYntdYVdbI7/xUPeB +VLlfZ42MTE87m1P7WgizqKIxW+bVVgzIU8ioDI6OyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3l20Rj GOw9EdKh5czRi0AF17DQ+AYPXjRID5xnxFDhQ=; b=YTJ4IzBwjaLu5gQoUL7fRw R6i8QXNGOL3H4IF6kCZzGcSBRr1fq5N2boLB+xBfGFwImdTXPrllZNYmJ3shQri5 0SyuCTqHJWgyDqS3THTLg50GzT48ByUY3aXeI0nUXYDeU9iG300yKoBkwpnZaut4 hKOh1rnJtaIqCsuXqQARpH/9FORQWwVX8snlQ70mp5gPnWk7HkHGcF9bG4P8OLsW c6D0+B1R7KHK/WZz/QFrJz1JwsMdKUelDwhq5V04McLc8ely6kAQvJZj4o/RfPAS +xyqgOQ2miVNc80KVJsT8HM3Za2V38ys3zQ1zUIXUqkPxzINSKb63nKr30nxbGxA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdehgdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtdorredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepheegtdeuheekteegueevtdelleek geegfeetfeejjefgkeehieekveejhedujeehnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 Nov 2021 02:48:29 -0400 (EDT) Date: Fri, 5 Nov 2021 15:48:25 +0900 From: Michael Paquier To: Peter Geoghegan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add various assertions to heap pruning code. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TYaG00rTIzHkfk4C" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --TYaG00rTIzHkfk4C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Peter, On Fri, Nov 05, 2021 at 02:09:47AM +0000, Peter Geoghegan wrote: > Add various assertions to heap pruning code. >=20 > These assertions document (and verify) our high level assumptions about > how pruning can and cannot affect existing items from target heap pages. > For example, one of the new assertions verifies that pruning does not > set a heap-only tuple to LP_DEAD. This generates some warnings on Windows without asserts: pruneheap.c(847): warning C4101: 'htup' unreferenced local variable pruneheap.c(859): warning C4101: 'tolp' unreferenced local variable You could move those two variables within their USE_ASSERT_CHECKING blocks, for example. Thanks, -- Michael --TYaG00rTIzHkfk4C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGE07kACgkQnvQgOdby QH2vJA//ZaP+opjDonPdMHGXXZkUGYOgMcjKPaGpGgWUTjMTJc41ffGbbDPHBerx YNgMR14X9YhqcLYGnwL+z/5t/aDLFASPRTBIN4efDbVpe1qK1xxXGJOtDrPx0CV1 sKAGjfSM3G9x+T2g/Swi4DFgxYqhZetnE8gEV5eOYG+w8t374FKOoyNeyf35PYKa X4YcEyo5C+op+GX+xQ0CkKheoTKZ6dcTQ/LeW8uYGB6XzcG7t8+k5x/Ji4sdoXpW r4haw2C8FaK/3atwd9tOWxT5qqJ0koaAGtfsBnVUJofn4Kzm2Ij51vanf7LderyO VIvUbBENylMaTegyemNJ46DvVq/ZhXY/340K7cZ1tYM6D1KMzLOdQm93NzexV4dP yivA3cxE+tcm8hoCRihWo7FVCPWQNMpfBZHZYcnVDwbUkGqriyyY6x9zonR7MBx7 6A+4P4x34fMDCHqpAzRa4mGTys5sIO1UgmM3iZqWWK6gNFbZ2ukegt4IQ1A6C0or BklikX53VW24vH4XthITZVe6U9uogBKgleeWrME9cb0fAMfTV4NGn4OvDoVBkBHi NHNLhE7SkWv8URF+jEeJVC4ZGSMV/JiWdLdyJs2jSLCsI4ojoiFmb9Ijr7TtZoX0 JPOMx+8ibnRuH2SJrDKY4B2iStXTmuznZ2Z1BT6IJDljfW1Iy8k= =7W3O -----END PGP SIGNATURE----- --TYaG00rTIzHkfk4C--