Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj9P3-0001o6-PQ for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 00:17:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mj9P2-0000A5-Ez for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 00:17:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj9P0-00009w-P5 for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 00:17:48 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj9Ox-0003ex-6b for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 00:17:45 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 31ED95C019A; Fri, 5 Nov 2021 20:17:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 05 Nov 2021 20:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=To4GqeqLVwhXeI6W/YhMoNROwP7 C/K/aOHg+VdwIMO8=; b=ESonAu9srDBnCXG8Xvp+NTDuu7TyV/3Nk2swlsio3Yd dXEOGVzFgUw5qWsacOoUEcuaiyv8sL4R2ztVSujxyWjYmyKnNvdFq3x0ZRGpQDQ/ ZWRT2+61/3oowWu3DfxHpTk/pyatWkRs5Hkv+BJaTs70CoJi3x0oZQvxYy6q+/Xf IMKjzkmgMkP/8aCennHsVifrNh6pVmgfeLfnRu/aVMoPU7LhUJ3apvYxFV3sXtNr /rb9e3xH0vC5ZmyqKybsN5ev2QoKTHiWJeIqy4L1dKsNymcEggJyGNJK6+SQc3aF YxOOmS6m6rCfIbx8OCp+doFNRCcLDzMmOodS/GI4MPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=To4Gqe qLVwhXeI6W/YhMoNROwP7C/K/aOHg+VdwIMO8=; b=S2f29GSuhtwB4gkozb2Ob1 fv3EodDdlG1OnFD1cjd7vY2gj/YZFJYCR25ZK5Ji7zt0cGEKze58BBAm2QzTXAfx z1epXiZitfIKq/9nEIiqSN1l0GGSiyFqYKyMKBzK33hK4ibiaqWFwZj8Zi+aLC5i PC0EFmN0oz91/0bmoi0HZkP3+oQkkIMGVvvRRUfpfUmky8FFvoLErgS0W4FvcbL2 sP4YFPruk/6Ywbr+sUTCFQ8WGj9a0yaVUdneofLcYUhwN89DT7BGv7vclSL3z2zH rNN24lwevcQw7g1ILTV3eRKamwMNgEpsCufj05Y1APTbVRARhgZ4gx6/BhI/k68w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdejgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepffdufeeflefghfekudekkeevvddu gfeiteekkeduleefvefhhffftdduffeiuedtnecuffhomhgrihhnpehpohhsthhgrhgvsh hqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 Nov 2021 20:17:39 -0400 (EDT) Date: Sat, 6 Nov 2021 09:17:33 +0900 From: Michael Paquier To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Change ThisTimeLineID from a global variable to a local variable Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JHD7BtErKms4y5MU" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --JHD7BtErKms4y5MU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robert, On Fri, Nov 05, 2021 at 04:55:52PM +0000, Robert Haas wrote: > Change ThisTimeLineID from a global variable to a local variable. >=20 > StartupXLOG() still has ThisTimeLineID as a local variable, but the > remaining code in xlog.c now needs to the relevant TimeLineID by some > other means. Mostly, this means that we now pass it as a function > parameter to a bunch of functions where we didn't previously. > However, a few cases require special handling: lapwing looks unhappy after this commit: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dlapwing&dt=3D2021= -11-05%2022%3A40%3A10 xlog.c: In function 'StartupXLOG': xlog.c:7249:5: error: 'checkPointLoc' may be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] xlog.c:6686:5: note: 'checkPointLoc' was declared here Thanks, -- Michael --JHD7BtErKms4y5MU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGFyZ0ACgkQnvQgOdby QH3jXg/+PfRt3rHkv9BeuBRoIsxdgpff3pdWzv3gqyb64HKXGF6YwkFmT88Z83Y0 lskr8jkZeWBtz8HvjOXwUeEU2bCA45ytkGMg8KGWw5fa5Wmrcxs/OhEzv93Nd3ob g/lXAq6/zNJ+etDOi2OwUyEaVoF+6mfJDyeTXocuSIU/z9W8Ui5bj2rq3lplkzbq KnjfYYUnTdWfQgxTZGwpFIzOVR0DFSetrd/nNM+XkYBsgD5vKaE9jZ0Iy/z+lHoF 3eH30dgbHKbdU/V8HzGzcK09FTOCB52Q8aiVSk5loYY9blg7cVLMKIgSLhgAheEv ZLSETjpaMpljJhxUu89nBQikyqDNR2GtwshQpCtPU8KEaPk1W7o9OfdStCqQHIXh eC8l9gAjDOCRKmAf+xVApuw9qBi6fdiuzrNbUs04U+qdZHCGrDMa+UlHIqJDScuu bPwLPaAmgHpb6A3IGE0akNvOzIcPnyDTln7GDJczzfKbFPSh6P3Py8Y5VEBGQEff IkvTRD3xHheMMsGTpJB/88SWSHxEoN1bw6ZfR82lHJMO8ZgFB4swD9wL23+wkxi6 9X/dGmAZ+89dcWdRAZUwJ98jC0Ei5eCLSRx9wKjZ98/+WioDo05/vTlQRsyqyy3+ XVau+AJktY+IDsROnDMif5jpsJtT7x/iMmpe7p8r2Seh9lwy6Q8= =3d5K -----END PGP SIGNATURE----- --JHD7BtErKms4y5MU--