Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msfyI-00065G-K3 for pgsql-committers@arkaria.postgresql.org; Thu, 02 Dec 2021 06:53:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1msfyH-0004we-CK for pgsql-committers@arkaria.postgresql.org; Thu, 02 Dec 2021 06:53:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msfyF-0004wT-FI for pgsql-committers@lists.postgresql.org; Thu, 02 Dec 2021 06:53:33 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msfy7-0001jl-Uw for pgsql-committers@lists.postgresql.org; Thu, 02 Dec 2021 06:53:30 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CA4265C00DD; Thu, 2 Dec 2021 01:53:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 02 Dec 2021 01:53:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=wdldLuAnkMtu2VUkOmGFFZE0IBa g+RgtfRbZCTtGuJw=; b=cSbFnm9cGViRIehaPqfaEttTgKE1jzcSPQNbfN32W+h DRX21MbEdn87bBQLkmrhfk8HHFsBLSwZKOAvUaWD5Cnuzud2Vi2ZGuSGRjM+KvPv W/F5aLUTR8Va8PJMBT9UDe7bUTdZfdqhq8+ghZJw9/UHl+lUhq7WEq3XUSIK6kuM D7L/EQBL7kTFWUOI/JQO0/ld3jEHYDxB2MN8oxjUISkzNg8wpiDxaz4peedkBwkV oDjkKV69Eo+kur091IHk9Xcy3Dt1NpobHFl3lRBVpGoRwL6VclvgWSRKlOFaGIgo teiTuzyfmrYg8JsQXyqgOjogHVF3AYBbTOtbD/FxxmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wdldLu AnkMtu2VUkOmGFFZE0IBag+RgtfRbZCTtGuJw=; b=X41heBPmJ95T3MwB4ROucP ddS8uZteZwEiv/ZDdTvYvy5xCfpxtyOWM8sXY4GEXYuMEgcrZfy3LxChJ6p+Mny+ rst4ikrk8DnSLhHFqLCU7XG+sDMVkZ8PRwSVqXZxiofiXwXk7WAVucKZ73kzxY08 6hOxRC2D3K99LEvaPL8R0assLcn0a7MuiBHblk9Ks5C8FqPL7wKQnHObeMLT1Koq VuTEN/2ZKT+iWKaW6KNbeAgwSQ7Yib2rDkufjE+ef1e5l0Jy7BNTnMTO72rczXcF B86YW5ajTHuKNadoxjumYy3hEa5A8IMCxRTCDaFCnZKk+KTB3aruHcYdqgfJrnmw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieeggddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdlfeehmdenucfjughrpeffhf fvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhu ihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrh hnpeffudeffeelgffhkedukeekvedvudfgieetkeekudelfeevhffhffdtudffieeutden ucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdr giihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Dec 2021 01:53:21 -0500 (EST) Date: Thu, 2 Dec 2021 15:53:17 +0900 From: Michael Paquier To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: psql: initialize comment-begin setting to a useful value by defa Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Iv3eY7fW7aI3ttus" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Iv3eY7fW7aI3ttus Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Tom, On Wed, Dec 01, 2021 at 05:24:58PM +0000, Tom Lane wrote: > psql: initialize comment-begin setting to a useful value by default. >=20 > Readline's meta-# command is supposed to insert a comment marker > at the start of the current line. However, the default marker is > "#" which is entirely unhelpful for SQL. Set it to "-- " instead. > (This setting can still be overridden in one's ~/.inputrc file, > so this change won't affect people who have already taken steps > to make the command useful.) prairiedog is unhappy after this commit due to the use of rl_variable_bind(): https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dprairiedog&dt=3D2= 021-12-02%2005%3A29%3A32 /usr/bin/ld: Undefined symbols: _rl_variable_bind collect2: ld returned 1 exit status Thanks, -- Michael --Iv3eY7fW7aI3ttus Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGobV0ACgkQnvQgOdby QH1DuRAAhbZBKkpzB9uP+9BetNUwgdz+u9aNwcF2xN1e7kxwzWD3ujBuweUVvuaN TQ0bhf+xUKKyBhpsikS36XYFA5UawPprORErAps7iy2Jg4hQicEFNM2GCmrMJS45 0/Gdab0IU9PXR2PCZLcxLrXEdU0x+Ucg0dz/0v6fazEZkld0gdmm6hnl27XBp6bN QYgcU/esC8qGUxp1lHOCV3k/xRfoltqSkdCOwTIz/Czzbd4NzI0RmiGJCSXTxHrQ 3eH+y2rjaa7olILcv9XQ1esCisQFjUHGChLLLohsc0Zzwg1X+rRlKx63c/voyjSF nU9n0/JCsmhvOzQPTz9VMCcWFiNxZvzRLVZS1wiuqWDqesGRIrtxlPfybIw6lnSz HBO6fwjEmjEIvwj/C2V8MyF9FVcOX2lCuuwrsPsromNZb8tM1tYZSBMcMGWFZ1KX M3Lh8U1mlPO9y4xcSauQdM35JI3ZNyFonhVVgQ1b8C0la3Aa+Pq/2osbzPwjiV8M IAZboGYWBR+Ia1ccn5/yuw+GFjseCPgp8txQ4qTipuHPefo4VHLjObb5ZEmEJiho oURBslyaXW9JEqtZbMeyp32qGAGSW1AJiMKGM/AWRIGqVNPavevrr6YB+0Z1+3Kt 3fsFyLhb5NBwE5D3VF1w2cdXDEBkdD6nwPB6K2rmNUDMneSYDsk= =VIRW -----END PGP SIGNATURE----- --Iv3eY7fW7aI3ttus--