Date: Thu, 9 Dec 2021 14:47:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Message-ID: <YbGYe483803il3X7@paquier.xyz>
References: <3655283.1638977975@sss.pgh.pa.us>
 <2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
 <3657697.1638980149@sss.pgh.pa.us>
 <b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
 <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/zVsbBhqFh4/hVC2"
Content-Disposition: inline
In-Reply-To: <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YbGYe483803il3X7%40paquier.xyz>
Precedence: bulk


--/zVsbBhqFh4/hVC2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 08, 2021 at 07:08:56PM -0800, Andres Freund wrote:
> On 2021-12-08 18:46:04 -0800, Andres Freund wrote:
>> On 2021-12-08 21:18:54 -0500, Tom Lane wrote:
>> It's not stable, but afaict all the "instability" can be handled by rely=
ing on
>> a system-set environment variable... Referencing it as
>> $ENV{SYSTEMROOT}/system32/tar.exe ought to work? I'll test that approach=
 via
>> CI, but of course that won't verify that it works in all kinds of odd
>> installations.
>=20
> That worked: https://cirrus-ci.com/task/6302355785252864
> https://github.com/anarazel/postgres/commit/49cf19f160080353da391f177a7d8=
c28218023bb

Well, I am afraid that this is not a completely stable path.  That
would not work here, for one.  Could it be possible to use a soft
failure instead?  If $ENV{TAR} is defined but the command cannot be
found, what Tom proposed upthread seemed like a good alternative to
me, as of:
https://www.postgresql.org/message-id/3657697.1638980149@sss.pgh.pa.us

If this is switched to a hard requirement for any Windows environment
(I can adapt to the new order), it would be better to document all
that in the section of the docs for Windows and the tests of
vcregress.pl or users could finish with surprising failures.
--
Michael

--/zVsbBhqFh4/hVC2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGxmHsACgkQnvQgOdby
QH1n7Q/9H7G9xOfBAF0YmeMav1eAzcXMRwoAMZ5/PcYr1ePB9NSd6LOdxCrbwIbp
GXhdwW9iTLGKQ4UouXnFe3uOR3GSwRWuuGLUvkHYUEkJIa6lKNhL5ZO8h1EfnILe
5H6ymX2vR8LMeFw1S8jhHmeCUzJx4IWikNEGufHKsSy/qu6GmVvjUcVZoMcgt1Bh
Lv+MlaUrPHYjr01h4RC99d8hteVfSCvJJD53v9HS+5pWEoTkFyrEFG2YsQEIQghL
dOiL3Xq6fD+ics0n3kh1+2abI+Qgpc4djQSb7B7/zJDhIsR5/KKFbPmZ3owYKUsZ
BWNjFw6+ZVm9aMYqH4SmGY386SjRLchOglNQj6dP3ORZ0+ZjQJiY42OLFIsBv/RM
5tCD716Dv0wfyTC6dBt1/vD4E1RgmSneRtBm1sZ6Gp02hty2CaM547rvW1A5HS3k
aycQeYfNo+8WVuGqNG5p5/9HJR5JHBtXQCZq5Xc72ZRSoIknn0q7Sjy+9BeK9wFu
ae2nhK3c1oCrb4i8BCuHk1YXPm5IH0dTeTQp7B7AwC1CTmrTeyNvwN90U8YpFVtN
LM1zLFMYDapU22gTThjUh0HOznV7S11v3BbRo/5UAUm1dI9y66OUCXetaTuDRSth
BifSG9itYnYhKnbEHb6oaskT0hy1B+B8Wgo0RX+/y5gtTTUqAqo=
=Apgk
-----END PGP SIGNATURE-----

--/zVsbBhqFh4/hVC2--