Date: Thu, 9 Dec 2021 16:10:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Message-ID: <YbGr7ylYwE56l91B@paquier.xyz>
References: <3657697.1638980149@sss.pgh.pa.us>
 <b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
 <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
 <YbGYe483803il3X7@paquier.xyz>
 <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kIN6ZXvr/nzojFr0"
Content-Disposition: inline
In-Reply-To: <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YbGr7ylYwE56l91B%40paquier.xyz>
Precedence: bulk


--kIN6ZXvr/nzojFr0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 08, 2021 at 10:49:28PM -0800, Andres Freund wrote:
> Could you expand on why it doesn't work? As far as I can tell tar is shipped
> with windows these days, and %SYSTEMROOT%/system32/tar.exe should point to
> that tar?

FWIW, my Windows 10 VM, that I got from Microsoft a couple of years
ago, does not ship it in this location, simply, even after updates.

And I am pretty sure that you cannot assume that this will exist at
this location for all the Windows environments we still support the
compilation of PG.  My thing runs Visual 2015 that we still support,
so, if possible, I'd like to keep it around a bit more as it is useful
to check and test incompatibilities and/or bug fixes, and it has
caught problems in the past.  I got some copies of tar.exe lying
around, one from a git installation and a second one from Msys, but
both don't work even if $ENV{TAR} points at them :/
--
Michael

--kIN6ZXvr/nzojFr0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGxq+8ACgkQnvQgOdby
QH3mAhAAmUPR/po4QJifMDvas8BwiOB4KrCvRqshVoyoHAse/qoR05p0OdCUjBVL
72F7hXqnxWyVmO8tcjLN0fhOMg2v40j6ph6tRV9mMGFwkTWwb7tgg1sNJ7dq3V2U
8hi73lXn/g1EHEaGZdB7cV0putABnfnuRpPq8tKk9c+claRTslmctPafXzjT9vBa
Y+u9PrB0neHmT1bZWbXd5zVFm9BF3vA3nr+bAD2U7YMI1bHU6CNiHDd5i//bzpl/
ANXvI0Db5TAlCf+v8Mihl6yGFzpMQq/qzIGPd/0kNFZ+UlLWmr+/XgY2OvN3Rp7L
lfaEp1eG3p6Zxhi3rHz4NV5SVc4bX+gOu3wuzpxpuln4tCFvqZHfcI5RQECog4cE
svFrGUCe53PXprXNiC+uuz1cnu7UTYt8DjviGO/YksMAVfBkcTR4YKveEQ886D7W
Bbw7nldB9u//IjeZ5SEebT6omtEWpIqGWBvdoViyw4iy+A2g7tyArwwtrAzf0BNt
YGqsvyX7v5DBJhG3LVV54SJLFs0h3BSyBL6ZQHK2iehJ2GgAkQXLwEPmbvck+8fb
bNRmd5jPkFAqb/PDuvT0TIop9v37jiNsy00wCGXzpVZR4Z6y9LUYwmnX+eTtShKw
ixC8bGL8ZH4cAdBXRFWJumuogNTbf1pGYjws3CxM/a7jDVZVCpQ=
=kYCl
-----END PGP SIGNATURE-----

--kIN6ZXvr/nzojFr0--