Date: Mon, 13 Dec 2021 17:08:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Message-ID: <Ybb/itFhY3FrsyzF@paquier.xyz>
References: <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
 <YbGYe483803il3X7@paquier.xyz>
 <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
 <YbGr7ylYwE56l91B@paquier.xyz>
 <95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KrhfYH7/62Pxhl7T"
Content-Disposition: inline
In-Reply-To: <95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/Ybb/itFhY3FrsyzF%40paquier.xyz>
Precedence: bulk


--KrhfYH7/62Pxhl7T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 09, 2021 at 09:05:21AM -0500, Andrew Dunstan wrote:
> That's odd. What edition of Windows 10 do you have? If it's not Pro I
> could understand it. I just checked and every Windows 10 machine I have
> here has it - and some of them are quite old.

Digging into that, I cannot find an exact build number, but it is
named Windows 10 Enterprise evaluation, which is, as far as I recall,
a pre-created VM image for VMware, so that was pretty useful.

I have been testing a couple of ideas to figure out how I could solve
that and if a system update could add a proper tar command, but I have
not been able to fix my thing.  For the time being, I think that I am
just going to stick a ENV{TAR} = '' in buildenv.pl to bypass the
issue, and I have no objections to switch to
%SYSTEMROOT%/system32/tar.exe by default.  Anyway, it would be nice to
document LZ4, GZIP_PROGRAM and TAR and the defaults we rely on.  Also,
the default values of LZ4, TAR and GZIP_PROGRAM had better be set
*before* loading buildenv.pl, and not after it is loaded, no?  On
HEAD, one has no way to unset any of those variables so it is not
possible to skip things if an environment has in its PATH a funky
command that TAP would refuse, like a tar command from MinGW or the
git installation.
--
Michael

--KrhfYH7/62Pxhl7T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmG2/4oACgkQnvQgOdby
QH29oQ/+POWi4jdfdfvJkcxpvUkopRmWZH0AUjPEtVssHYEgPXyy586Eu7N/zYsm
MTGnMfAl7gHD0arYq1TsIVjlWASqOKPaGi5Mtkt+qCw/GfZ59NR59cvv62kipR/L
+7RNWfswNrukfx5QKjp1YOLYbLhY02BAn/Aab6Ju4aOxWd8gyAKxeofzdtAyI91x
kAzzWu3nphh1VH4DY5Q/22g03/0kfUEtJ+MlXh2gBvYCpKr8Q/QIB0S0tqRpvt5f
dWKvptCwLqGieAvPTyTL0lAMz1n2zztkUHO5LTUrAl+nVS8SA0nlCUVg1kfOcrIG
8xwJPofVd1rmCLV6uR8/OxBsslU1SRSGfr3p61+Q/nby4AyxsafjIbtVqNCNNt8e
KpRHbwWzx5Kld3CDSFdemE7i9zwXtD4O3GaTRf5JU4RlhzNejhqu9OJCADqBm/fr
GHXFxqtJ0df9D/gz9K37EX7Boa6BOlY5bo6Ixo3CYWpe8lqAUt1/ZF0M/Lkg57af
IVMDueLVvGSElMuxYz/BfWvOIXoKcX15qUTakHvFic0OebPcWyrF1qwsfkdZZ+ML
zJ+6/tgm4vIw9zhUtd8L/Z9+IZH6Ch8ib3shWoESogpzC2kyjbPiLBJBISx+fxMS
tkJ6Xz5fBJJt/mxVi4SD5vhQqFtrLQR3BRYWXhaqnRborPWemCU=
=wklD
-----END PGP SIGNATURE-----

--KrhfYH7/62Pxhl7T--