Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5qQp-0003Rx-BP for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Jan 2022 14:41:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n5qQo-0000eY-7D for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Jan 2022 14:41:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5qQn-0000eO-UC for pgsql-hackers@lists.postgresql.org; Fri, 07 Jan 2022 14:41:25 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5qQh-0007nT-Iw for pgsql-hackers@lists.postgresql.org; Fri, 07 Jan 2022 14:41:25 +0000 Received: from msg.df7cb.de (unknown [IPv6:2003:5b:203b:100:7627:eaff:fe52:8e03]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4JVmB46YQyz3F0P; Fri, 7 Jan 2022 15:41:16 +0100 (CET) Date: Fri, 7 Jan 2022 15:41:16 +0100 From: Christoph Berg To: Michael Paquier Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Refactor tar method of walmethods.c to rely on the compression m Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Michael Paquier > Refactor tar method of walmethods.c to rely on the compression method Hi, since about this commit, pg_wal.tar is no longer compressed at all: $ pg_basebackup -D foo --format=tar $ ls -l foo/ -rw------- 1 cbe cbe 137152 7. Jan 15:37 backup_manifest -rw------- 1 cbe cbe 23606272 7. Jan 15:37 base.tar -rw------- 1 cbe cbe 16778752 7. Jan 15:37 pg_wal.tar $ pg_basebackup -D foogz --format=tar --gzip $ ls -l foogz -rw------- 1 cbe cbe 137152 7. Jan 15:37 backup_manifest -rw------- 1 cbe cbe 3073257 7. Jan 15:37 base.tar.gz -rw------- 1 cbe cbe 16779264 7. Jan 15:37 pg_wal.tar <-- should be pg_wal.tar.gz Christoph