Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n67yi-00059i-4L for pgsql-committers@arkaria.postgresql.org; Sat, 08 Jan 2022 09:25:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n67yg-0001IT-Kr for pgsql-committers@arkaria.postgresql.org; Sat, 08 Jan 2022 09:25:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n67ye-0001H9-Ui for pgsql-committers@lists.postgresql.org; Sat, 08 Jan 2022 09:25:34 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n67yZ-0003bY-TE for pgsql-committers@lists.postgresql.org; Sat, 08 Jan 2022 09:25:32 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D33323201E4F; Sat, 8 Jan 2022 04:25:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 08 Jan 2022 04:25:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=/d1UpRPVit16pqlZ2YlNscoYl40 qd+wPiX2sMcpyXPs=; b=tNI2vGpMDNdau3w4q8BqY0pTgrZ1vYmQ/xLzfR0tOW2 GdsbPrGA3wHMISKyNi6OmgbQuHVCmwTM2LmOgIGOxcqOz8bA1HW0Ob1rkydV5cE1 5fbYcaaBRH7A/c7IrVjPRS5s9nxIDjnqDJYhbWO97dd/tRGeVItKMlxVqbtm2tv+ ZdxEqgFOWz2c1Wb+zsO0sQ1/pAdABoNkTYc6uTb/Zo8zCyeIS0mYAQqTeHbdfcQj 1fjJFzZZtkoPxDCQ14KTdNOjUNSpi6nK35Tz926sUaw2dwxqEpfOz3i1JOac9znw s0OmwCw/dygCMvwVMA5GF/vrSXn6d4OHgvOnUGI+bCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/d1UpR PVit16pqlZ2YlNscoYl40qd+wPiX2sMcpyXPs=; b=LHFc83UNtdpRn9i7QBQp91 2RhC7yjDlEmaSpH8l56qblL9xsFfHqcbNhFUbCX2eMtfPB4yWHQC9/rcEG0NC+kp 9YsIZhtu6yWoqJ0cS97DHyG8Wm68GvuHVR6yJ4R0hg+dLg5NQvR5I4Axf2Xvu3Mg fMCmdWcH1NL0SghpxhiPyb0ibRowLd1gQOzfK7iMc7+jCuXCC6qYLQvFw43xvpvr rDrDKME3RMC+/FT+AsI7yOU1qeUbak+6LN4g+I4mf4SsF4CU28u7IobGgskP4SKS S9SfesdA0waUS7KXacaHwORbwEPesNoSPPdmQRy2VaD4r1vkVp60zZBF5Hu7Wq5A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeggedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeffudeffeelgffhkedukeekvedv udfgieetkeekudelfeevhffhffdtudffieeutdenucffohhmrghinhepphhoshhtghhrvg hsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Jan 2022 04:25:20 -0500 (EST) Date: Sat, 8 Jan 2022 18:25:17 +0900 From: Michael Paquier To: Jeff Davis Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Respect permissions within logical replication. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OsXKJCbbuTshFzBt" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --OsXKJCbbuTshFzBt Content-Type: multipart/mixed; boundary="i0cmt0QJiSZfUHsJ" Content-Disposition: inline --i0cmt0QJiSZfUHsJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 08, 2022 at 02:22:23PM +0900, Michael Paquier wrote: > 2) crake fails perl-check > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dcrake&dt=3D2022= -01-08%2002%3A47%3A26 >=20 > All the failures are the same, because of the shape of the subroutine > definitions: > Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl: > Subroutine prototypes used at line 13, column 1. See page 194 of > PBP. ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5) This issue is just caused by the way the subroutines are defined, meaning that the attached cools down pgperlcritic. Any objections if I apply that to cool down crake? Jeff, if you wish to do so, please feel free of course. -- Michael --i0cmt0QJiSZfUHsJ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="crake-perlcritic.patch" Content-Transfer-Encoding: quoted-printable diff --git a/src/test/subscription/t/027_nosuperuser.pl b/src/test/subscrip= tion/t/027_nosuperuser.pl index 742a745cf7..c9e4aeba06 100644 --- a/src/test/subscription/t/027_nosuperuser.pl +++ b/src/test/subscription/t/027_nosuperuser.pl @@ -10,7 +10,7 @@ use Test::More tests =3D> 100; my ($node_publisher, $node_subscriber, $publisher_connstr, $result, $offse= t); $offset =3D 0; =20 -sub publish_insert($$) +sub publish_insert { my ($tbl, $new_i) =3D @_; $node_publisher->safe_psql('postgres', qq( @@ -19,7 +19,7 @@ sub publish_insert($$) )); } =20 -sub publish_update($$$) +sub publish_update { my ($tbl, $old_i, $new_i) =3D @_; $node_publisher->safe_psql('postgres', qq( @@ -28,7 +28,7 @@ sub publish_update($$$) )); } =20 -sub publish_delete($$) +sub publish_delete { my ($tbl, $old_i) =3D @_; $node_publisher->safe_psql('postgres', qq( @@ -37,7 +37,7 @@ sub publish_delete($$) )); } =20 -sub expect_replication($$$$$) +sub expect_replication { my ($tbl, $cnt, $min, $max, $testname) =3D @_; $node_publisher->wait_for_catchup('admin_sub'); @@ -46,7 +46,7 @@ sub expect_replication($$$$$) is ($result, "$cnt|$min|$max", $testname); } =20 -sub expect_failure($$$$$$) +sub expect_failure { my ($tbl, $cnt, $min, $max, $re, $testname) =3D @_; $offset =3D $node_subscriber->wait_for_log($re, $offset); @@ -55,28 +55,28 @@ sub expect_failure($$$$$$) is ($result, "$cnt|$min|$max", $testname); } =20 -sub revoke_superuser($) +sub revoke_superuser { my ($role) =3D @_; $node_subscriber->safe_psql('postgres', qq( ALTER ROLE $role NOSUPERUSER)); } =20 -sub grant_superuser($) +sub grant_superuser { my ($role) =3D @_; $node_subscriber->safe_psql('postgres', qq( ALTER ROLE $role SUPERUSER)); } =20 -sub revoke_bypassrls($) +sub revoke_bypassrls { my ($role) =3D @_; $node_subscriber->safe_psql('postgres', qq( ALTER ROLE $role NOBYPASSRLS)); } =20 -sub grant_bypassrls($) +sub grant_bypassrls { my ($role) =3D @_; $node_subscriber->safe_psql('postgres', qq( --i0cmt0QJiSZfUHsJ-- --OsXKJCbbuTshFzBt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHZWH0ACgkQnvQgOdby QH2pwxAAnbdb6DBA6Zpm5sX0xm5ui6dxeSJPlgHKJ2gnvGGenmBgnVHZt0dhXBMi A6+FsxEjdEfu9dGF5Vp/t3ieS7RL1rLdjGPMYdfgM/ExOS2o8gN3B4qchcQV+kSv ixD7ERsClFhjnMi8KweQy+soWN7P1YnLkts/fGgrcM6K1wKtRhm3jkCz7iMyKgnf QETjI3uInrjTKW1WKaHLlDYs6Mh7jMySUd7aJZPwTnIeRE26nFmGjrnpG8RSAZTp QSm1FWWkofEA/YAmXj0TwTu7owZ7h9Z/eeeaPWQWU5aayw36jD6cMdC3Hhk6GjCp 5FI6H71LVpxfK8CbykIl6O46Ga/0Jgczq8k71Gf73QwSSHykUb9m0g8RFej4xUnd xJ2t1/puibkbVoxOomO3V8LMb/dSKZVh7zefv15tuiRnmV9HawPOOM8M0WcT+hht KY78MtWRaTV2NQgyYPXnBPMP2+kSB+3xpAA3wn13SdYFyXlPTPerqXUTPkHrQMr6 PZi1spm21ob1bFHhvYHoHXbfSri1lioCWd8VAdRClqk3cB5ZRBbZCkINhHFX0M2g il5XZWjM32vLLNVYghn/jAJHq2J9JMpmFjEni5cw4AdG5/zxQri2i/IYCNMPksr9 0xZPW8ufSalZ+vYKwjtQRoZggyjmJSTy5U0MzXadIP7saIM5Uak= =qua9 -----END PGP SIGNATURE----- --OsXKJCbbuTshFzBt--