Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKzjR-0005mO-5d for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Feb 2022 09:39:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nKzjQ-0003yw-1z for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Feb 2022 09:39:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKzjP-0003wP-Nq for pgsql-hackers@lists.postgresql.org; Fri, 18 Feb 2022 09:39:15 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKzjN-0002m0-49 for pgsql-hackers@lists.postgresql.org; Fri, 18 Feb 2022 09:39:14 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1477:7740:cd1d:a79a:9a0c:c893]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4K0RV60bRBz3F0F; Fri, 18 Feb 2022 10:39:10 +0100 (CET) Date: Fri, 18 Feb 2022 10:39:09 +0100 From: Christoph Berg To: Robert Haas Cc: PostgreSQL Hackers Subject: Re: pgsql: pg_upgrade: Preserve relfilenodes and tablespace OIDs. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Robert Haas > > This needs to be guarded with "if (binary_upgrade)". > > Right. Sorry about that, and sorry for not responding sooner also. Fix > pushed now. Thanks, the 14-15 upgrade test is passing again here. Christoph