Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIkBY-0007g2-Ee for pgsql-committers@arkaria.postgresql.org; Sat, 12 Feb 2022 04:39:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIkBX-0007yc-BX for pgsql-committers@arkaria.postgresql.org; Sat, 12 Feb 2022 04:38:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIkBX-0007yT-4J for pgsql-committers@lists.postgresql.org; Sat, 12 Feb 2022 04:38:59 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIkBT-0004GL-RQ for pgsql-committers@lists.postgresql.org; Sat, 12 Feb 2022 04:38:58 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B062E3200C14; Fri, 11 Feb 2022 23:38:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 11 Feb 2022 23:38:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=GOkU2lFYeMj9pRu+9VZk4p7iEU6aY2EHWeTaWw eU6P0=; b=V2JkM+QlJUyZM9arAmxsqmRcI05U/xefQmT02Oa0aPyw2+IAzJLT2r /kCenil+dwrfIAZ6gKO8kxvsGmNWtzhjUkZQrHkyQsVJX+GYerqh7tg8C9DDxilH PH0mMDWrmhdI4FhfZE0eNeZqwZMuOMgm5fjm7xrxMsQ75AKkE2Q9AUceLw+MBPwS hhHSXjbnLnx3zClFC1ZUWP+T840Yqp2N3fOa4sA4+J++Iaqvgy2uO5LnwRu24D9n SSY5YTUtWgI6r7wxHYogiuRSqQnFT55vvf2rTUCqr5wS2GvZzaDfrm/8nsXMF8uc pAdYplhKiEpmwRoByx0G8HwGqG9Ecm4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GOkU2lFYeMj9pRu+9 VZk4p7iEU6aY2EHWeTaWweU6P0=; b=cdYDV/7G1aop4HmsUHMMFt6VGRORMZVaH T++zDbO9JSb+Dzlq3Y7fxsDL6qPkWOh16iG+VMvmq9y5CC9xBPVPEwza9e1LOgYv 3bKw/y284mOWE/Dv10qHF+L6FTUiQHUZvkY2uTP8MX+MG8qQOCGHwbCi3YO/wxmd 0ZQSbwm2qYfQcZhI9RCw6KxpA44UZbR53UJMX+GFLmVD/RncFMdROkLVBLwzTST7 VyZO3VLyAYQuMblHWd+931uA2mCGL28RmAaHKp69pXgtdzAYKiYaJjJRD7Qty0BW FkYF9sUSwLldUH/145VjN6MJYs9RxgVqOwQPg3NXxBTYxG4v7TI7A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieeggdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepfffgkeegteeuhffffeeiffduveev gfefteeuudfhvdfhgfffgeejkeeltdekvdevnecuffhomhgrihhnpehpohhsthhgrhgvsh hqlhdrohhrghdpphhgshhqlhdrsghuihhlugdpuhhtihhlshdrphhmnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqh huihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Feb 2022 23:38:52 -0500 (EST) Date: Sat, 12 Feb 2022 13:38:45 +0900 From: Michael Paquier To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="00WEUUaKmzYilGra" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00WEUUaKmzYilGra Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 11, 2022 at 01:54:36PM +0000, Robert Haas wrote: > Add suport for server-side LZ4 base backup compression. >=20 > LZ4 compression can be a lot faster than gzip compression, so users > may prefer it even if the compression ratio is not as good. We will > want pg_basebackup to support LZ4 compression and decompression on the > client side as well, and there is a pending patch for that, but it's > by a different author, so I am committing this part separately for > that reason. >=20 > Jeevan Ladhe, reviewed by Tushar Ahuja and by me. copperhead seems to be unhappy here: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dcopperhead&dt=3D2= 022-02-11%2021%3A52%3A48 # Running: lz4 -d -m /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_0= 08_untar_primary_data/backup/server-backup/base.tar.lz4 Can't exec "lz4": No such file or directory at /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/../../../src/= test/perl/PostgreSQL/Test/Utils.pm line 388. Bail out! failed to execute command "lz4 -d -m /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_0= 08_untar_primary_data/backup/server-backup/base.tar.lz4": No such file or directory ### Stopping node "primary" using mode immediate Perhaps you'd better check that 'decompress_program' can be executed and skip things if the command is not around? Note that 020_pg_receivewal.pl does an extra lz4 --version as a safety measure, but 008_untar.pl does not. -- Michael --00WEUUaKmzYilGra Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIHOdUACgkQnvQgOdby QH2R7g/+LzNiIipD0djrKg/eOSMDJF51NMCTgE36J41wiDeUKR03fqWSZEvnhQxp ATElM/bVL/q5z2cdSP2s4TbYsQ9iWKakk2VJVp2r07y50snmq8P55GwtHpNTtFNy gA9oY61InXoTwz1W0VVXqWBPBMuxfX/5IAmzhtsX5erjxr0ZZR/okWIEYBwumGmh LlWCBVPtShksWHtyXmb1K6GyQl/3wYiIGqgVz96h7UTsgRivOs5pUBJ07YZbGstU XfAz70yAKy/RKeaEY3/Xz+5/+XmQuMRDOsOSWJ+lc1mb46nRcgIvBsL9qcv2NQBZ GrdGeOTE3d+Qxk4GYf/6rIpteG+goy9qt8tW1gvsIRzBuiXV8ovrspeohiOWWOUI 228yaHcv5kUzbUryHH0BFNsODQxhQUXM1t+32c6aILAib0VRM3ih2HCEP+bO3Gk/ k8Kkqtsn/sKFUgJAkegwNJwyDLJ8q3+jbWjhKMhg65ysiMSHzv5gmkBFgWnvEgCL 7JPJ66Y+9z4QYHn4zq1udLHrppeAfn8BWwul6NXL8ebmC+BLQU0TmebmFQ93zpV2 Ypa7VP+nRg9z0T9Pcztwv5/DmQ+PB4clo1heQpoDHh6vzDsZ+f8qCz3LJBm6GZgv ZdrBix4rIOiJ5Nl7q4Iy2SsA75OgpVWs8RsgCr2BE7dzsxCJoHI= =eKzE -----END PGP SIGNATURE----- --00WEUUaKmzYilGra--