Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIvJb-0000NF-6i for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 16:32:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIvJZ-0003oK-3x for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 16:32:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIvJY-0003oB-Qf for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 16:32:00 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIvJV-0005YF-Rm for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 16:32:00 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1477:7740:df3c:d202:ca71:8aa5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4Jwwx82M3Zz3DwT; Sat, 12 Feb 2022 17:31:56 +0100 (CET) Date: Sat, 12 Feb 2022 17:31:55 +0100 From: Christoph Berg To: Tom Lane Cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc Message-ID: References: <2280644.1644683003@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2280644.1644683003@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Tom Lane > Christoph Berg writes: > > I think the "bug" here is that vanilla PG doesn't support installing > > in FHS locations with /usr/lib and /usr/share split, hence the Debian > > patch. > > I'm confused by this statement. An out-of-the-box installation > produces trees under $PREFIX/lib and $PREFIX/share. What about > that is not FHS compliant? And couldn't you fix it using the > installation fine-tuning switches that configure already provides? To support multiple major versions in parallel, we need /usr/lib/postgresql/NN/lib and /usr/share/postgresql/NN, so it's not a single $PREFIX. But you are correct, and ./configure supports that. I was confusing that with this: The problem that led to the pg_config patch years ago was that we have a /usr/bin/pg_config in (non-major-version-dependant) libpq-dev, and /usr/lib/postgresql/NN/bin/pg_config in the individual postgresql-server-dev-NN packages, and iirc the /usr/bin version didn't particularly like the other binaries being in /usr/lib/postgresql/NN/bin/. I guess it's time to revisit that problem now and see if it can be solved more pretty today on our side. Sorry for the rumbling, Christoph