Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIwO8-0005YR-8j for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 17:40:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIwNb-0003bt-Gx for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 17:40:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIwNb-0003bk-7k for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 17:40:15 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIwNU-00067a-B2 for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 17:40:14 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1477:7740:df3c:d202:ca71:8aa5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4JwyRq0d5Hz3DwT; Sat, 12 Feb 2022 18:40:07 +0100 (CET) Date: Sat, 12 Feb 2022 18:40:06 +0100 From: Christoph Berg To: Tom Lane Cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc Message-ID: References: <2280644.1644683003@sss.pgh.pa.us> <2282966.1644684600@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2282966.1644684600@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Tom Lane > Ah. That seems a bit problematic anyway ... if the version-dependent > pg_configs don't all return identical results, what's the > non-version-dependent one supposed to do? It still returns a correct --includedir for client apps that need it. (Unfortunately many need --includedir-server since that's where the type OIDs live.) Christoph