Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJQYN-00016n-Dr for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 01:53:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJQYM-0002FV-8e for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 01:53:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJQYK-0002FL-FM for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 01:53:21 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJQYF-0004aC-2I for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 01:53:20 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 120F43200946; Sun, 13 Feb 2022 20:53:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 13 Feb 2022 20:53:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=0TZc5j5tF2CThHa7qJF1s8KzgxyUdajyEWWCrw wk6LY=; b=eaC5tOee7O3k/QBqs6oca53Arh9hEZGc1xrNr4cqJQfIeIpcxJ3pDc gbQWRD3PvPXo0b5BH9AfNIy4yjNRVl9MpKnGviLEjkkwFc4Q50BTKzottNS1mv6c 9BFwf5SM3UBMKyUKSRSUKoQGn+HunjoOH1bmGqcymOF+hioXNmUClLHTbS125GUk 3RNmvWOS9s7bgWI9mUtvx/vG/+NE1v3PM68uXlv7Y0e0PK0uqcAIxmzlfjIOmb4E IXT4GST8tGD0xeeEn8F+XgFoPGkEXwH74WQX7I/Zu9L/w5kOmCtlqqARWqhZLBN4 KcbtqvyHgjXhQPaoe+65NPTjotDNlFLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0TZc5j5tF2CThHa7q JF1s8KzgxyUdajyEWWCrwwk6LY=; b=UDjpfyMvnSxM/7sTs4/hRE3Ew294DtgZV /J4R9kKPt/pzgbWb/jqg6C8dl53+v8gmYmRVXPJ+sG9p0njyE15W0vfc8FWYrBGM n5x4CsExPIdiH9Tv9POeZ9cwHHrvcrgU1WYNeIhAtjH50w3OQKxEcO0NLpcm2tT2 X7OZXrAUsI7ssaqN/o+vtXZgLGIGULBR2N5PUATtwjjNKaVBHs1q0DPgJslOLlCx VX6P5RUsKzn0Gtfvim3pFuM9UdcJWnd0VQenY8+vQi2dLZUSvsLQmezFa8T3Pzj0 d2+OEPhiBymFl6kVjWID4mk+OZgpKpfGCQFWnP94Gagox8m6wEAJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjedugdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Feb 2022 20:53:08 -0500 (EST) Date: Mon, 14 Feb 2022 10:53:04 +0900 From: Michael Paquier To: Robert Haas Cc: Tom Lane , Andres Freund , PostgreSQL Hackers Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. Message-ID: References: <20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de> <2460218.1644704163@sss.pgh.pa.us> <2523849.1644725570@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sbwLybKdnrq055TV" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --sbwLybKdnrq055TV Content-Type: multipart/mixed; boundary="vDjPgIiAiamat6Lr" Content-Disposition: inline --vDjPgIiAiamat6Lr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 13, 2022 at 11:13:51AM -0500, Robert Haas wrote: > Well, that's because I didn't realize that LZ4 might be set to > something that doesn't work at all. So Michael's thing worked, but > because it (in my view) fixed the problem in a more surprising place > than I would have preferred, I made a commit later that turned out to > break the buildfarm. So you can blame either one of us that you like. >=20 > Thanks, Michael, for preparing a patch. Patch that was slightly wrong, as the tests of pg_verifybackup still failed once I moved away the lz4 command in my environment because LZ4 gets set to an empty value. I have checked this case locally, and applied the patch to add the ./configure check, so copperhead should get back to green. A last thing, that has been mentioned by Andres upthread, is that we should be able to remove the extra commands run with --version in the tests of pg_basebackup, as of the attached. I have not done that yet, as it seems better to wait for copperhead first, and the tests of pg_basebackup run before pg_verifybackup so I don't want to mask one error for another in case the buildfarm says something. -- Michael --vDjPgIiAiamat6Lr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="basebackup-tap.patch" Content-Transfer-Encoding: quoted-printable diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_base= backup/t/010_pg_basebackup.pl index a9b2e090b1..7c3074329d 100644 --- a/src/bin/pg_basebackup/t/010_pg_basebackup.pl +++ b/src/bin/pg_basebackup/t/010_pg_basebackup.pl @@ -768,8 +768,7 @@ SKIP: my $gzip =3D $ENV{GZIP_PROGRAM}; skip "program gzip is not found in your system", 1 if ( !defined $gzip - || $gzip eq '' - || system_log($gzip, '--version') !=3D 0); + || $gzip eq ''); =20 my $gzip_is_valid =3D system_log($gzip, '--test', @zlib_files, @zlib_files2, @zlib_files3); diff --git a/src/bin/pg_basebackup/t/020_pg_receivewal.pl b/src/bin/pg_base= backup/t/020_pg_receivewal.pl index 0e6e685aa6..1717e22a9c 100644 --- a/src/bin/pg_basebackup/t/020_pg_receivewal.pl +++ b/src/bin/pg_basebackup/t/020_pg_receivewal.pl @@ -130,8 +130,7 @@ SKIP: my $gzip =3D $ENV{GZIP_PROGRAM}; skip "program gzip is not found in your system", 1 if ( !defined $gzip - || $gzip eq '' - || system_log($gzip, '--version') !=3D 0); + || $gzip eq ''); =20 my $gzip_is_valid =3D system_log($gzip, '--test', @zlib_wals); is($gzip_is_valid, 0, @@ -186,8 +185,7 @@ SKIP: my $lz4 =3D $ENV{LZ4}; skip "program lz4 is not found in your system", 1 if ( !defined $lz4 - || $lz4 eq '' - || system_log($lz4, '--version') !=3D 0); + || $lz4 eq ''); =20 my $lz4_is_valid =3D system_log($lz4, '-t', @lz4_wals); is($lz4_is_valid, 0, --vDjPgIiAiamat6Lr-- --sbwLybKdnrq055TV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIJtgAACgkQnvQgOdby QH3GCg//TK4A8/Vo13q8f7tB0OZpavuzCEdjtXhRnUx8dloXRW7Mdn8ctp60IKjk wG9bP2SLaKVFF17Zlo8e3DLu/467afMqAg0xqvTM6eB2NKpYy7t6Xqp/B3Kvh2Ko RX1/5ZMTFApBoGUvfjnBLDQ2fID0VoOOiApZA6tkej9bg5ulgO7Mr6WyAg6MtRDe //evyKDjjxEvhqqzqIw4p0NFy7fTM75vIyuCdE+k/+ETzFHk5yZfA5KLVgYPXrDv ryGcj+HcpR8+62Z0Ft+6swRaqgLyuGljsAtcrsa2pK25TpyJjfWZAeZD8pg77qeh rcH+AJFHJDWwxDt9XFVY7Fazo7VFLIu7W47CQRQFFHvl11J7e4S0+ZEKfNmmW8jF vSoatp4kkU9ey4veJKamv5RdGE2YeQwXrJ+dLGmufeDp9kHLT7dRLKtOy3JcKe7h P8pskI+dq9Qk4NZEP4pqGUX//eFCXkYw6BgOqcoMRhdXerlXfeiyHjtkAf+86mHV ypUbtFahO9/SnUleD8W9YLYqRRh/f4v14aOcsyetVF+HMgeeU49kUAobz3QydMsN SbC/vj86czuJWL7JrvxyElz9K0Lkyq1iST+41bPjCD1vSQroEofokH18pNVDKNqj GUZR7vylFS51TnFotFkPJvv21aDy3EOQskbjalPBzWU1TPMQedM= =ZFV1 -----END PGP SIGNATURE----- --sbwLybKdnrq055TV--