Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJQia-0001vk-VI for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 02:03:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJQiZ-00083s-PZ for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 02:03:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJQiZ-00083j-GD for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 02:03:55 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJQiV-0008Qx-3x for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 02:03:54 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 438453200B25; Sun, 13 Feb 2022 21:03:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 Feb 2022 21:03:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=mT2txBWXj5i4VxljVgiBSGIi8ldkaZ8g38/zRh qzlZU=; b=kdjfwzC4UIYYtD0Pf1IrEZizDe+DiQExkuIP1iKeb4cR91CkZXY38z MHiPenju5y4K9gpue87uqaibJxZAwmgj2kWaiaifCW7HKKP+K90dfpskVM1bMhS8 I8qoh7wuhXcXmH1Cv3t5srBebVpUujjXt/jxaunWg4RENUQ+xOPwsFDEpUcUj9RV u2DCS+Exxh08PO+6CeH3jp+1Ws9tjqpTMZuXTjP5TWigP9/jvjgX7aqcaqCEuFEl vNhTgb88npFf8pG+9/zQ/uCymILjCHKSukjpse/jGnYfI+QYLpVdQKhRdT2QZyKH KBqh2NQL05JbieIcZ6q+RXM7xA0syL+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mT2txBWXj5i4VxljV giBSGIi8ldkaZ8g38/zRhqzlZU=; b=PISnexvPe2NlZ5oTkiXCK67gmAnlrYRur hrGQ+uNcLCqqRCkkVdsE1lrh4nLF9nvVXnUwnzqI68EYUxYLmpzvMsse025PhzoB /a+MidYJvDWZhfiSO17E4IlUiYOzO/EWF/BUZighyjDPduRWOIEroGqQmFQ9F/t9 BpDgkubcsJpispngkWNF9L6lhIQ7yxN1CBSc6XHZNGtI1Mqbxxiv0lgNcKfkVKje vnwW7MvAVEHh51ADB/Y6oiHki1tfht7SXVZ6oCTjSqxqb9Ggo7OZ0UvSmEIGxOb6 U9LMtS1wEdcnQONK6qJP3aR7otQiS7El1YVdOXbXL2nGxaPzEaxYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjedugdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf fukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhi vghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnh epvdegudeuhfdtueeltedtveejheehieevueeigeelteegleejleeiueeiheegvefhnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrg gvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Feb 2022 21:03:46 -0500 (EST) Date: Mon, 14 Feb 2022 11:03:44 +0900 From: Michael Paquier To: Christoph Berg Cc: Tom Lane , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc Message-ID: References: <2280644.1644683003@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NP5lNSA1mVWpNozk" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --NP5lNSA1mVWpNozk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 12, 2022 at 05:31:55PM +0100, Christoph Berg wrote: > To support multiple major versions in parallel, we need > /usr/lib/postgresql/NN/lib and /usr/share/postgresql/NN, so it's not a > single $PREFIX. But you are correct, and ./configure supports that. Yep, I don't quite see the problem, but I don't have the years of experience in terms of packaging you have, either. (NB: I use various --libdir and --bindir combinations that for some of packaging of PG I maintain for pg_upgrade, but that's not as complex as Debian, I guess). > I was confusing that with this: The problem that led to the pg_config > patch years ago was that we have a /usr/bin/pg_config in > (non-major-version-dependant) libpq-dev, and > /usr/lib/postgresql/NN/bin/pg_config in the individual > postgresql-server-dev-NN packages, and iirc the /usr/bin version > didn't particularly like the other binaries being in > /usr/lib/postgresql/NN/bin/. >=20 > I guess it's time to revisit that problem now and see if it can be > solved more pretty today on our side. If you can solve that, my take is that it could make things nicer in the long-run for some of the TAP test facilities. Still, I'll try to look at a solution for this thread that does not interact badly with what you are doing, and I am going to grab your patch when testing things. -- Michael --NP5lNSA1mVWpNozk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIJuIAACgkQnvQgOdby QH20sg//TM1Ky3kyl0B0Tx6fTlx/nNrIov8a+pLTfvr0364kwpIykB4eh0LIuO60 lJJVOCjBklFLQx4PTN3llxZKUMppmESWIzrHepRpE1yC7VyPsVvPPDRwfcKpvYtn OQSBU0soYOltITpOG9eP9uJ2wv+41+EZfq7RXSACgDEy0qLMwKq2KWR7aXwgMbja HzrNCMaEQHhHGW7Ka10z93L+GMYH8jObB0f+Y+pGh54OR1iEoHRETkq8yqrftl5x Pzy7NW6PyoRqstpPaeAcq2pbaaz3u4mnNjU1T98B8fhxibPBuaiZOYCSvXW3gppE pDLEVJJHVWXkQ8pEgcVgRrdJIZOukLnsbjfhpEJNHzI8aDFg4B+pewZgookEQ0dt 4bXEbo2/gar0U8+b7dFQYOWqUiPpyKc3IY9r7LlkjaxuhCmJbgsylxXfFSM/dQwM 4r05Ig9b2MMdIh70QK+8wKAltjfYGey5/MoCQVhKXHiKGGufv4FjCNRg87JA07Xw hu5OJAirkHL2HnWk50SifZozCyVlPMuFvFOM+GzjmbiDo317b2msIr219+UCUhVM f0ktU1t/nIhNJnvDGGtAHOtXynuZPdNzw3GWrIZTPX4e9SCOOvFZ8x3ISyDiWCc0 BpdcSv9k02EJOwe9apr16L4y55hTK67gCq8A4ypoE9W1GCen7IE= =acPP -----END PGP SIGNATURE----- --NP5lNSA1mVWpNozk--