Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJOpN-0000AT-0v for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 00:02:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJOpK-0002B6-W0 for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 00:02:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJOpI-0002Ax-UE for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 00:02:46 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJOpB-0007at-Cs for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 00:02:43 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 837503200D53; Sun, 13 Feb 2022 19:02:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 13 Feb 2022 19:02:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=DgjyTye6Ycsp2JtM+jht1SvdLTeMOTKxna0VrZ pHS7A=; b=Op340YmZz3bLa10z3XNuRRGTUU90331Zu9usYS4ri4I5UocrxZhMCp t4McehRGO1iSyJgUfSAC9CJfDEL6CAxLbBjsOuQCThsLdUrWkOIsKkYHFePb2wS7 +5WT1FQU//mdFEfWisMZOmj5imI1uPg8pGJ+0qf0LtOTxSMODvypoq3LdphJddk3 +9bBIxYRwNwEklp7X6FGpuX4QT4x+hA1jdnxgvOhxpojp8ibKWmP24F7fmVqkkn1 wvTHcUs/+SE5Nlti9l7yTB+e/UaUUDRbOgKMMwZOMFYUX9ADlt97YjhdqRLOk9ii E+VJ0/wnPg6YM+E9/LM+7clVUPiJFIFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=DgjyTye6Ycsp2JtM+ jht1SvdLTeMOTKxna0VrZpHS7A=; b=V7c+0l38mpxECmX1JFyLZsQMnel/dokCF 07MaZfrua2jLuubURZecU54ZN6OgaYs2P2WsU/Ymbr84nfIOy57KUN9lBi2J2FAb av5+CTnvbEbrspMMDarZZM9nh3kOPzl9nfyp9z6Ut7lMQSZmh8vIpFIy684A59wE pgtZirjt6D2jCqpSyIExwcgNFlU9W0UfhIzRc9T+Oje/QmmqtrJ01BZzYCPGB3p1 E7dVlBA/WZUrcfgx1HmNCY5RXEgrWgKEEowfmRgEC1HPoRs+cqOEakrnKi9QjQp3 T1WaqF49POwSG4LhiSFs3Maiivkkl/D65MVo5VdTirNLZB7QM38dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjedugddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepkeefhfeitdeijefhveffkeffkeei vdehkeelvdegvdehffejffekgeetvefhvdejnecuffhomhgrihhnpehfihhnvgdrvghhpd hpghhsqhhlrdgsuhhilhgupdhpohhsthhgrhgvshhqlhdrohhrghdpphhmrdhmvgenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvg hlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Feb 2022 19:02:33 -0500 (EST) Date: Mon, 14 Feb 2022 09:02:29 +0900 From: Michael Paquier To: Tom Lane Cc: Robert Haas , Andres Freund , PostgreSQL Hackers Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. Message-ID: References: <20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de> <2460218.1644704163@sss.pgh.pa.us> <2523849.1644725570@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Mu4kSDMN2+yW2LVp" Content-Disposition: inline In-Reply-To: <2523849.1644725570@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Mu4kSDMN2+yW2LVp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 12, 2022 at 11:12:50PM -0500, Tom Lane wrote: > Michael Paquier writes: >> Well, this somebody is I, and the buildfarm did not blow up on any of >> that so that looked rather fine. >=20 > Eh? copperhead for one is failing for exactly this reason: >=20 > Bailout called. Further testing stopped: failed to execute command > "lz4 -d -m > /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t= _008_untar_primary_data/backup/server-backup/base.tar.lz4": > No such file or directory Well, I have put in place a check in the TAP tests, that Robert has managed to break. It looks like it was wrong of me to assume that it would be fine as-is. Sorry about that. >> Adding a few cycles for this check >> is fine by me. What do you think of the attached? >=20 > Looks OK as far as it goes ... but do we need anything on the > MSVC side? It is possible to tweak the environment variable so one can unset it. If we make things consistent with the configure check, we could tweak the default to not be "lz4" if we don't have --with-lz4 in the MSVC configuration? I don't recall seeing in the wild an installer for LZ4 where we would have the command but not the libraries, so perhaps that's not worth the trouble, anyway, and we don't have any code paths in the tests where we use LZ4 without --with-lz4. > Also, I can't help wondering why we have both GZIP_PROGRAM and GZIP > variables. I suppose that's a separate issue though. =46rom gzip's man page: "The obsolescent environment variable GZIP can hold a set of default options for gzip." This means that saving the command into a variable with the same name interacts with the command launch. This was discussed here: https://www.postgresql.org/message-id/nr63G0R6veCrLY30QMwxYA2aCawclWJopZiKE= DN8HtKwIoIqZ79fVmSE2GxTyPD1Mk9FzRdfLCrc-BSGO6vTlDT_E2-aqtWeEiNn-qsDDzk=3D@p= m.me -- Michael --Mu4kSDMN2+yW2LVp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIJnBUACgkQnvQgOdby QH2uLQ/9EXEIzF/7HxZd+pVXwhQZcpcT7lBwVvMA85tKhDbE9G8c3qjlrOfb28x0 oBDgHKNnSAkyDatq6MfEJnzu6SJbFItpzlS55SGU6Rx8zN1gPUmvivDVcBj3Gw+u 4aelM+SBVyekuQhXi6puf8zycHJRMmTKHRw0J6lq52NlVtscHxZQTQ7M26Vm5AdX sksJAcGlvu//77GhmbT9aKF9gfa2gE6g0JfgfnY0aaqte8DPRNoWkwMnEiFRHpco lMKcxuLnPjySVgILlU/xiRNW86dM69CgCrHqVjoVEWqcg9dCYkmU0945shzw0cGp BDiaBvhrHKo04gr+c/1maQ5hT40YTvD3q1waNey4SXIq2KQ2hdezLLuxXSUERACw B3p1zNu4TM5LZ7nzur6U/N+tTA+QYmZBUM81thdRiJD1sbytMS+VsWICHiqETFjG H8Ej6qDz1sbOxSgpzKKgnCrbgWkFzPS3ik4h58WRLVFMb3wKs8yD8zfPncE7q9fp X+afATDLWbGo/hZkwwszTt/Dc1NV95ADUtfx/d6Jmg0EZKrhIjlcDzLnaWEIGWw3 emhS60E2zP6yF6HdIHQceZaPwSH4sEN7k4l2bMoVJWoYi0p8vUGXc3SZQ6Lo1TMI DgR0hI1VmLT7ijCBGKopOrTMh+Yw3oWXl4KqEnaTP0Yo4THd5QY= =3Ig3 -----END PGP SIGNATURE----- --Mu4kSDMN2+yW2LVp--