Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK9ye-0006ye-8p for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Feb 2022 02:23:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nK9yd-0007of-6U for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Feb 2022 02:23:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK9yc-0007oW-9v for pgsql-hackers@lists.postgresql.org; Wed, 16 Feb 2022 02:23:30 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK9yZ-0001yN-IW for pgsql-hackers@lists.postgresql.org; Wed, 16 Feb 2022 02:23:29 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2D7285C0180; Tue, 15 Feb 2022 21:23:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 15 Feb 2022 21:23:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=ZAhuykMQDo7OfUolCKyLtBDhoGoSI2xJkVHFue 5tGrU=; b=qBl8ncsnfoMnmZ9phw5WiINtwkBekqyvtoee2xvUzdrs2N50//8gVc oUojEUd0VAdOqxjDArf005ifmEnlwA1pFM4FDvPPAa2n/jz3VSTD+CF2qB2jGiYc bDaK+8Z5yC16Km3B6ldrLODlQn+dgzr/IHr2XHQv6UDzo6qG1jDqNycZSemp2DHv 6jtuULOWKQ8pLkRacrN+Ljdk+8+DOmOOtlFYIEsvU59Rd2frTwjWSIZG+KaaLLdS s6XGhJkIueQsP6TcAo5YTscbBazCprdQoHqt7TPCKTz7zjKb0lf3d4NzKFGFT9EZ 52Fn4HdOpbvgxOZw2Tcybe7jGiTQgf0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZAhuykMQDo7OfUolC KyLtBDhoGoSI2xJkVHFue5tGrU=; b=cGqitz9gi/w82rLOq0ixO0eDm5szCmcbu D5dH7GLAwv1JWdNjuc8fl5k0Rie7BO06M6s1GpQMcwKQk+JmbUXonnJ3Rqbn1HER iN2vtcIwKNpxOv1jXapnT6f/tz317G5t4PYNJ782niRASpofxxviXG0nhZ+o0X6x Q0O3sqbn5Ar3Ybs27NSz0YIhBYnANkJGfr6iDKVW4yc9ErPk1aZoSJ+8ox5t1fE1 AHH3v63Z2sxtvE2gar2JFAO25dmV5dDmTBvTn5Qt+LBQGOFGSg2j36P7rcBRQmIv Pa4npVRucLlqBioD0EgJp3UnghH16B1REG66fqdtNEM5gjv5ldOKQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeehgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Feb 2022 21:23:23 -0500 (EST) Date: Wed, 16 Feb 2022 11:23:17 +0900 From: Michael Paquier To: Andres Freund Cc: Tom Lane , Justin Pryzby , Christoph Berg , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc Message-ID: References: <2023925.1644591595@sss.pgh.pa.us> <20220211153549.GE31460@telsasoft.com> <2027230.1644594087@sss.pgh.pa.us> <20220211172929.GF31460@telsasoft.com> <2079693.1644600871@sss.pgh.pa.us> <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CoH/1xJURIwWKMFB" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --CoH/1xJURIwWKMFB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 14, 2022 at 02:11:37PM +0900, Michael Paquier wrote: > A run through the CI shows that this is working, and it also works > with Debian's patch for the config data. I still tend to prefer the > readability of a TAP test over the main regression test suite for this > facility. Hearing nothing, I have looked once again at this stuff and tested it with what Debian was doing. And that looks to work fine for everything we care about, so applied with the use of a relative path to find postgresql.conf.sample in the source tree. -- Michael --CoH/1xJURIwWKMFB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIMYBUACgkQnvQgOdby QH3WbA/8Db0lPwpu/HQTpnS/1qPUGtZ3dV58h/ScErtw1IGT4KydnCG7ovPHQXkS LvsgiA4+IYfw1a8i1zLUKquaMSMZaXWOfEmUWn+/pbX120k/75ezFTewr2cFT44c 5vT4ktBYq+0u+5jgj0e3Yl92uMypXdtbOAgnncHWwupUXnvn0YQFdQ4v8XmzsiNR X2W8St+9edil8gSyrG1RKHffd8dsTlSPDYKJZSMbONES3hwVnyct6KqKglvo+733 o9ht/S58ngvSnV3nq0GtLlGfzOC90/2Qc9QDH7xOnqONmjGRw34cm1oO0+7Cn+Eh oCcdIa9U6wcx7Ah4uEjFUHbdItbqBP3oV4375Qm5k+iu9LfI5JX9BwrwL639lipe onFxUOBEhYfz/DNiE5ESiqA1jN04pig1IzPdgA0E75mhojc8zpI6dIbf05ykV6WU hDwdSjkwlvBU+gw5nW35JKirZr0WE8uxEtr/5KkM35HX9D4hrVfpa3XoLEdlR3Ps VrWXWTl9+QfXC5i9lM+HEhii05OCTW5pA/AhIqIRhElK3L0VYI8Ntf2X5+YVzdWi ax/VFkWd+ozGSIl/M3vaLatSsJ5nST/jZZ0L1e9SAPK+EThloAV2aeBOnMcxRo6h vYC3YSZO1caIJVA/TGTJxHNM+hYcDH4mQDfzHuQJ61DMsRn2jSk= =mUF5 -----END PGP SIGNATURE----- --CoH/1xJURIwWKMFB--