Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKJaF-0008Jx-6T for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Feb 2022 12:38:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nKJaE-0006fC-3M for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Feb 2022 12:38:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKJaD-0006f2-QA for pgsql-hackers@lists.postgresql.org; Wed, 16 Feb 2022 12:38:57 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKJaB-0006ul-5s for pgsql-hackers@lists.postgresql.org; Wed, 16 Feb 2022 12:38:56 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1477:7740:fa78:7e66:89f3:5d9e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4JzHZN08srz3DwT; Wed, 16 Feb 2022 13:38:51 +0100 (CET) Date: Wed, 16 Feb 2022 13:38:51 +0100 From: Christoph Berg To: Michael Paquier Cc: Andres Freund , Tom Lane , Justin Pryzby , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc Message-ID: References: <2023925.1644591595@sss.pgh.pa.us> <20220211153549.GE31460@telsasoft.com> <2027230.1644594087@sss.pgh.pa.us> <20220211172929.GF31460@telsasoft.com> <2079693.1644600871@sss.pgh.pa.us> <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Michael Paquier > Hearing nothing, I have looked once again at this stuff and tested it > with what Debian was doing. And that looks to work fine for > everything we care about, so applied with the use of a relative path > to find postgresql.conf.sample in the source tree. The build works with the "Add TAP test to automate the equivalent of check_guc, take two" commit. Thanks! (Tests are still failing for https://www.postgresql.org/message-id/YgjwrkEvNEqoz4Vm%40msg.df7cb.de though) Christoph