Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUQ5S-0005gU-BM for pgsql-committers@arkaria.postgresql.org; Wed, 16 Mar 2022 09:36:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUQ5R-0007ly-7P for pgsql-committers@arkaria.postgresql.org; Wed, 16 Mar 2022 09:36:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUQ5Q-0007lp-5n for pgsql-committers@lists.postgresql.org; Wed, 16 Mar 2022 09:36:57 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUQ5K-0007m5-SS for pgsql-committers@lists.postgresql.org; Wed, 16 Mar 2022 09:36:55 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DA0B15C0135; Wed, 16 Mar 2022 05:36:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 16 Mar 2022 05:36:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=bxR/35zDzce+FLCNXMPf5051BvSsb19CnmJKAr e15IE=; b=ICn1vpb9ZZeR1wWf+m4OM8DN2P/Z/wYMmPUW304vuHE1DJ7r0Jwmhs krRmWQoVjRIhqit8yRIish9SQSY/OiGpC6whWrIFuxcDj1YobaXt8p3GPDE1hpOL 3kErV+MC8wY8+zxU3N25Kt41n1uYXulHg30MhtP0sPTsL7vIh03q5BaZjAT9wj/8 DWLNtSv1y87/TaEbmjG9NLOqAuRXzMoyQQcPaa7b+vyByMb35PUVxvFr27OPz9Op VohXsrJ0//fkDGVJWfbTc+pIfjE2bSN4QTveIO0oeDp48i/KlGX1eAdnFsxJ/Fm0 KuuKjAaOUIfexH1KILKylG+pik4ilJXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=bxR/35zDzce+FLCNX MPf5051BvSsb19CnmJKAre15IE=; b=Ivm+K7SxtWSD0nqDUd71t2HK8sYF45lpP hvEB8hcHRDxD9cNrJmEomNNCFuVOuY22iTGepy+GOxsyGGFOhvtZZAFrzMARmmhh ozesMuM3hpV++EzWZwOQmoZRfQfFDcIkEzfIpPQCMzkp/QnZWApubSLcaSfEtZSY sRNbyKQPFgamVFlKI08eOwH23uB1sHxlmOHe/AfeTRiZ0YOYPUqVoSnkYDVFJEHz 5YjZ59rPCFJlpRy4a+QkmBJ3fM9K05AKYx4otLD5ZaffJtR4LPVsMFdZxVPoWW8P dDOC6BTdXUbEJb8USIbkDw/PYeDc+ShAyrMLp33zd5tLc8uV7SgRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefvddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Mar 2022 05:36:46 -0400 (EDT) Date: Wed, 16 Mar 2022 18:36:43 +0900 From: Michael Paquier To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow extensions to add new backup targets. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lf6ZuseZsppoPHZm" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --lf6ZuseZsppoPHZm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robert, On Tue, Mar 15, 2022 at 05:33:12PM +0000, Robert Haas wrote: > Allow extensions to add new backup targets. >=20 > Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc allowed for base backup > targets, meaning that we could do something with the backup other than > send it to the client, but all of those targets had to be baked in to > the core code. This commit makes it possible for extensions to define > additional backup targets. I have noticed that this commit produces a warning when building with MSVC, as of the end of BaseBackupGetTargetHandle() when the target cannot be found. I guess that you'd better add a fake return NULL to keep such compilers quiet about that, like that: +++ b/src/backend/replication/basebackup_target.c @@ -144,6 +144,9 @@ BaseBackupGetTargetHandle(char *target, char *target_de= tail) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("unrecognized target: \"%s\"", target))); + + /* keep compiler quiet */ + return NULL; } Thanks, -- Michael --lf6ZuseZsppoPHZm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIxr6sACgkQnvQgOdby QH2dFg//S3frHCz/v3Ot34pRl++AIeIROBqVq95y9lgXC6idWjZ6SLetaKuJE5/2 PMMEpxXcrNWWpJNY2mTBa/cwIqPeJBECoHycDW7p19nxCcdCM+yKHRqK+8uit97z oNFidRz0K86oGJyK1geedqlEsomY7ZcHX2PWbeoLHs+r27Piq264H+tqt9QefDMT k0Vbg2N9jI+xtscRlCBFiyUoXTZsxt63LsDZ8PspyoORXjMoO4ieTXZna4wEi6t1 lRevhGta2YGoh7fv4Nd3xuE2AYFru3AIlOYIABTPpLDw2GDorS+rTsYAVc2dEcQr 1jyFHbP1w9eaudHkyJsR8aFh2b/7X8jeY1ElGhdzSxHnCNzVQgQeOYcMCsFmaxy2 0rqvZnfRDiwcyt33WRf+l90+iaFT8FVvKx9mUDFvMDfor3a5XZsmz5LH+LjE7K+P V5JNXmp8lA3T0L6kja8IMvxJ/X4lw8GEqwXFp1iw3LW5wtd2synQxGZ6tC/jTREy Uw/cFCpms5QCXrg1NmuXy9Olc9xEa+wn5l/osigcR+YmD0bf/Bg+H7m6rHoFeYyR EDMJPZnnbH6W24fFlaqis1H/hXIwa0Zod5y8Pj2fLVXmly4FMoEIoEgNJFdDmRnE BmwX1gcUnY+QB+1xjMN2yx22PNHQgzWLuj97hlbBqKdaUnYUPMs= =QfQZ -----END PGP SIGNATURE----- --lf6ZuseZsppoPHZm--