Date: Fri, 8 Apr 2022 16:13:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Markus Wanner <markus.wanner@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if
 TRUNCATE overlaps a checkpoint.]
Message-ID: <Yk/gq9osXcNDoFM2@paquier.xyz>
References: <E1nXTCX-001DGF-R0@gemulon.postgresql.org>
 <a7880f4d-1d74-582a-ada7-dad168d046d1@enterprisedb.com>
 <CA+TgmoaVwQj_nG-jPB8O=t8=h-QBoF2U+tKviv8BT8unfTEZiw@mail.gmail.com>
 <2358496.1649168259@sss.pgh.pa.us>
 <CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
 <Yk94Hvnrx1V00skb@paquier.xyz>
 <3535855.1649375539@sss.pgh.pa.us>
 <CA+TgmoZL_wsAEgzNx6P+zdC937ojede58Sn8OieXMmqV0khTSA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HOBr+0Q6sB4P3WFP"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoZL_wsAEgzNx6P+zdC937ojede58Sn8OieXMmqV0khTSA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Yk/gq9osXcNDoFM2%40paquier.xyz>
Precedence: bulk


--HOBr+0Q6sB4P3WFP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 07, 2022 at 10:19:35PM -0400, Robert Haas wrote:
> Yeah, that's exactly why I didn't do what Michael proposes. If we're
> going to go to this trouble to avoid changing the layout of a PGPROC,
> we must be doing that on the theory that extension code cares about
> delayChkpt. And if that is so, it seems reasonable to suppose that it
> might also want to call the associated functions.

Compatibility does not strike me as a problem with two static inline=20
functions used as wrappers of their common logic.

> Honestly, I wouldn't have thought that this mattered, because I
> wouldn't have guessed that any non-core code cared about delayChkpt.
> But I would have been wrong.

That's a minor point.  If you wish to keep this code as you are
proposing, that's fine as well by me.
--
Michael

--HOBr+0Q6sB4P3WFP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJP4KsACgkQnvQgOdby
QH05TA/9EoFsvg3tapiMnBdJOHI4EItazrXqEqBlD9dTMon80P4FwSNIwV74S7RU
b0XmIcZuAiCzHRC0KgWyfpjAS8Cozc7ONQf0N+ntekiZChB4AeRio82Q+Ynsu1Nk
rOrhwjPVAUs/19hrOEMfkgZZfs2iP+QFIdS9WHGQ89cDaUi1X0Uuvc/ZvAmORTcC
ClHqXPeztteMT5+nY4FxxsqkmqmALYe5bEjzRCRQ+I4jZup0GqGzSvdv8Z3ik+Nk
HgXxS4Z9Egx5QvJCtm6+1LXUTxQci7TXl+NvnQosA4q8ctPM6iqQxDQ2HMbL8RBq
o957Rf69qBdLtQ4CrBHVvKEP7QxCq13pGmfZo6IBSr8vRp+QYQH/rJJ+Kc3fSIAR
w4XpDzMRjURjc9izaHHZMYrlHEd0sxkMvWzE3BS3vKvPalmdS902KbFIymV3cTXM
h0IXipW+hpocdsvDgnvOwdikPI4xsRbJDZXBhetHOuJcJeE3CU2G+i0B092qiHdU
ICY/RMLlMPKYdx0OA8E63CR8kvi/t2h02NTNwNjNGfuYvKPimmI7QxwXOTs21Kdw
/x/A/I0n8PdPHTTDHUF564IWZvhVC4apbPNMzaktIx1qyLBFHKKZch+Bpug2RhVR
1MM3QWanFoVm1D+CZ2uOo8sbHMmaxiDAkWpBcbMNtNf/uM30EzA=
=rHdG
-----END PGP SIGNATURE-----

--HOBr+0Q6sB4P3WFP--