Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncFXV-0001iB-0b for pgsql-committers@arkaria.postgresql.org; Wed, 06 Apr 2022 23:58:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncFXT-0000ab-N1 for pgsql-committers@arkaria.postgresql.org; Wed, 06 Apr 2022 23:58:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncFXT-0000aS-FQ for pgsql-committers@lists.postgresql.org; Wed, 06 Apr 2022 23:58:15 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncFXR-00039y-Hs for pgsql-committers@lists.postgresql.org; Wed, 06 Apr 2022 23:58:15 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D08D75C0221; Wed, 6 Apr 2022 19:58:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 06 Apr 2022 19:58:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=rzXsNKsfKLpg6zayQk9/bA0dB8KHH7W6ZOgcRx JhbfY=; b=ZsP4VVq+PosjjbregmvMt2WQVr+LXhlXsqCy7N1fLtxafRYMc1m/n8 iLBhGATIAhdkRKKU/KVS6+l2JfJmbvbbK9XbKKYrXThMC3GExY4SKNlR6EKXc93R W14JP/nOZOebzPoXuqUUgMLEUQZiascJ+UdvbMt/aqpgH+HLigmfDg99m0Xx4VYu W/NkymHkYlUq/4AUnMtJK4M9fNMHt11e1x/efwyAFYJ3OND2ZVNlKy3oUiyL6K22 QNdHXdcuN6oyfJjvgRobruSuzX6R4vPS0WCd2L409fkk1KztS5MFC+nIJXpxGd+5 S40IrJ2ME6hcGWtq/hz800KZ424c6PUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rzXsNKsfKLpg6zayQ k9/bA0dB8KHH7W6ZOgcRxJhbfY=; b=EpnwUAG3UVGsIHMUgR3uL+7iYcbH6qs/I hjmKqOvP1o1kENx96AVMA2rQYgyKgNBkLbMWl6kaAqUPI3eH8Dn156k1j8hwqgud EgQ0qWao7MOpA3yA8h7lRe3jb+6sNMGPrH3q9BLx86a8HxE7StcYIU1IlX/5uOsI jh16VDtu5cUtII5pCAdi7bhxuV1ymbvhUDrLNMAZvFT0jNPKxF6cFaRPd2Y3YHAG xAry+oCWJ5+6UwTx20oisVv8xVNFVMwu022tzgq8f2zHRJRvWX9F5Fqv9Gmbsy9H dDDjfC7F5YUZXov8o40TBhl+bWAZiYdD6xab5wER2zzusdlFaCqpQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejjedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Apr 2022 19:58:10 -0400 (EDT) Date: Thu, 7 Apr 2022 08:58:08 +0900 From: Michael Paquier To: Andres Freund Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgstat: add pgstat_copy_relation_stats(). Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aI0Hd8Z0A+rg9a9d" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --aI0Hd8Z0A+rg9a9d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 06, 2022 at 09:35:17PM +0000, Andres Freund wrote: > pgstat: add pgstat_copy_relation_stats(). >=20 > Until now index_concurrently_swap() directly modified pgstat internal > datastructures. That will break with the introduction of shared memory > statistics and seems off architecturally. >=20 > This is done separately from the - quite large - shared memory statistics > patch to make review easier. Thanks for this one. This new routine makes sense. -- Michael --aI0Hd8Z0A+rg9a9d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJOKRAACgkQnvQgOdby QH2VVg/9GsEEkmuIk49hccivbVIM9MhXXk5SS2oza4B63mNZbYs4nc7FSc4XTEER 0y8rsPYtU6t87u7O7ss8lxbTDX5ZFikN8kNcG/K196PP8pauXvEoEzUPVuBhy42K MhkPk4NyXge2FxsJH1Vu0ewIPlGLk1n7md0bNiPFaZo67oBLjvu2UhPGo/T7kCuc OZbCsvPL5GpDhOD9YMh2+e7wZs1Qt9434P6ZnTOhGw8C7VKnS79TNVGq82xnCtYJ TdOTXWEhMVe1uRuBPUYKK6hBgupNe/fd/l2I1f7sJCeYYoizJP0Xn8Z6cIgFof5u ogD8IiSG2tqhv5VuYgSxgHjlDWI31/vx2HMN7l83LcsHqmf931XzdIe7F7OtpVyt Y0dk8Vf4lvQXAClPzrW6494k0a5KEIwQDH2vAfj5dw30SBEo39ghWxOuNi7CvhRU ETNewkvzcSqRv2SVKGF0aDHgjWNk6CttTHNwhwIBiYAxECMJ1J/wRS7SMS5r8dU8 XoS6HDQlMNulcWdtf2tY4BR0jijAJnjCGAYNzp0MKGtwxF80PWcP+Q1bBHDX9OjU 6oxo++6fThfQI1RHYlmmwSHpbYg+zQ+WQR/1wE5wjdzDiwhevgMMW8BgB0GihcnZ dof6E+LMs96mRiHhDnhFPs+jWyANfxb4br/1+OzAj1tndwpH+KY= =w+YD -----END PGP SIGNATURE----- --aI0Hd8Z0A+rg9a9d--