Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncLKs-0006ip-Hi for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 06:09:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncLKq-0003pA-T2 for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 06:09:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncLKq-0003p1-La for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 06:09:36 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncLKm-0006CT-NG for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 06:09:36 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7104A5C024A; Thu, 7 Apr 2022 02:09:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Apr 2022 02:09:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=o9X8iWUR5zYySRXF5dLn6+aOPtfws6SAsvWVXl kMSZw=; b=KNPU0njAyIsdVa9bR4JFS7Qnhc7QMitBQnNLc+XSVlSkA/4LE1pVJh 8YOAqRUhB2DYb3ssGjNpQLeOjrPm/nRZ+g68BmoZ0J4SF1ymw7mEXY6T4ynFR68J kUIVQyE/XpVWMGNkMz48Gsyxcx0L36ttZo7M7L1Bp+bbAIXtxvdjbS3wbydCSI/u eETwAVGgA3ryFueTB5tGO6DM0pJ0Js2J4fIrI/2UTwRpGRGr8cb8/B6fl97osI4H rNjRrA4zu4l0fcIBbAgT4jnIs2t0/KocGWYRoZNZfTgvgvUMI/XolOWylF4aAOMx 6RGnGtqEhELBbpKdqCB7FubZF1baBx0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=o9X8iWUR5zYySRXF5 dLn6+aOPtfws6SAsvWVXlkMSZw=; b=AvEXx5TxDhDmzrQIayw3VtEunNZze28Uv Bb+gOzU6rSJFdNkwPPyxROagBEOVrtUXbmQSIGmehQkzT9/1Wbpl34x2hZBQlz+e DVaPs0M4N3QB/25hNpWzssBTITxOnS3PbxS6d/PwlVLgBTGOwPxZAG0vbgJpQluD HwZBSzgD1levRhK1J/NnTU/uD64RJfclsAORoTYBC0RXDXZI1F9Bsf0EznoRQiG1 nz6CjmWU3RjQNrLKDJhEAto/yQPF4CA6IYBRGwqcVeWutaOgTMazCIqPvxZUItBk PYMOX1piz0ozsiRDwkqYQ5XBX5yRJ7JepxFuQuH6wlZJTXJE6QzHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejjedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepffdufeeflefghfekudekkeev vddugfeiteekkeduleefvefhhffftdduffeiuedtnecuffhomhgrihhnpehpohhsthhgrh gvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 02:09:29 -0400 (EDT) Date: Thu, 7 Apr 2022 15:09:27 +0900 From: Michael Paquier To: Andres Freund Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgstat: store statistics in shared memory. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VkTUfTXwXXn8qr4r" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --VkTUfTXwXXn8qr4r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 07, 2022 at 04:37:02AM +0000, Andres Freund wrote: > pgstat: store statistics in shared memory. >=20 > Previously the statistics collector received statistics updates via UDP a= nd > shared statistics data by writing them out to temporary files regularly. = These > files can reach tens of megabytes and are written out up to twice a > second. This has repeatedly prevented us from adding additional useful > statistics. rorqual, that uses --disable-spinlocks and --disable-atomics, is unhappy after this commit: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Drorqual&dt=3D2022= -04-07%2005%3A47%3A03 test_decoding is the one complaining here, and I can reproduce the issue locally once I build the code with those switches. -- Michael --VkTUfTXwXXn8qr4r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJOgBcACgkQnvQgOdby QH24Ug/+IAtyrnByZu497E2wOCSArRyIup3E2O2PyizQBysSWnvYIUWeXcY0ydkK IxRMMAnvOIrD28ugA8Z4CnJ3S9WmiV+LMIdfeCwehiFf5tqkFCilR26qO9U07qNJ ZjQ/HURnq6UIGUFNu6GSbTGGZ5bDczmi0BWM8i5YClv/5Ua39Toaqs3xHzrYDFK+ NDhDuTKeuVtghYND90fkjMjXAuIw6IealilT865Kv7oUwKmKzT91Yx/35hiTnHWe ixWKAbawBIStyY0FiQ+w7aSFaqEWoxZJIAXz+d9ZGpaOAKMe0cx3rs6tRN8Xr7h8 NhTmkGZ7LGpSeGXhbjsGM8+1iPv6iaS9vHT0kmCYJHpmydT6fyJIqSFQXKrXyOfg cdqakBnPypVCoiznluqGQjPUkXpo6JkZSl38sG7ArPsj2Va9GUc+nNHA0yxUJZCW UdObM0xylUi7bgEPcaHqWmz/YdyS9OjazQjwayJFvbIHWSw0osu3sj/LaLW06q7Z 8oXxcUPPdL0wpwzzmK+AaFSwZ6AYDwgKqXXhIiMdIYFkAVog9QiSu4HvuitiZgyU sfzjrKj63mVYJCVNaOVyv1pAHSgFvyY0N0VzCEUD1jn7PYSbgDCpIIUBVG+d4Po1 CrdMc2qmRfSAxFr9H9GXORJIpSwGaxS13002iuHetDHixWHKlEI= =rpHI -----END PGP SIGNATURE----- --VkTUfTXwXXn8qr4r--