Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncbqz-0004pM-7z for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 23:47:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncbqy-0004Sv-2i for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 23:47:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncbqx-0004LW-5Q for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 23:47:51 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncbqu-0003sW-MO for pgsql-hackers@postgresql.org; Thu, 07 Apr 2022 23:47:50 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9ABFD5C01BF; Thu, 7 Apr 2022 19:47:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Apr 2022 19:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=BvLXzoZ5WDoJ73xhFpvaMDmssyJWm5TAVO72hC gLUbU=; b=JRcacv39aUBd87vjrb9+46NuHFiICHDPIOFLD2FMiMXg3SCz37i3on 55VAbvKc5p//CXdVeNMFQFL9HhEVRIDYRwrqSoxP7XQJDvWxsI2mlANeI5HCBVwG /e3Iog1Y3t+pthClS7bbPoyRwo3Q//TerXanI6gdoggLBXfWYD/E1jGuA6aSraLs tNgrYKRmf+0IYzvV6WYuWbuiv2b5VXoiJVQGwKABJJiUYXsGw1rkMYSozIDOL7i/ HvKQGp3pe20oZqcBzxE+bd3JlodQosOxu2EHRXL514ZXPUcH8x+RNEMYnk+tuvbV IBXK8RkHZoIHeIW6VZatgIeYIK94Z/vg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=BvLXzoZ5WDoJ73xhF pvaMDmssyJWm5TAVO72hCgLUbU=; b=dr4ApOQBLMFlWBHQWt9sVS9cPT+Sl9Kbe hW2/+X0GzaXAICYX/CqUW6yLT4C5cJPdZzrbtc6uRppS6Orr1lqCVe3XPkhhZKZP sCwJd8vwhNYpq4ZdoNY6SLF5QZIVjbWPUmzs74wLH4OtIaJwyzSaccFSmiq0FV3N wAjSXfbgcN7ub3dWU8s43fI3mRKlzWAP3T+1nxeBjKR42t29XgO5yQ6Bk4ocm3xS bSVDpLY+Yl0z3p+DNvmhvmoNgPxJBd2dl0vn1YlSfLXey6CPSZWu9gQXYvyzJ8gN izK6OhoNmbgrqWq+1qtnPFpuJOs1TXjBwJGF7uCRzhkYSfbgGoeYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejledgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 19:47:45 -0400 (EDT) Date: Fri, 8 Apr 2022 08:47:42 +0900 From: Michael Paquier To: Robert Haas Cc: Tom Lane , Markus Wanner , "pgsql-hackers@postgresql.org" , Kyotaro Horiguchi Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.] Message-ID: References: <2358496.1649168259@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BDdFVtMACkVbiEHI" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --BDdFVtMACkVbiEHI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote: > Here are patches for master and v14 to do things this way. Comments? Thanks for the patches. They look correct. For ~14, I'd rather avoid the code duplication done by GetVirtualXIDsDelayingChkptEnd() and HaveVirtualXIDsDelayingChkpt() that could be avoided with an extra bool argument to the existing routine. The same kind of duplication happens with GetVirtualXIDsDelayingChkpt() and GetVirtualXIDsDelayingChkptEnd(). -- Michael --BDdFVtMACkVbiEHI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJPeB4ACgkQnvQgOdby QH2BCg/+MAdIBCtwYPlL8Rr0TtzAVqwR5R/JGblaemwhdRJeJAFNFUhLgulLaSJW JHP2SCo8al2cAb/Fk/US0YQmRC6xTm9/Q/b+eikNTRi1D8+icSpKPBFgaEL/h7ux qH3La078eInHgP3/yoqTsCWOuXASGZgbJQtzh1hPnwnnW7RQ+L9crn32Is1074Cz nc84pxkcLylCD6b2hNpJhTMD8t/rMwi9rLoimj/V9GFxCDtbGhGqmusXI2FBJjFm IPVSlnqnRPH2dxUqKEWSvUEHJii1FgfpzOaVHV5f+EPoclCoSgzsdSqX7pZ/jZ+y h/ZefnLCye8AKFzLFTG7aeB7pl79WexFwN+gB+sJTGFIk9OheTd3wb71sOP2gnZy S2sPmy5WH0az7wq/yAeQXkR6rQ5TyGQrdhRPezjLn0+4mHNw+znaa/aiPw46kW/C R3a9HRyjPakpAVzUPiD1j7WGSQzqvCorP0AUX6f3wgqeUJ17wjnYS/nZ30ycif0v VKcm9elWxsNnerXNp5rCr/uzznGjq+ZubAvoN/uRdA54kCxDZFDKaT71Z4jZanuv 0DXvGeCzYd80JNKGQfU7opp9PlliW650bJ2VGOVQkBX43K2as08g5kpY0/35AtyO L4Wx2IpjGdqwjTcCWSb3YoSk3yAxV/9LZjnLOrYoOS99816BICs= =nOzN -----END PGP SIGNATURE----- --BDdFVtMACkVbiEHI--