Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlQ8x-0006Y5-E6 for pgsql-committers@arkaria.postgresql.org; Mon, 02 May 2022 07:06:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQ8w-000406-8v for pgsql-committers@arkaria.postgresql.org; Mon, 02 May 2022 07:06:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlQ8w-0003zx-1G for pgsql-committers@lists.postgresql.org; Mon, 02 May 2022 07:06:50 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlQ8u-0004Rx-54 for pgsql-committers@lists.postgresql.org; Mon, 02 May 2022 07:06:49 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0FF963200063; Mon, 2 May 2022 03:06:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 02 May 2022 03:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651475205; x=1651561605; bh=MZbZju34Cn zhGlczeTG+o4wmSsAaJZQ3+i5E33f8T3U=; b=ilhGUcsB7UlkxBlMPwFGU6xISi pFgl+Tgm5KxoHgBGFgazatB2zPoNIlvEJLSlZXvhji1HBfXnyxwLqY3A6XgZhpzP 9tBPNRjDhpphwLrxE7r3q6gBOoJv7QkY4i44zL2+qviMDn4mGpaLNcZPKW3jzwKG SQeGAaJggquWYE9ALnE+e8mgyED8qjyfD2y2QePFy1Sndta+jaJxEH492Sq2YkMZ KKQ9QdCYvAqISjZqP4Zx6kzo86iVRvKaDsHBFrLDIePa2XeGllmuinktqIqhyqJO Q9PZmqOH8u3LudSecCd5h/M+xD0I9f3J+vRGET9z6q5RR+FeiJNf4hFQQTng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651475205; x= 1651561605; bh=MZbZju34CnzhGlczeTG+o4wmSsAaJZQ3+i5E33f8T3U=; b=V o3nCZnbDLirJS/whDI8dMJtx4dRnMj+bj8/vKhnfqpKbQhuW++CYLGNnGtsRtwD8 iyY36X3wDqxt0EWuy2LdB0tTnyUSb7Dv91aBm11Pi3GdCUFLCtvu6sEFG5qgj4x5 SM6DBl7tLRgp06dtOxURjeqHLAKVXtvsnjAUjR1KC1S+5SlmtRprza6jVrv0/2CH 4HV76yBz5PYmjC8KkvpZdK13QTAyVjewTISWZbAOszoOQ42+rjrn9di+yk76nsnr 2AC9hjMs2noVhvUoSBbO2VeSSTG+04mZd0t6vo+NuVvuCE8iZgejvhLwlot60gxH Ay/2LKocj4swJH6KRKRdQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeggdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 May 2022 03:06:44 -0400 (EDT) Date: Mon, 2 May 2022 16:06:41 +0900 From: Michael Paquier To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Message-ID: References: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wtOCZMwk6PV4zvi1" Content-Disposition: inline In-Reply-To: <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --wtOCZMwk6PV4zvi1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote: > IIRC we know that tar will be available on Windows. What about gzip? Are the binaries and the libraries split into different packages for this package manager on Windows? We've never assumed that this is possible on ./configure, but it would make sense to make MSVC able to manage this case. > I don't think we should do that check for every time we call > vc_regress.pl, that seems wasteful. Maybe do it if the command is one > that might require these commands, which I think would be bincheck or > taptest. And/Or stash some status somewhere? Mostly. We also care about gzip in contrib/basebackup_to_shell/, though contribcheck does not run the TAP tests of contrib/ modules. As you say, setting up those variables in bincheck and taptest would be enough. -- Michael --wtOCZMwk6PV4zvi1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJvgwEACgkQnvQgOdby QH2uuxAAkXRKuwzFdUongfg8T4AJAtmS3VWEIMHvRe6tILxSvMF1892cCn8f+bUk hQIwtfQPIyV4im7shxfEeR00hMd+fahOmwr75reG51CN26zpHX70PvDh30bSOIFZ 50CBZR+ibjsOwKAfVNF9AFCtNGofNCug3lcp+j+7evsQ3TDQYGRGiCXPA3MA7PFs pRa78Q31QrZzHXFEcpwTwfFKNsQU6JNgjUs7MqfJGJ//TtxKN2HVG88j2u2r2+Jc ok03JA6Ib/I54WaL3FnEs/TbHaI5GzEMlcXjaLSzy+p2nZBzBRdmk7WxjH8UfgTg xeb7QEuwxoj8iDz6tnuKzTqpubTO7n2/F9aVdVbpUZFyUTIt/R8XME5n4vVtfZsy qQzOEDTlLyG0yzv6s6Fip/OhG/OLGVwmW/Iest91AUAvv99w4IV5BN/Cpp4yoNNV arR6ScCB/CtWemvPsyw1fXmjgjdoGcuPQT0/Pckrw+zQiYyuEfQfQmiQQFivlcRD QVy+DHz1il8vCwqViiMjhRVztOrgBXvjbzxtkCzxndnLpRXLZ+P7m3Vvpf/Spi4K Wq0cary6yVyozS8FmHrA8zr7aH9+LJG5e+7qi5nIGTUkjcvVucdm1xwHutcg9tY5 Iy1GbL/gtBrdNzRQtG8nMdnhj35FQv2KOc4zqQoBG6mGzdi2Z7I= =pafR -----END PGP SIGNATURE----- --wtOCZMwk6PV4zvi1--