Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl9QY-0002dw-G9 for pgsql-committers@arkaria.postgresql.org; Sun, 01 May 2022 13:15:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nl9QX-0001qR-B6 for pgsql-committers@arkaria.postgresql.org; Sun, 01 May 2022 13:15:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl9QX-0001qI-3J for pgsql-committers@lists.postgresql.org; Sun, 01 May 2022 13:15:53 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl9QV-0004Rq-4h for pgsql-committers@lists.postgresql.org; Sun, 01 May 2022 13:15:52 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 97F425C009F; Sun, 1 May 2022 09:15:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 01 May 2022 09:15:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651410950; x=1651497350; bh=z6m2EjIEal QvLT/Es23+EUz15w1TxMCKet8s8kPUAfk=; b=fEtl1BcPAs2kwabdNhYkxZrVv9 AeMMNgIOJh/ZO/V+OWqqWKQGJ1/YieAC6GSRWJHEqHdggOXOGuYlpXpq/QTobOzH I+FlRZ7TPixYc0CsBdQpaq1qVZsyVpNqjEgbIB7XsViBFzlsRSrJO0a8/3SlSkBQ aRCGp23FNU4FCvHMJmISJgm22p844NgEWIgU5AQfYzzSs7O4D+MLMnLj/VuBxlQd j/Ba/rh2tw+1NTl1b9F/BVIc4IrkBehODd4TzYxJ/I1EOMg4DFYNO7md+gTbOYmR hWR9ay5lUT/zgiqlontA4jfszwP4NOKbh97DzXdpcZTwRHjo820KU6MBYXqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651410950; x= 1651497350; bh=z6m2EjIEalQvLT/Es23+EUz15w1TxMCKet8s8kPUAfk=; b=B th105i4J4AIxiTjbd5lbGI38Ts4AWYvedGyz9JHk1brnHZHorYcypZJPEShcxZpg orA+OGx7+axH1xACOwkiQPRLgBWFJwaOOj0V/1WhsuHmAP2pWu147QleLFBX0VE2 ynYject8Hg9aBByqR11g4ILLfvhNhHK1EPe3/rbedQ92Wwm8zhD/TrRwMn4f+KbF JtTRy+lrUEQFw0Soq+iLux873bLO7Y1LNqVlfKsyKwRqQvmeAd9ifhxX6aPEVJWZ 3kxRl57dffB0CShSlKbo0KJ3EQdl42hWhgBqcKnEqr4WuDCtDqeAUSHbDVnNOZQn QKP4tDKAcRDNiO8r7p2Eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdefgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 May 2022 09:15:49 -0400 (EDT) Date: Sun, 1 May 2022 22:15:46 +0900 From: Michael Paquier To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Message-ID: References: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kA1pT9oIXnOzIoHg" Content-Disposition: inline In-Reply-To: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --kA1pT9oIXnOzIoHg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Apr 30, 2022 at 04:52:54PM -0400, Andrew Dunstan wrote: > This appears to have been misconceived, at least in the case of MSVC > builds, as I have just discovered. It is entirely possible to have the > lz4 libraries installed and build with them but not have the .exe, and > unlike the configure case the MSVC build system doesn't conduct any test > for it, resulting in a nasty looking TAP test failure. I assume similar > failures are possible with zstd and maybe gzip. Okay, we could change the code of vcregress.pl so as the different ENV commands (tar, zstd, lz4 or gzip) are assigned as follows for the sake of the tests: - If a ENV value is available, trust the environment/user and rely on it. - If a ENV value is not available, try to look for it in the environment by launching a simple $command --version (-version should be fine across all the commands currently in need of coverage?). -- On failure, set ENV{command} to an empty string. -- On success, set ENV{command} = "$command" Does something like this look better to you? -- Michael --kA1pT9oIXnOzIoHg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJuiAIACgkQnvQgOdby QH3qnQ//ejYiSweiThjG4x9txUyYWU7oeaLxlecN7opvBhuR6XZjeREw6wBmEnwo ghwtrWKDRTFozL2GrEuI4IaxmPCLDcrPt8euf3K3WiLA2aFsgNRP9259OZYc7UnJ Hj1uuj6MGlVOVzLrmptB5CsQRvgzPjc1RWaLTOox9Yd7pPL1Q+V41iGqfIgkBWdE oIEHUeIPNzWFGziAfd3moaX1exAIhjAh1XBl5m3zX4hrhMwkIDbpUPdaHprtUbgx c9alO3tkDMoaikKbQ+JyCFmpqRLNeLvqeGjJmwWk2oeq0vDF7oEI2IJhTmRDf+b8 GXZ7K1hIxsJ6QW2dxnKcWmm2jmjexveLEEiggtkkC3JzaIME3Iip+gz9Ta9GZ+Ee wkiWj5gYC13eij8ZR2Y8rXWZvmD8bfdkK/Ewr0E1D5VV0n+8GRlNhY+CzcVLOD0s apxdK8AS0M9w0RuTb8mIz2VQfiI+uRWAoHVpCB3FD8khKv4tE9zDgUHDEtcYij9A iSlyyZWiULVm52VmjmFnXtSDXOg5bNMFI2sWoLI2LJBoSzMzakKu803YBvA+q+J7 sHHy1OKIGT/sgoZqIh9ANyPojdFSmsfnUV6DpNHVSsvs6+BTY0kE2EBdY3aIatkr t9bJAOLruwZivA66Bsnlc8zQQJTXMWkw5AM/gb1NDXeLpBYT/dI= =DjUn -----END PGP SIGNATURE----- --kA1pT9oIXnOzIoHg--