Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njv96-0007KV-0I for pgsql-committers@arkaria.postgresql.org; Thu, 28 Apr 2022 03:48:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1njv93-0004nj-Rk for pgsql-committers@arkaria.postgresql.org; Thu, 28 Apr 2022 03:48:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njv92-0004na-6E for pgsql-committers@lists.postgresql.org; Thu, 28 Apr 2022 03:48:45 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njv8w-000585-OA for pgsql-committers@lists.postgresql.org; Thu, 28 Apr 2022 03:48:43 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D5266320095A; Wed, 27 Apr 2022 23:48:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 27 Apr 2022 23:48:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651117713; x=1651204113; bh=/jdCqH6GSx ywFFeWyZNPLzREQHMhhtW2k1UO1t7+E+Q=; b=PH6UXGdQUt/dfuk1SscDsW2Kv1 i9vZ3EhQCmAeK6fP/NpF4B1/qxE5JB4BDPrANgACROZLBCZAqif1xl67UzynpqQo NzMlcWRx0vbKs4lTzyReeiOCOYH1EUYsKQo9jC8SxTFnF2ncMWEj1FJn8UMNU3sY UZI74dGn4dRwYghGd+CWzyG+EFuVXW/7XXborPG6oQszK4gkN/wlsg6x+Y4LaPx2 YW/EA8pefAAp7vlBmBzIiygbgKj9oBHixcObDb8xR/uRxErO9KW8JqwQCIk9V1KI kfdeZyORcraCMnvEQo7R/rU5H3n6Mn54y+GuLemZsHmDMDKqRPJ3hDEnChqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651117713; x= 1651204113; bh=/jdCqH6GSxywFFeWyZNPLzREQHMhhtW2k1UO1t7+E+Q=; b=W ffyRimM4h+Aqt252iYcWIwIQCN2iuvbp7zvWtkSedo8AQkHh5H4DNsqJ7kqwqwPK NLD4V9aW9K4hN7sdSkpHTW6VhG/5QtWT65EbhrODrg1qKQYNp8DQFbgWHIJXhA2a 7v+JYjLhuS6mXBglJ/oK7+h4Qc/YqsZ84MMaz/0/VifPVWiDyaQOOyjTlzMysun5 h9kvA2L2yOvR1j7KNU+SpfiNlCxq5ODb04bvVGDNFz2awrLMIzgwAXH0xcRD9cm7 yC0HkQ8IL8YE8LlLbeU6MlsJ7RHBgJ7gBWb8XmJSbl8A243aW73UQs0Vjxy9Saag il7Oyve4iQDFC0Q6ZK8og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdefhedmnecujfgurhepfffhvf evuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhu ihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrh hnpeegffejvefgveduvdejtddvtdeijeehudeuledvudeftdfgfeejvdekveekiedvvden ucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdr giihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Apr 2022 23:48:31 -0400 (EDT) Date: Thu, 28 Apr 2022 12:48:27 +0900 From: Michael Paquier To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename Message-ID: References: <511362.1651116498@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lweogSMaBvBhLEVU" Content-Disposition: inline In-Reply-To: <511362.1651116498@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --lweogSMaBvBhLEVU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2022 at 11:28:18PM -0400, Tom Lane wrote: > Assert'ing that an external (filesystem) condition holds seems like a bad > idea. See buildfarm. Yes, I saw the failures: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=kestrel&dt=2022-04-28%2002%3A13%3A27 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-04-28%2002%3A14%3A08 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=calliphoridae&dt=2022-04-28%2002%3A59%3A26 All of them are on 025_stuck_on_old_timeline.pl when the WAL receiver writes a TLI history file when fetching it from a primary, meaning that we need to think harder about this case as we would overwrite an existing TLI file once we use durable_rename() over durable_rename_excl(). I don't want to keep the buildfarm unstable, so I'll revert for now. -- Michael --lweogSMaBvBhLEVU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJqDosACgkQnvQgOdby QH0crw/+PXh9CUWs7tjmB41pHgWv/LaOltrvmQzhLGEt7KsdqnAkA2aNfnJpKjXe PtKx7ewSOXkjGYiQZ2IkxZvCx63Pn+1Qf0Qw0omkFkIB0UMjBuVRQCgOR95RfhV6 UNsH+lX2iZv/4aimcSGYl/aULPD/J3iPS5dOBLMSB413x4LWQTuoIZ+UtKgvUaWA jRJGd04oIuQ92UPoXkIf8Xt/uksv4GMQYK7L4eQtwtykY8cTXHa/t4iASI2Lp9FF K6k+rwrQGpONHTKQypWye7tPqxk1txpaBsaim83xY+cPNLLkKcTXjPJ/3Zah6fWD MXHnyS43GQqEnF4YOduEtzS0UHuC8Gd3MXku7e13AHo7OpNKnBNSEqEN9WG+DyvS uZX6iJvQTyREUAnza0W1iFOaj9TYrqi4Jn0jzTLRXQdu/YIJqr30+iWQajt5ongS j7pXPS9NmP52Pi7ZKnPUpnRXi2QjWAwakRPpU1xaOqU3jcw80pjaeinw52ybbWos CZQWOM35i042dvspdRDUbyUF6sPSjGozXwj2U6S1L2YdWzSTbpNbveWP7HSvsr0m w+SnYG3qEEDjcLkQZQWFN9nrnCP5WYLb8mkc+XZOFns7mwPk1BysSVYkR/yDR5Fv 40xCCMcebihQ82GZIfaVGimnsn04LXzrjmD68TCYKFLZzWdc4gs= =2Cdb -----END PGP SIGNATURE----- --lweogSMaBvBhLEVU--