Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nn85F-0003Ve-B4 for pgsql-committers@arkaria.postgresql.org; Sat, 07 May 2022 00:14:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nn85D-0004V3-53 for pgsql-committers@arkaria.postgresql.org; Sat, 07 May 2022 00:14:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nn85C-0004Uu-UW for pgsql-committers@lists.postgresql.org; Sat, 07 May 2022 00:14:02 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nn85A-00087a-7K for pgsql-committers@lists.postgresql.org; Sat, 07 May 2022 00:14:02 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3FE7E5C01A9; Fri, 6 May 2022 20:13:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 06 May 2022 20:13:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651882438; x=1651968838; bh=kIPM/3MhgF cGpb7UMlm9gJsuocEE9ymbs/oQmLIrFaE=; b=LSTcncvn2HDH6lSo7ov0wZxi8u l+8B/FM2Hhdany+Zjei+LqOvgA47eCrZbWDPC37FP/KF8JjDdv2fXSNaBiqwyu9g ADS4EvVYW+GBxLbVWzG4ddb4q119X3ECx28FCar2UOwbSyOMQKqIrp2AhC2ytfPQ 1gBdoImOfVlGQVSlpolOOXQDqgiaRXi5No9G+xbR23qf31bSDUnRATbnXiIT8hPr jHx+5xX7p5LIYUVp8VMcGyZZq6AG30SWTynBvCy8vLW3VfmHIy4x9tRG6eiSsPFh XtbVKMCwNVWJG9XZYbVSIRM/uf/Q4WK2BSS0G6Ox3nRKFh9wZD/OxFZghvZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651882438; x= 1651968838; bh=kIPM/3MhgFcGpb7UMlm9gJsuocEE9ymbs/oQmLIrFaE=; b=r FuO8dAmYREr85WeGcbF227dgmGEvWSkDwJbYd3H4cFAcUCrd1JiGdh29UTD3iHEm 6PNUeWXe6XiDpsGK/yt3+BfG4OXuGLkt9BmgtgRGwCpM5i4hBShrsnXLxuzJZzlU hC38i9S7qX7fuxoDQhqSwKVZ+169vmerRKsufsbQzDjLIspZdcTDLHlkKEuqvxjH u+2tXGAB7zt7lkQHO9/Ut99s8lQmyQrfOQoOyHJrbEaPMlFGysKpujuphK70d1J5 JwU9RW1KOPIwEbMoYj7shVLOeIPp8inSNIBYSjlIWtxdSVjMF5C64Aar/daUQNqk 4Fo4l8G9ghWBzeEK1Xygw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeggddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 May 2022 20:13:56 -0400 (EDT) Date: Sat, 7 May 2022 09:13:48 +0900 From: Michael Paquier To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Message-ID: References: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net> <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GENgK/C4JPBwxlNO" Content-Disposition: inline In-Reply-To: <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --GENgK/C4JPBwxlNO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 06, 2022 at 10:12:36AM -0400, Andrew Dunstan wrote: > On 2022-05-02 Mo 03:06, Michael Paquier wrote: > vcpkg doesn't install any.exe files AFAICS, just DLLs, headers, .lib > files etc. Okay, thanks for confirming. >>> I don't think we should do that check for every time we call >>> vc_regress.pl, that seems wasteful. Maybe do it if the command is one >>> that might require these commands, which I think would be bincheck or >>> taptest. And/Or stash some status somewhere? >> >> Mostly. We also care about gzip in contrib/basebackup_to_shell/, >> though contribcheck does not run the TAP tests of contrib/ modules. >> As you say, setting up those variables in bincheck and taptest would >> be enough. >=20 > That would be a start. Maybe meson will us get rid of some of this mess .= =2E. Let's do that for now then as we need a middle ground for HEAD. I'll come up with something at the beginning of next week. -- Michael --GENgK/C4JPBwxlNO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJ1ubwACgkQnvQgOdby QH2jCg//WaLCxp0u5EZCMRmPJqvJ1OSjFbsFzkXB4Md19VzLUPOpK+Vm4s7svGO3 Vm4jd2FdvHC84Re7efwfhuzmLQcwVcAONwCFr/BVarccBeK29qHRjQIVDNFtpUsf 3yg52RxZRSQrSRNu7tapQ4EUTUdERUSFUVRPEhfpywDOkWMW9OJpXI7JTdAmqI4j 6/sfX+fmO4XazbEm7jFG+Y8pAtdueAJnvrKauN0EgLZQNuJxvztkQDypE1qPR3MA emeL6rT9zeMNnCMwr3u4cyA5a+aH/llF8yHBsHAGgp5W7ISy1IQ7WB9BfpFmvwNq JSPN1Km+tHIk2sRfKuNX/q0TODSi6tXHq6ijWMa2XPHNt7Dy33Wn9NLA0zOdisXF ajUHDGwM85OPcjSnntXJDe52ecNZvP/T81b9Bv/wmSTkgcVPCQxB6NeJHapXrFHN 5eiJ70IJq+mO8Wynk/7Xs4F3n2I8VjtelePmMO6gmyo1OGqgUPzVxNnrWlydvCKt SRLUEkl4+DWDcCTn7kAAHH4GuPqkf81Mr1MiDOlekdp2N5FkV16Mxdh/8jA1kw1t B6bFCZVtAE5G7JNyCN6P3k0griuic9LOIup6fvW0OQEGvI20PdG8HZFgLC+Poxlj 80B8OoIJTBqAYSgLUtkrYtRBRG0p/ujUaGML/E61dG01bOkJaNg= =1QD2 -----END PGP SIGNATURE----- --GENgK/C4JPBwxlNO--