Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1GTC-0002By-Uz for pgsql-committers@arkaria.postgresql.org; Wed, 15 Jun 2022 00:01:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o1GSD-0000Lk-5T for pgsql-committers@arkaria.postgresql.org; Wed, 15 Jun 2022 00:00:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1GSC-0000Lb-U8 for pgsql-committers@lists.postgresql.org; Wed, 15 Jun 2022 00:00:12 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1GS8-0005gD-8B for pgsql-committers@lists.postgresql.org; Wed, 15 Jun 2022 00:00:11 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D5B6C5C010D; Tue, 14 Jun 2022 20:00:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 14 Jun 2022 20:00:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1655251204; x=1655337604; bh=RR3mZfapfc mS/Yq62bfDn9vVmZAtEkBAW4uEVYcc7pE=; b=XDaIk2g7mlfVTf1qSKBh/q8C8N ymo8ihKEjbj1n+W6wHmHumjcjIKyzwK4yPzwHmDW7OB7K0SGhPp+yyhOdi4eyCyN jeMILe0BAXKTkJylmIBDgqKME8gxIAJf95WvjLK8qYO5btqMBLd88CW9DM1BNAuB G/yQYe5DLqE6CbzbzpPnSlhYPA+tf2NPdkNTV2yKoIPazQuZgWlU4f90Gov9SSi2 UJ5nAZO66nN5lRHoyRU8rcsrkXW0g7fqaR1xG9b5yAOFvZtp40ODcM5De/mIeF0K 8GyjZtU13bj57Zm+hGgT24QtICFzgDsVR/gQo6cBP5jDKUnNALNaAEDshvDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655251204; x=1655337604; bh=RR3mZfapfcmS/Yq62bfDn9vVmZAt EkBAW4uEVYcc7pE=; b=Zi+QgAJMmuNgngxdPSYjxWo02Zer2A8eN7NHcOBK43cO jg+U6Xv2ej4XOV0y/Yub1grJvQBO1n9sb99F9/wCDyMYX9qyAPMhsL74fXbXVSpY aI4hUm4gDFE5rrBvqwlJzbKkifILQkiC0Os7zOCes01KWfqD1FFgqo5erOkkhJEE gjGhK45bq2KlmOgRwoxcuPk/NlnLjioUblWwBPvOXZaEVieLO0EVA4fOlPgEJiZJ pH8n0Qio+eJ1h17X0L66FNTRx8U0zKo7G+lfXzldsJkiwCXZy+yh01SGPqbRyF/9 z+osaNREc2iM9ySmTibkKE8xhd+1Iri7FhSM8dJypg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvtddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Jun 2022 20:00:03 -0400 (EDT) Date: Wed, 15 Jun 2022 09:00:00 +0900 From: Michael Paquier To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test Message-ID: References: <90595.1655227384@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/5mb8YQNAhej2AFD" Content-Disposition: inline In-Reply-To: <90595.1655227384@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --/5mb8YQNAhej2AFD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 14, 2022 at 01:23:04PM -0400, Tom Lane wrote: > I suppose it would be too user-unfriendly to generate those scripts > underneath $PGDATA, so don't we need to put back the .gitignore > entries? delete_old_cluster.sh is generated within tmp_check/ in a non-VPATH build: $ cd src/bin/pg_upgrade/ && make check $ find . -name delete_old_cluster.sh ./tmp_check/delete_old_cluster.sh $ git grep chdir -- *.pl t/002_pg_upgrade.pl:chdir ${PostgreSQL::Test::Utils::tmp_check}; Or you have a workflow where you do a "make clean" after running the tests on a past stable branch? This would leave behind delete_old_cluster.sh, especially if the cleanup is triggered on HEAD. With each branch taken in isolation, there is no need for a .gitignore entry. (FWIW, I just use a worktree these days in my flow of patching across multiple stable branches.) -- Michael --/5mb8YQNAhej2AFD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKpIQAACgkQnvQgOdby QH1iRA/+ODMtAIElR2p24a3qEwdJIWwX2VFlo2zNT+SZACSynP7pcCHCsGbeu+HL fNtATCu1TD8GndvLMuxXxiQSCrc7lsxx9QStCtaQ7+EfKMRKCFv4vMFd9JU2lnkJ +1yVnUeOVSUhqBQ+RV/HXBF9n54oLXt0JC7osBUZxaAVpVuuUufTiOGfbhOFyq28 Hs6EB6o1rPGbiVS9YAsYIoe3wvxuTUcFxbLq4y2Q9gcQ3g/4Nfu2iAOfbMQxnhgA haVLWEbYsvOI7veauNz4Sh3P8JG8RqhdhUzzUYgP8lJtz5mkt/34ojCR5OOSuPQT 1ixXW5pVa9a043PnONU9hKk53AU86sI4dCr5XvtSRymZUuDgOlq3gt+/CNgzg7IX GsWHzDls+A1L1DjDq7D/9TslM7uuppM1OCExqJF8SOSYHoj4d6XAMTUeTqmomPD3 HIkFk/c7fSyEDf+iOdMtWbEPlyci+O8QZHiZGsDEzKzmE0nPqtRTQvvprnO0xdy5 O3oF5FVlD2iP1sjV3f8ZbQ/YRQ3s08A05+31XdXFDy6BLb/tsdgwsM1SjRcUUDLw wC0Rke/ksdIrI8WiaqtXXkGb6ldaBsdVolIJdPPqKRCgEW22cEi4KPLVcLIBt+u8 5fIpXbr/ZrFcabtpQSCMp4qZfN3xc1Y+wMGO6wVGrJYin9ql8S4= =KsCH -----END PGP SIGNATURE----- --/5mb8YQNAhej2AFD--